Closed Bug 1912579 Opened 2 years ago Closed 1 year ago

Intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400 -

Categories

(Thunderbird :: Message Reader UI, defect, P5)

defect

Tracking

(thunderbird_esr128 wontfix, thunderbird133 affected)

RESOLVED FIXED
134 Branch
Tracking Status
thunderbird_esr128 --- wontfix
thunderbird133 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(1 file)

Looking at the logs I think all that is probably needed to fix this is to wait slightly longer after the resize event. Maybe an animation frame or similar? Because the second assertion (L#182 "No scrollbars") already has the expected width (and fails because we keep the width we read before the first one).

I added some extra waiting in Bug 1917278 but it seems that wasn't quite enough yet.

There were a bunch of issues with this test.
Simplified the real code to make it more understandable (and using boolean attributes).

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9436741 - Attachment description: Bug 1912579 - Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=#thunderbird-reviewers → Bug 1912579 - Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=freaktechnik
Target Milestone: --- → 134 Branch

Pushed by toby@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/fe4882174805
Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=tobyp

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9436741 [details]
Bug 1912579 - Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=freaktechnik

[Approval Request Comment]
User impact if declined: image overflow handling may not always work correctly
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): fairly safe but not trivial (though issues would be contained to the feature in question)

Attachment #9436741 - Flags: approval-comm-esr128?

Comment on attachment 9436741 [details]
Bug 1912579 - Fix intermittent comm/mail/test/browser/message-reader/browser_imageOverflow.js | The message display needs to be less than 400px wide - 832 < 400. r=freaktechnik

[Triage Comment]
Approved for esr128

Attachment #9436741 - Flags: approval-comm-esr128? → approval-comm-esr128+

Does this bug need bug 1875325 landed on ESR first? It seems to fix an intermittent issue for a test that doesn't exist on ESR.

Apparently yes. I guess it might be best not to uplift this as there are dependencies.

Attachment #9436741 - Flags: approval-comm-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: