1917278 - When I click link button in email, TB enlarges the button image instead of following the link

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jonathan Kamens]

Attachment: msg.eml

1. Save the attached (sanitized of private information) EML file into a folder.
2. Load remote images in the message.
3. Hover the mouse over the "VIEW ACCOUNT" button.
4. Note how the mouse cursor turns into a magnifying glass when you hover over the button.
5. Click the button.
6. Note how Thunderbird enlarges the button image instead of following the link.

If you save the HTML body of the email to disk and load it into Firefox and click the button, Firefox follows the link just fine.

Comment 1

[Jonathan Kamens]

Workaround: right-click on button, select "Open Link in Browser".

Comment 3

[Francesco]

Attachment: image-link.eml (modified)

It seems to depend on whether the image can be scaled up, if you take height and width out of the image tag and use a smaller image that fits, the link is followed.

In older versions of TB, large images in links that didn't fit always showed the hour glass instead following the link, so the regression is that now scaled-down images that do fit, but could be scaled up, also offer the hour glass.

Comment 4

[John]

I can confirm this issue still exists in 131.0b1

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1917278 - Disable shrinktofit for images inside links. r=#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/228823c6b976
Disable shrinktofit for images inside links. r=aleca

Comment 7

[Martin Giger [:freaktechnik]]

Comment on attachment 9430529 [details]
Bug 1917278 - Disable shrinktofit for images inside links. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1875325
User impact if declined: Images inside links might zoom when clicked instead of opening the link.
Testing completed (on c-c, etc.): Tested on c-c, has automated test coverage
Risk to taking this patch (and alternatives if risky): Low risk, exempts elements from zooming, so worst case we offer zooming on fewer images.

Comment 8

[Corey Bryant]

Comment on attachment 9430529 [details]
Bug 1917278 - Disable shrinktofit for images inside links. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Corey Bryant]

Thunderbird 132.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/fdeb305042b4

Comment 10

[Martin Giger [:freaktechnik]]

Comment on attachment 9430529 [details]
Bug 1917278 - Disable shrinktofit for images inside links. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): uplift of bug 1875325
User impact if declined: Can't click on some links
Testing completed (on c-c, etc.): Tested on c-c and c-b for a while now, has automated tests
Risk to taking this patch (and alternatives if risky): Very small behavior change, so risk should be fairly small.

Comment 11

[Corey Bryant]

Comment on attachment 9430529 [details]
Bug 1917278 - Disable shrinktofit for images inside links. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr128

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 128.7.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7fa5fa1fecb5