1912697 - Refresh gets broken on HistoryFragment when device theme has changed

Status: VERIFIED FIXED

(Firefox for Android :: History, defect, P2)

Description

[exploratory666]

Attachment: Screen_recording.mp4

Steps to reproduce

1. Click the '...' button
2. Click the 'History' button
3. Go to device settings
4. Change device theme (does not matter if it is to dark or to light)
5. Come back to 'Firefox'
6. Click the 'Search' icon
7. Swipe down the screen for updating
8. Click the 'Delete' button on the top right of the screen

Expected behavior

The 'Search' icon should respond by allowing a search to be initiated.
The 'Refresh' icon should briefly display and then update the content.
The 'Delete' icon can work normally

Actual behavior

In step 6, 'Search' icon has no response
In step 7, 'Refresh' icon shows forever
In step 8, the 'Delete' button is clickable but fails to completely delete the history.

Comment 1

[exploratory666]

see also

Comment 2

[eclaudiu64]

I can reproduce this error as well.

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Changing the title to only reflect the issue with refresh as the other issues already have bugs filed for them

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842249

:matt-tighe, since you are the author of the regressor, bug 1842249, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842249

Comment 6

[Iorga Gabriel]

Attachment: Bug 1912697 - Refresh and delete history should work after the device theme has changed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd05ec6ca7e9
Refresh and delete history should work after the device theme has changed. r=android-reviewers,npoon

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fd05ec6ca7e9

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 135.0a1 from 12/12 with the following devices:

• Google Pixel 6 (Android 15),
• Xiaomi Mi8 Lite (Android 10), and
• Samsung Galaxy Tab S9 Ultra (Android 14).