1924201 - Open history item gets broken on HistoryFragment when device theme has changed.

Status: RESOLVED FIXED

(Firefox for Android :: History, defect, P2)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Screen_recording_20241011_155130.mp4

Steps to reproduce

1. Go to history
2. Go to device settings and change device them (does not matter if it is dark or light)
3. Come back to fenix
4. Try to open a history item
   a.
   i. Click on the history item
   b.
   i. Long press on the history item
   ii. Click on the 3 dots menu in the top right corner
   iii. Click on either open in new tab or open in private tab

Expected behavior

The corresponding history item is opened in a new tab in fenix.

Actual behavior

Nothing happens.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842249

:matt-tighe, since you are the author of the regressor, bug 1842249, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842249

Comment 3

[Donal Meehan [:dmeehan]]

:rsainani, pinging as Triage Owner, this was set as S2 but there's no priority or activity for the last couple of weeks.
Wondering if this has a priority and if we can expect a fix for Fx133?

Comment 4

[Rahul Sainani [:rsainani]]

Thanks [:dmeehan] this fell through the cracks, we'll aim to fix it this cycle and if possible we can uplift.

Comment 5

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1924201 - Fix open history item when device theme has changed

Comment 6

[Donal Meehan [:dmeehan]]

It's too late for Fx133, the patch does not look like something we would want to uplift.
The soft code freeze for Fx134 starts next week, hopefully it will land in time for Fx134.

Comment 7

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Hi [:dmeehan], thanks for the follow up. I just landed the patch right now so it'll definitely land in time for 134 :). Just curious though, why wouldn't we want to uplift this; is it because it's close to soft freeze and you think it's risky to uplift?

Comment 8

[Donal Meehan [:dmeehan]]

We only have 2 betas left, this could only make one beta build.
It's not a new bug in fx133, that combined with the size of the change does not look like we would take it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9d7d55975e1
Fix open history item when device theme has changed r=android-reviewers,rsainani

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c9d7d55975e1

Comment 11

[Lorand Janos]

Attachment: Edited_Recorder_13112024_160623.mp4

This issue is no longer reproducible on the latest Nightly build (134.0a1 from 2024-11-13).
The history items are opened in a new tab after changing the theme with Firefox in the background with the History page opened. Tested with theme changed from light to dark and from dark to light as well.
Device used for testing: Google Pixel 9 Pro XL (Android 14).
Marking the ticket as verified on 134.