1924214 - Delete items in time range gets broken on HistoryFragment when device theme has changed.

Status: RESOLVED FIXED

(Firefox for Android :: History, defect, P2)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Screen_recording_20241011_160635.mp4

Steps to reproduce

1. Go to history
2. Go to device settings and change device them (does not matter if it is dark or light)
3. Come back to fenix and click on the trash can icon in the time right corner
4. Select any of the radio icons for the time range to delete and click delete
5. Notice that nothing actually got deleted

Expected behavior

The history items in the time range specified are deleted

Actual behavior

Nothing is deleted

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842251

:matt-tighe, since you are the author of the regressor, bug 1842251, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842251

Comment 3

[Donal Meehan [:dmeehan]]

Adding the same comment as https://bugzilla.mozilla.org/show_bug.cgi?id=1924201#c3

:rsainani, pinging as Triage Owner, this was set as S2 but there's no priority or activity for the last couple of weeks.
Wondering if this has a priority and if we can expect a fix for Fx133?

Comment 4

[Rahul Sainani [:rsainani]]

Thanks [:dmeehan] this fell through the cracks, we'll aim to fix it this cycle and if possible we can uplift.

Comment 5

[Donal Meehan [:dmeehan]]

:rsainani, it's too late for Fx133.
Could this be assigned to get something in time for Fx134?

Comment 6

[Rahul Sainani [:rsainani]]

Thanks for the heads up [:dmeehan] We'll try to get to it in 134 if we find some cycles. It's on our radar.

Comment 7

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1924214 - Fix delete items in time range on HistoryFragment when device theme has changed

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e43b8879471
Fix delete items in time range on HistoryFragment when device theme has changed r=android-reviewers,rsainani

Comment 9

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Can QA please verify the fix before uplift? Thanks

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0e43b8879471

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:npoon, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 135.0a1 from 12/10 with the following devices:

• Google Pixel 6 (Android 15),
• Samsung Galaxy S24 (Android 14),
• Xiaomi Mi8 Lite (Android 10), and
• Vivo V23 (Android 14).

Comment 13

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Thanks for verifying! Since we only have 2 beta uplifts left, marking this as WONTFIX