Closed Bug 1913600 Opened 2 years ago Closed 2 years ago

When dragging the multiple selected contacts from the Address Book into To/Cc/Bcc field => adds zero size attachments

Categories

(Thunderbird :: Address Book, defect)

Thunderbird 128
defect

Tracking

(thunderbird_esr115 unaffected, thunderbird_esr128? fixed, thunderbird129 wontfix, thunderbird130 affected, thunderbird131? affected)

RESOLVED FIXED
132 Branch
Tracking Status
thunderbird_esr115 --- unaffected
thunderbird_esr128 ? fixed
thunderbird129 --- wontfix
thunderbird130 --- affected
thunderbird131 ? affected

People

(Reporter: earlgreypicard, Assigned: welpy-cw)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 external file)

Steps to reproduce:

  1. Open Message Compose Window.
  2. Open Address book.
  3. Select multiple contacts and drag & drop them into the To field.

Actual results:

Zero size attachments will be added.
Number of attachments is the number of selected - 1

Expected results:

As in Thunderbird 115, email addresses of the dragged contact are added to the To field.

Regression window:

https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c886f41fd676eca1bcc69a1fdfa1d01396a58ee2&tochange=d6be3f51dd37a62f511e1e7dfdaefa5558eec4ec

Status: UNCONFIRMED → NEW
Component: Untriaged → Address Book
Ever confirmed: true
Keywords: regression
Regressed by: 1851536
Summary: When dragging the multiple selected contacts from the Address Book into To/Cc/Bcc field, then adds zero size attachments → When dragging the multiple selected contacts from the Address Book into To/Cc/Bcc field => adds zero size attachments

I'm not getting this consistently, and seems it's the same with one attachment.
Not sure why it only happens sometimes, seems like mostly when I drag coming in from above(!??).
Code might be around here: https://searchfox.org/comm-central/rev/35be0aeea42f282cf0d90d4ce0af7e6ac4c91d8a/mail/components/compose/content/MsgComposeCommands.js#9998

See Also: → 1918927

Since https://phabricator.services.mozilla.com/D193762 has landed, multiple selected contacts with display names that are dragged into the compose window are treated as attachments. This patch excludes dragged items containing the "text/x-moz-address" flavor from being checked for valid attachments and handles them directly.

Assignee: nobody → h.w.forms
Status: NEW → ASSIGNED
Duplicate of this bug: 1918927
See Also: 1918927 →
Severity: -- → S3
Duplicate of this bug: 1920553
Target Milestone: --- → 132 Branch

Pushed by toby@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/96dd56129a64
Adjust drag'n'drop handling of compose window after bug 1851536. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Duplicate of this bug: 1922876

Comment on attachment 9425407 [details]
Bug 1913600 - Adjust drag'n'drop handling of compose window after bug 1851536. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1851536
User impact if declined: it may be impossible to drag multiple contacts into the compose window
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): very low

Attachment #9425407 - Flags: approval-comm-esr128?

Comment on attachment 9425407 [details]
Bug 1913600 - Adjust drag'n'drop handling of compose window after bug 1851536. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Attachment #9425407 - Flags: approval-comm-esr128? → approval-comm-esr128+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: