1915255 - Using Shift+Delete when focus is on the message body pane results in the "Confirm Deletion" message twice

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David Lowndes]

Steps to reproduce:

As per the summary:

1. Click on the main message pane to put keyboard focus there - the message in the message list should then show with a grey background (rather than blue).
2. Press Shift+Delete
3. Choose the Delete button from the "Confirm Deletion" dialog.

Actual results:

"Confirm Deletion" dialog re-appears.

Expected results:

Message should have been deleted without seeing the "Confirm Deletion" dialog a second time.

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed. 115 worked like it should. Maybe from bug 958088?

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1915255 - Avoid asking for delete confirmation twice. r=mkmelin

If about:message inside about:3pane had focus, shift-deleting, deleting from trash, or
deleting a news message showed the confirmation dialog twice.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/33e1b7d5d184
Avoid asking for delete confirmation twice. r=mkmelin

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9421218 [details]
Bug 1915255 - Avoid asking for delete confirmation twice. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 958088
User impact if declined: See bug description
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): very low

Comment 5

[Corey Bryant]

Comment on attachment 9421218 [details]
Bug 1915255 - Avoid asking for delete confirmation twice. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 131.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/971559db9c2b

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9421218 [details]
Bug 1915255 - Avoid asking for delete confirmation twice. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 958088
User impact if declined: Possibly unsettling double confirmation when deleting things
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Corey Bryant]

Comment on attachment 9421218 [details]
Bug 1915255 - Avoid asking for delete confirmation twice. r=mkmelin

[Triage Comment]
Approved for esr128

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 128.3.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/b937dc179d8c