958088 - TB does not ask for confirmation when using Shift+Delete in a unified folder, the conversation view, or the "Search Messages" dialog.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

1) Let's use Unified folders view (View -> Folders -> Unified).
2) Go to e.g. Inbox and delete there some message using Shift+Delete shortcut.
3) Thunderbird wont ask for confirmation (when using All folders view, it does). And because the Trash is skipped... the message is lost.

Note: Not sure, if it's relevant for the issue, but trying it with a GMail account, I was still able to find the message using Google webmail, but it was not in the Inbox and has no tags.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Menu/button definition is same in both "All" and "Unified".
See bug 956446 for current menu/button definition.
Difference is;
(a) Unified Folder == A Search Folder(Virtual Folder) with multiple search taret folders
(b) Because of (a), actual "delete mails" is execute on each "actual search target folder".
(c) Defined as a search folder(virtual folder) under hidden "smart malboxes" account.
(d) Because of (a) && (c), thread pane column choice is not changed by "Apply Column to"
    at "All" view.

Do you see your problem on "Search Folder" at "All" view?

As seen in bug 956446, Shift modifier is perhaps ignored if "Delete Message" of context menu.
What operation at where do you call by "Shift+Delete"?

Comment 2

[WADA:World Anti-bad-Duping Agency]

Following is relevant to wraing upon "delete message".
> mail.warn_on_collapsed_thread_operation : default=true
> mail.warn_on_shift_delete               : defaul=true
> news.warn_on_delete                     : default=true
Do you modify these prefs setting?

"Shift+Delete mails at an Unified Folder" can request "Shift+Delete of messages" for following mail folders at same time.
  local mail folder of all POP3 accounts and Local Folders :
     All is "Move to Trash" model. Folder name of "Trash" can not be altered.
  IMAP mail folder of all IMAP accounts :
     IMAP delete model of IMAP account = Move to trash
     IMAP delete model of IMAP account = Remove it immediately
     IMAP delete model of IMAP account = Just mark it as deleted
  If IMAP, "Offline-Use=On or Off" can be different among relevant IMAP mail folders.

If only one mail is selected at Thread pane of an Unified Folder and Shift+Delete is requested, above is perhaps not problem.
However, if multiple mails are selected at thread pane, difference of mail folders may be relevant to problem.

How many mails did you select at Thread Pane of an Unified Folder?
If multiple mails are selected, what kind of accounts/Folders are relevant to the Shift+Delete request?
(Show Account and Location column)
Do you see your problem when only one mail is selected?

Comment 3

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I'm using just Shift+Delete (keys, not buttons) to permanently delete the e-mail. Tried it with only one e-mail and no prefs modified, also in a completely new profile.

I've found out some more information:
* With only one account, it's OK - the warning is shown even in the "Unified" view.
* When you have multiple accounts, then TB warns only when you're deleting the message in "Inbox/[e-mail]" folder. Deleting from common (root) "Inbox" folder produces no warning at all.

(By deleting I mean using Shift+Delete keys.)

Comment 4

[WADA:World Anti-bad-Duping Agency]

If "Unified" View, following is shown at folder pane(Inbox example).
  (0) Inbox : (Unified folder==A Search folder, for actual mail folders used for Inbox)
      (1) Accout_name_1 : Actual Inbox folder of this account_1
       |
      (N) Accout_name_N : Actual Inbox folder of this account_N
       |
      (Z) Accout_name_Z : Actual Inbox folder of this account_Z
Where did you do your "using 'Shift+Delete keys' for a mail or multiple mails"?

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

In (0)Inbox.

Comment 6

[WADA:World Anti-bad-Duping Agency]

It may be problem due to mixed accounts in Virtul Folder.

When an IMAP account's setting is "Just mark it as deleted", "mail flagged as \Deleted" is shown some times with strike-thru line & trash can icon, but is not shown(hidden) some times.
This looks depends on "Which mail's account is used for 'Delete model' determination".
Following is observed(known issue).
- If "Search target folders" is changed to "IMAP account only",
  (this is possible even when Unified Folder via Folder Properties,)
  (although it's reset by Folder View change, restart of Tb etc.   )
  and "Just mark it as deleted" is used by all selected IMAP accounts,
  "mail flaged as \Deleted" is always shown with strike-thru line & trash can icon.
- If non-IMAP account is mixed, following can occur.
  - When "Local Folders" is added to "Search target folder",
    "mail flaged as \Deleted" is shown with strike-thru line & trash can icon.
    but when "Local Folders" is removed and POP3 account is added to "Search target
    folder", "mail flaged as \Deleted" is not shown(hidden).
  - When "mail at offset=0 in non-iMAP folder" is deleted and Vrtual Folder is reopened,
    "mail flaged as \Deleted" is shown with strike-thru line & trash can icon,
    but when Compact is executed on non-iMAP folder and mail of offset=0 appears again,
    "mail flaged as \Deleted" is not shown(hidden).
This is perhaps that "Delete model of an Virtual Folder" is determined by "account of mail which has smallest MessageKey(==Order Received column value)".

Similar but different confusion looks to exist in Tb's "Delete mail/Shift+Delete mail" when Virtual Folder.
Following is observed.
- When two IMAP accounts are search target folder, and delete model=Just mark it as
  deleted, "Shift+Delete of mails" is executed without warning.
- When two non-IMAP accounts are search target folder,
  "Shift+Delete of mails" is executed without warning.
- When one account only is search target folder,
  warning is issued upon "Shift+Delete of mails".

Confirming.

Comment 10

[Frederick Zhang]

Another problem, which I believe is related to this nine year old issue, is that there are no warnings when deleting emails in the unified Deleted (trash) folder either, despite mail.warn_on_delete_from_trash (and mail.warn_on_shift_delete) being set to true. I'm using Thunderbird 102.2.0.

And btw bug 1739175 and bug 1506700 seem to be duplicates of this one as well.

Comment 13

[Jaap van der Leer]

I have just observed this same bug when deleting one single email (from a gmail account) in the unified Inbox in TB 118.

mail.warn_on_shift_delete = default/true

The email is formally completely deleted from gmail, however, it is recoverable in the webmail interface.

When an email is deleted from the inbox of an account, the warning is there.

Comment 14

[sfhowes]

TB 115.3.1/W11, All Folders display: Shift+Delete key shows confirmation warning. Same with Shift+Delete button in Header Pane.

Shift+Delete message from context menu shows no warning. Same with selection of multiple messages and Shift+Delete in Conversations pane.

Comment 15

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 958088 - Move message delete confirmations to front-end. r=#thunderbird-reviewers

• This shows the appropriate confirmation dialog also when deleting messages in a unified folder, a conversation view or in the Search Messages dialog.
• Disable move/delete operations for expanded headers in Grouped By views (see also bug 1873313).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70fc5d232a39
Move message delete confirmations to front-end. r=darktrojan