1918681 - "List all tabs" button impossible to remove

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Erwan]

Attachment: Capture d’écran 2024-09-13 155455.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

After the last update, a new tool appeared in the toolbar: “list all tabs”.
I didn't see any use for this tool, so to avoid overloading my bars, I decided to remove it (as well as the “new tab” tool).

Actual results:

I was able to delete “new tab”, but I can't delete “list all tabs”, the logo is greyed out.

Ps: Ditto for “Extensions”, which still hasn't been resolved after all this time.

Expected results:

With the 'customize toolbar' tool, I should have been able to move and remove these tools from my toolbar.

Comment 1

[Tom S]

I suspect we are going to see a lot more reports now that icon changed and is a lot more noticeable. Considering we just removed the pref for disabling this button in bug 1916622, this is probably not going to happen.

Comment 2

[Erwan]

(In reply to Tom S [:evilpie] from comment #1)

I suspect we are going to see a lot more reports now that icon changed and is a lot more noticeable. Considering we just removed the pref for disabling this button in bug 1916622, this is probably not going to happen.

Do you mean that this problem is destined to stay as it is?
If that's the case, I really don't understand the logic: why take away users' right to customize their Firefox?

Personalization is a strength of the Firefox browser, why go back on this important aspect?

They've already arbitrarily imposed the end of the compact format (which I still use), then they imposed the “extension” button and now they're going to add more and more. Why this authoritarian philosophy? I don't see how activating the existing “remove from taskbar” option would be a problem.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

For now, I believe the recommended approach for users that truly want to hide this button is to use a userChrome.css rule. In the long term, we're in the process of migrating some of the functionality of the button/panel into the surfaces that we're developing for sidebar, vertical tabs and tab groups. When that is completed, we may revisit whether we need this button / panel at all.

Comment 5

[Eddie Carswell]

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Eddie Carswell from comment #5)

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Copying my response from an internal discussion:

From my perspective, the main thing stopping us from allowing users to remove the button is that it contains the hidden tabs sub menu, which is sort of a stop-gap solution for add-ons hiding tabs that could be malicious or that don't provide a good UI for re-showing tabs. It's a safeguard for a theoretical concern, that in practice shouldn't get much usage (which is often part of the nature of a safeguard). Note that disabling/uninstalling such add-ons re-shows hidden tabs too. I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

Comment 7

[Erwan]

(In reply to Dão Gottwald [:dao] from comment #6)

(In reply to Eddie Carswell from comment #5)

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Copying my response from an internal discussion:

From my perspective, the main thing stopping us from allowing users to remove the button is that it contains the hidden tabs sub menu, which is sort of a stop-gap solution for add-ons hiding tabs that could be malicious or that don't provide a good UI for re-showing tabs. It's a safeguard for a theoretical concern, that in practice shouldn't get much usage (which is often part of the nature of a safeguard). Note that disabling/uninstalling such add-ons re-shows hidden tabs too. I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

Not using this extension, why impose it on me? The extension's coders are free to add code requiring this tool. But we can't impose it on everyone just because only one extension needs it...
I have trouble understanding you sometimes.

Comment 9

[wildbydesign]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

For now, I believe the recommended approach for users that truly want to hide this button is to use a userChrome.css rule. In the long term, we're in the process of migrating some of the functionality of the button/panel into the surfaces that we're developing for sidebar, vertical tabs and tab groups. When that is completed, we may revisit whether we need this button / panel at all.

Can somebody please suggest some userChrome.css code for hiding this button?

I have tried a variety of css code variations to hide it but nothing was successful. My CSS knowledge is extremely limited though so I don't understand much of it.

Thank you.

Comment 10

[wildbydesign]

Sorry for the double-post, but there does not seem to be a way to edit a post on Bugzilla.

In the userChrome.css file, the following code works successfully on 131:
#alltabs-button { display: none !important; }

I found it at the following link:
https://support.mozilla.org/en-US/questions/1463682

Comment 11

[Tom S]

I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

The button being unremovable and more prominent is now generating a lot of complaints. Can we look into resolving this question?

Comment 14

[Hudson]

(In reply to Dão Gottwald [:dao] from comment #6)

(In reply to Eddie Carswell from comment #5)

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Copying my response from an internal discussion:

From my perspective, the main thing stopping us from allowing users to remove the button is that it contains the hidden tabs sub menu, which is sort of a stop-gap solution for add-ons hiding tabs that could be malicious or that don't provide a good UI for re-showing tabs. It's a safeguard for a theoretical concern, that in practice shouldn't get much usage (which is often part of the nature of a safeguard). Note that disabling/uninstalling such add-ons re-shows hidden tabs too. I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

Seems like a bit of a bandaid solution in my opinion... Needs to be at least togglable. Frankly, if there are "hidden" dodgy tabs thats being created, why not implement an actual Menu button or other method to prevent them from being uncaught? One that's much less intrusive on the main UI of course.

Let's be real here, 98% of end-users aren't going to go clicking hidden tabs for security purposes unless they've actually lost something.

Comment 15

[Hudson]

Attachment: greyedout-removefromtoolbar.png

Comment 16

[Charlotte [:xo_chxrlotte_xo]]

(In reply to Hudson from comment #14)

(In reply to Dão Gottwald [:dao] from comment #6)

(In reply to Eddie Carswell from comment #5)

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Copying my response from an internal discussion:

From my perspective, the main thing stopping us from allowing users to remove the button is that it contains the hidden tabs sub menu, which is sort of a stop-gap solution for add-ons hiding tabs that could be malicious or that don't provide a good UI for re-showing tabs. It's a safeguard for a theoretical concern, that in practice shouldn't get much usage (which is often part of the nature of a safeguard). Note that disabling/uninstalling such add-ons re-shows hidden tabs too. I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

Seems like a bit of a bandaid solution in my opinion... Needs to be at least togglable. Frankly, if there are "hidden" dodgy tabs thats being created, why not implement an actual Menu button or other method to prevent them from being uncaught? One that's much less intrusive on the main UI of course.

Let's be real here, 98% of end-users aren't going to go clicking hidden tabs for security purposes unless they've actually lost something.

---

Better still, why not just implement a warning notification for hidden tabs? If this menu has the ability to list hidden tabs, what's stopping us from making this togglable and just displaying a warning if there's been a dodgy tab created without user input? Surely this would achieve the same goal and be less intrusive, as well as (ideally) only activating when it's actually needed?

Comment 17

[Vali]

Please let us remove it by moving it into "customize toolbar".

Comment 18

[Frederick Zhang]

Another thing I just noticed after upgrading to 132.0b2 via Arch official repo was that, List All Tabs initially was placed on the right in the same row as tabs above the address bar and extensions.

I entered Customise Toolbar mode, dragged it down to the right of the address bar, then it was impossible to put it back.

Comment 19

[Frederick Zhang]

(In reply to Frederick Zhang from comment #18)

Another thing I just noticed after upgrading to 132.0b2 via Arch official repo was that, List All Tabs initially was placed on the right in the same row as tabs above the address bar and extensions.

I entered Customise Toolbar mode, dragged it down to the right of the address bar, then it was impossible to put it back.

Please ignore this comment. It was also caused by Bug 1919721. After a 'restore default', I am now not able to drag it down in the first place.

Comment 20

[Mat]

Following as I'm experiencing the same issue (signed up to Bugzilla to report it). There should be some way to remove it, either via about:config or by using the toolbar customiser.

On the hidden tab concern, isn't it possible to show some sort of a sanboxed warning? Not only it would be more noticable to the user but would also remove any of the UX complaints.

Lastly, I don't think it's just a 'small group of opinionated users' but that last bit is offtopic.

Comment 21

[hastalavictoria107]

Dear developers I know you want to validate your existence by writing new features nobody asked for but at least make sure they are easily disabled so the rest of us don't have to waste an hour trying to figure out how to remove them.
Not the first time this happened either.

You say you disabled the toggle because of a security bug with hidden tabs, well I don't think anyone wants those either.
I was about to just reinstall the old version just to get rid of this bug making this so called safety change do the exact opposite of what it is supposed to.

Luckily I found a massive reddit threat with 100s of people complaining about this exact issue, to show me how fix the css sheet in the end.
Not really a minority I'd say.. Tons of angry threads over there on your own Firefox sub reddit maybe you should take a look sometimes..

So please just rollback the change if you can't fix something, or even better, don't implement features nobody asked for.

Comment 22

[Tai]

(In reply to Dão Gottwald [:dao] from comment #6)

(In reply to Eddie Carswell from comment #5)

Is there any reason we can't just remove this button like all the other ones in the interface? Even the new tab button is removable so this one should be as well. Only the user would know if a particular button is useful for them or not.

Copying my response from an internal discussion:

From my perspective, the main thing stopping us from allowing users to remove the button is that it contains the hidden tabs sub menu, which is sort of a stop-gap solution for add-ons hiding tabs that could be malicious or that don't provide a good UI for re-showing tabs. It's a safeguard for a theoretical concern, that in practice shouldn't get much usage (which is often part of the nature of a safeguard). Note that disabling/uninstalling such add-ons re-shows hidden tabs too. I wouldn't be opposed to allowing users to remove the button if add-ons and Product folks think the risk is acceptable.

In this theoretical case, the user can re-add the button through the Customise Toolbar tool. I don't see how not allowing to remove it there add any value.

Comment 23

[Erwan]

[Tracking Requested - why for this release]:Always current

Comment 25

[alberto]

I literally registered an account to post here: give us an option to remove this button. It is hideously annoying.

Yes, there may be a legit security reason to have it, but we should be able to ultimately decide whether or not we want it, especially given how obnoxious the placement is and how the security concern is theoretical only at this point.

Comment 26

[Gregory Pappas [:gregp]]

Attachment: Bug 1918681 - part 1: Allow moving the list-all-tabs button again

In bug 878551, the ability to move the list-all-tabs button was removed
for a few reasons:

Moving this widget to the navbar gives it a tiny scaled version of Toolbar.png (like a horizontal line).

Moving it back to the tab strip make it misbehave. It disappears, but sometimes flickers into view when opening/closing a tab.

These issues are no longer present, so we should be able to allow moving
the list-all-tabs button once again.

Comment 27

[Gregory Pappas [:gregp]]

Attachment: Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab

Depends on D224623

Comment 28

[junk+moz]

I created an account just so I can comment, get tagged as me-too and be hidden as off-topic. Thanks!

Comment 34

[richard.j.e.cooke]

Hi. I'm seeing a new button in my browser after updating it. I think it's this tabs button. Is there a way to remove it please? I don't understand everything people are saying in this chat. I tried "customize toolbar" bar but it didn't work. Thanks.

Comment 35

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox131 (release). However, the bug still has low priority and has low severity.

:pluk, could you please increase the priority and increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ae14bfd6300
part 1: Allow moving the list-all-tabs button again r=dao

Comment 37

[tszentpeteri]

Backed out for causing mochitest failures on browser_UsageTelemetry_toolbars.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-10-08T17:58:55.654Z] 17:58:55     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_toolbars.js | Scalar key alltabs-button_pinned_tabs-bar was unexpected. - true == true - 
[task 2024-10-08T17:58:55.654Z] 17:58:55     INFO - Buffered messages finished
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_toolbars.js | Expected to see see scalar key alltabs-button_pinned_tabs-bar be true. - "undefined" == true - 
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - Stack trace:
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_toolbars.js:assertVisibilityScalars:145
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_toolbars.js:widgetPositions:222
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-10-08T17:58:55.656Z] 17:58:55     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_toolbars.js | widget alltabs-button expected at tabs-bar. - false == true - 
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - Stack trace:
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_toolbars.js:assertVisibilityScalars:149
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_toolbars.js:widgetPositions:222
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-10-08T17:58:55.658Z] 17:58:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-10-08T17:58:55.659Z] 17:58:55     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_toolbars.js | Scalar key home-button_pinned_nav-bar-start was unexpected. - true == true - 

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04e9738d508b
part 1: Allow moving the list-all-tabs button again r=dao

Comment 39

[tszentpeteri]

Backed out for causing mn failures related to test_initialize_vertical_tabs.py

• Backout link
• Push with failures
• Failure Log:

[task 2024-10-09T00:08:56.470Z] 00:08:56     INFO - TEST-START | browser/components/sidebar/tests/marionette/test_initialize_vertical_tabs.py TestInitializeVerticalTabs.test_vertical_widgets_in_area
[task 2024-10-09T00:08:56.471Z] 00:08:56     INFO -  1728432536467	Marionette	DEBUG	1 <- [1,3,null,{"value":null}]
[task 2024-10-09T00:08:56.474Z] 00:08:56     INFO -  1728432536467	Marionette	DEBUG	Closed connection 1
[task 2024-10-09T00:08:56.474Z] 00:08:56     INFO -  1728432536469	Marionette	DEBUG	Accepted connection 2 from 127.0.0.1:53358
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536469	Marionette	DEBUG	2 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536470	Marionette	DEBUG	Waiting for initial application window
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536470	RemoteAgent	TRACE	[9] ProgressListener Start: expectNavigation=false resolveWhenStarted=false unloadTimeout=5000 waitForExplicitStart=false
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536471	RemoteAgent	TRACE	[9] ProgressListener Setting unload timer (5000ms)
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536471	RemoteAgent	TRACE	[9] Wait for initial navigation: isInitial=false, isLoadingDocument=false
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536471	RemoteAgent	TRACE	[9] Document already finished loading: about:blank
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536471	RemoteAgent	TRACE	[9] ProgressListener Stop: has error=false url=about:blank
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536472	Marionette	DEBUG	2 <- [1,1,null,{"sessionId":"fe5060d9-0895-4339-8302-bd1824b023bc","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"133.0a1","platformName":"linux","unhandledPromptBehavior":"dismiss and notify","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0","moz:buildID":"20241008210917","moz:headless":false,"moz:platformVersion":"4.4.0-1014-aws","moz:processID":19152,"moz:profile":"/tmp/tmprxuvac35.mozrunner","moz:shutdownTimeout":60000,"pageLoadStrategy":"normal","timeouts":{"implicit":0,"pageLoad":300000,"script":30000},"setWindowRect":true,"strictFileInteractability":true,"moz:accessibilityChecks":false,"moz:webdriverClick":true,"moz:windowless":false,"proxy":{}}}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536473	Marionette	DEBUG	2 -> [0,2,"WebDriver:SetTimeouts",{"script":30000}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536473	Marionette	DEBUG	2 <- [1,2,null,{"value":null}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536474	Marionette	DEBUG	2 -> [0,3,"WebDriver:SetTimeouts",{"pageLoad":300000}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536474	Marionette	DEBUG	2 <- [1,3,null,{"value":null}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536475	Marionette	DEBUG	2 -> [0,4,"WebDriver:SetTimeouts",{"implicit":0}]
[task 2024-10-09T00:08:56.477Z] 00:08:56     INFO -  1728432536475	Marionette	DEBUG	2 <- [1,4,null,{"value":null}]
[task 2024-10-09T00:08:56.478Z] 00:08:56     INFO -  1728432536476	Marionette	DEBUG	2 -> [0,5,"Marionette:SetContext",{"value":"chrome"}]
[task 2024-10-09T00:08:56.478Z] 00:08:56     INFO -  1728432536476	Marionette	DEBUG	2 <- [1,5,null,{"value":null}]
[task 2024-10-09T00:08:56.479Z] 00:08:56     INFO -  1728432536477	Marionette	DEBUG	2 -> [0,6,"Marionette:GetContext",{}]
[task 2024-10-09T00:08:56.480Z] 00:08:56     INFO -  1728432536477	Marionette	DEBUG	2 <- [1,6,null,{"value":"chrome"}]
[task 2024-10-09T00:08:56.481Z] 00:08:56     INFO -  1728432536478	Marionette	DEBUG	2 -> [0,7,"Marionette:SetContext",{"value":"chrome"}]
[task 2024-10-09T00:08:56.482Z] 00:08:56     INFO -  1728432536478	Marionette	DEBUG	2 <- [1,7,null,{"value":null}]
[task 2024-10-09T00:08:56.482Z] 00:08:56     INFO -  1728432536480	Marionette	DEBUG	2 -> [0,8,"WebDriver:ExecuteScript",{"script":"const { Preferences } = ChromeUtils.importESModule(\n                  \"resource://gre/modules/Preferences.sys.mjs\"\n           ... guments[2];\n\n                prefs = new Preferences({defaultBranch: defaultBranch});\n                prefs.set(pref, value);","args":["sidebar.revamp",true,false],"newSandbox":true,"sandbox":"default","line":944,"filename":"../../venv/lib/python3.8/site-packages/marionette_driver/marionette.py"}]
[task 2024-10-09T00:08:56.485Z] 00:08:56     INFO -  1728432536485	RemoteAgent	TRACE	WebDriverProcessData actor created for PID 19152
[task 2024-10-09T00:08:56.486Z] 00:08:56     INFO -  1728432536485	Marionette	TRACE	[1] MarionetteCommands actor created for window id 2
<...>
[task 2024-10-09T00:09:00.699Z] 00:09:00     INFO -  1728432540699	Marionette	DEBUG	1 <- [1,35,null,{"value":"<html><head></head><body></body></html>"}]
[task 2024-10-09T00:09:00.700Z] 00:09:00     INFO -  1728432540699	Marionette	DEBUG	1 -> [0,36,"Marionette:SetContext",{"value":"chrome"}]
[task 2024-10-09T00:09:00.701Z] 00:09:00     INFO -  1728432540700	Marionette	DEBUG	1 <- [1,36,null,{"value":null}]
[task 2024-10-09T00:09:00.737Z] 00:09:00     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/marionette/test_initialize_vertical_tabs.py TestInitializeVerticalTabs.test_vertical_widgets_in_area | AssertionError: Lists differ: ['firefox-view-button', 'tabbrowser-tabs', 'new-tab-button'] != ['firefox-view-button', 'tabbrowser-tabs', 'new-tab-button', 'alltabs-button']
[task 2024-10-09T00:09:00.737Z] 00:09:00     INFO - 
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - Second list contains 1 additional elements.
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - First extra element 3:
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - 'alltabs-button'
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - 
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - - ['firefox-view-button', 'tabbrowser-tabs', 'new-tab-button']
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - + ['firefox-view-button', 'tabbrowser-tabs', 'new-tab-button', 'alltabs-button']
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - ?                                                            ++++++++++++++++++
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO -  : The tabstrip was populated with the expected defaults
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO - Traceback (most recent call last):
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/marionette_harness/marionette_test/testcases.py", line 198, in run
[task 2024-10-09T00:09:00.738Z] 00:09:00     INFO -     testMethod()
[task 2024-10-09T00:09:00.739Z] 00:09:00     INFO -   File "/builds/worker/workspace/build/tests/marionette/tests/browser/components/sidebar/tests/marionette/test_initialize_vertical_tabs.py", line 135, in test_vertical_widgets_in_area
[task 2024-10-09T00:09:00.739Z] 00:09:00     INFO -     self.assertEqual(
[task 2024-10-09T00:09:00.739Z] 00:09:00     INFO - TEST-INFO took 4232ms
[task 2024-10-09T00:09:00.739Z] 00:09:00     INFO -  1728432540702	Marionette	DEBUG	1 -> [0,37,"Marionette:GetContext",{}]
[task 2024-10-09T00:09:00.739Z] 00:09:00     INFO -  1728432540702	Marionette	DEBUG	1 <- [1,37,null,{"value":"chrome"}]
[task 2024-10-09T00:09:00.740Z] 00:09:00     INFO -  1728432540703	Marionette	DEBUG	1 -> [0,38,"WebDriver:DeleteSession",{}]
[task 2024-10-09T00:09:00.740Z] 00:09:00     INFO -  1728432540704	Marionette	TRACE	[1] MarionetteCommands actor destroyed for window id 2
[task 2024-10-09T00:09:00.740Z] 00:09:00     INFO -  1728432540706	Marionette	DEBUG	1 <- [1,38,null,{"value":null}]
[task 2024-10-09T00:09:00.746Z] 00:09:00     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox -marionette -profile /tmp/tmp3sf0qt6q.mozrunner
[task 2024-10-09T00:09:01.224Z] 00:09:01     INFO -  ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-10-09T00:09:01.253Z] 00:09:01     INFO -  1728432541252	Marionette	INFO	Marionette enabled
[task 2024-10-09T00:09:01.254Z] 00:09:01     INFO -  1728432541254	Marionette	TRACE	Received observer notification final-ui-startup
[task 2024-10-09T00:09:01.307Z] 00:09:01     INFO -  ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-10-09T00:09:01.328Z] 00:09:01     INFO -  1728432541327	Marionette	INFO	Listening on port 2828
[task 2024-10-09T00:09:01.329Z] 00:09:01     INFO -  1728432541329	Marionette	DEBUG	Marionette is listening
[task 2024-10-09T00:09:01.385Z] 00:09:01     INFO -  1728432541385	Marionette	DEBUG	Accepted connection 0 from 127.0.0.1:53390
[task 2024-10-09T00:09:01.499Z] 00:09:01     INFO -  1728432541498	Marionette	DEBUG	Accepted connection 1 from 127.0.0.1:53392
[task 2024-10-09T00:09:01.499Z] 00:09:01     INFO -  1728432541498	Marionette	DEBUG	Closed connection 0
[task 2024-10-09T00:09:01.531Z] 00:09:01     INFO -  1728432541530	Marionette	DEBUG	1 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2024-10-09T00:09:01.534Z] 00:09:01     INFO -  1728432541534	Marionette	DEBUG	Waiting for initial application window
[task 2024-10-09T00:09:03.489Z] 00:09:03     INFO -  console.error: ({})
[task 2024-10-09T00:09:04.486Z] 00:09:04     INFO -  1728432544485	Marionette	TRACE	Received observer notification browser-idle-startup-tasks-finished
[task 2024-10-09T00:09:04.493Z] 00:09:04     INFO -  1728432544493	RemoteAgent	TRACE	[9] ProgressListener Start: expectNavigation=false resolveWhenStarted=false unloadTimeout=5000 waitForExplicitStart=false
[task 2024-10-09T00:09:04.494Z] 00:09:04     INFO -  1728432544493	RemoteAgent	TRACE	[9] ProgressListener Setting unload timer (5000ms)
[task 2024-10-09T00:09:04.494Z] 00:09:04     INFO -  1728432544493	RemoteAgent	TRACE	[9] Wait for initial navigation: isInitial=false, isLoadingDocument=false
[task 2024-10-09T00:09:04.494Z] 00:09:04     INFO -  1728432544493	RemoteAgent	TRACE	[9] Document already finished loading: about:blank
[task 2024-10-09T00:09:04.495Z] 00:09:04     INFO -  1728432544493	RemoteAgent	TRACE	[9] ProgressListener Stop: has error=false url=about:blank
[task 2024-10-09T00:09:04.508Z] 00:09:04     INFO -  1728432544507	Marionette	DEBUG	1 <- [1,1,null,{"sessionId":"dae94e6b-8353-4081-ac44-d1916dea721a","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"133.0a1","platformName":"linux","unhandledPromptBehavior":"dismiss and notify","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0","moz:buildID":"20241008210917","moz:headless":false,"moz:platformVersion":"4.4.0-1014-aws","moz:processID":19668,"moz:profile":"/tmp/tmp3sf0qt6q.mozrunner","moz:shutdownTimeout":60000,"pageLoadStrategy":"normal","timeouts":{"implicit":0,"pageLoad":300000,"script":30000},"setWindowRect":true,"strictFileInteractability":true,"moz:accessibilityChecks":false,"moz:webdriverClick":true,"moz:windowless":false,"proxy":{}}}]
[task 2024-10-09T00:09:04.520Z] 00:09:04     INFO -  1728432544516	Marionette	DEBUG	1 -> [0,2,"Marionette:SetContext",{"value":"chrome"}]
[task 2024-10-09T00:09:04.520Z] 00:09:04     INFO -  1728432544516	Marionette	DEBUG	1 <- [1,2,null,{"value":null}]
[task 2024-10-09T00:09:04.527Z] 00:09:04     INFO -  1728432544521	Marionette	DEBUG	1 -> [0,3,"WebDriver:DeleteSession",{}]
[task 2024-10-09T00:09:04.531Z] 00:09:04     INFO -  1728432544530	Marionette	DEBUG	1 <- [1,3,null,{"value":null}]
[task 2024-10-09T00:09:04.533Z] 00:09:04     INFO -  1728432544532	Marionette	DEBUG	Closed connection 1
[task 2024-10-09T00:09:04.534Z] 00:09:04     INFO - TEST-START | browser/components/tests/marionette/test_no_errors_clean_profile.py TestNoErrorsNewProfile.test_no_errors

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d149f03c5ac6
part 1: Allow moving the list-all-tabs button again r=dao

Comment 41

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d149f03c5ac6

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/565c384eafd0
part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab r=extension-reviewers,mconley,dao,willdurand

Comment 43

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/565c384eafd0

Comment 44

[Dão Gottwald [:dao]]

Comment on attachment 9429109 [details]
Bug 1918681 - part 1: Allow moving the list-all-tabs button again

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Lots of complaints about the button not being removable in Firefox 131.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Enter customize toolbars mode.

• Move the button around like you would move any other button.
• Verify the button still works when moved to another toolbar.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a minimal patch using the standard way for making toolbar buttons removable.
• String changes made/needed:
• Is Android affected?: No

Comment 45

[Dão Gottwald [:dao]]

Comment on attachment 9429110 [details]
Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Loss of a safeguard in case the user removes the button and a malicious extension hides tabs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Remove the all tabs button

• Install a tab hiding extension such as https://addons.mozilla.org/en-US/firefox/addon/panic-tabs/
• Hide tabs via the extension
• Verify that the button is added back to the toolbar and hidden tabs are accessible from it

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): I want to acknowledge that this is not as tiny as part 1, but the code added here only runs when a webextension hides tabs, so it's fairly isolated.
• String changes made/needed:
• Is Android affected?: No

Comment 46

[Erwan]

Updated today, so far everything is working fine. (Nightly Version 133.0a1 build ID 20241009214609).

Comment 47

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9429109 [details]
Bug 1918681 - part 1: Allow moving the list-all-tabs button again

At least this patch needs rebasing for Beta & Release. Probably worth checking part 2 also.

Comment 48

[Dão Gottwald [:dao]]

Attachment: Bug 1918681 - part 1: Allow moving the list-all-tabs button again (patch for uplift)

./mach try auto with this patch: https://treeherder.mozilla.org/jobs?repo=try&revision=a3abfeb3acdf4c2b4a978097c0ee34559f7ff102

Plus part 2 where the original patch applies without conflicts: https://treeherder.mozilla.org/jobs?repo=try&revision=9668b12ac781000560a0bbcb33bcd06ac8c4d5db

Comment 49

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #48)

Created attachment 9430187 [details] [diff] [review]
Bug 1918681 - part 1: Allow moving the list-all-tabs button again (patch for uplift)

./mach try auto with this patch: https://treeherder.mozilla.org/jobs?repo=try&revision=a3abfeb3acdf4c2b4a978097c0ee34559f7ff102

Plus part 2 where the original patch applies without conflicts: https://treeherder.mozilla.org/jobs?repo=try&revision=9668b12ac781000560a0bbcb33bcd06ac8c4d5db

These completely failed in the decision task stage, not sure why...

Comment 50

[Dianna Smith [:diannaS]]

:dao fwiw i ran a try on beta with part 1 and 2 and the decision task was green if you want to check https://treeherder.mozilla.org/jobs?repo=try&revision=aa3cb510cd936cff0a516776324281636930b627

Comment 51

[Dão Gottwald [:dao]]

(In reply to Dianna Smith [:diannaS] from comment #50)

:dao fwiw i ran a try on beta with part 1 and 2 and the decision task was green if you want to check https://treeherder.mozilla.org/jobs?repo=try&revision=aa3cb510cd936cff0a516776324281636930b627

Responded to Dianna on Slack, but I'll repeat here for everyone following along: I've triggered browser chrome tests for that push, gone through the failures, marked known intermittent ones, and with that I think the results look alright. I'll renew the uplift requests.

Comment 52

[Dão Gottwald [:dao]]

Comment on attachment 9430187 [details] [diff] [review]
Bug 1918681 - part 1: Allow moving the list-all-tabs button again (patch for uplift)

see comment 44

Comment 53

[Dão Gottwald [:dao]]

Looks like I can't renew the beta approval request on part 2.

Comment 54

[Giorgia Nichita, Release Desktop QA]

I have verified the fix for part 1 successfully on the latest Nightly 133.0a1 ( 20241010223845) using Win 10 and macOS 11.
The "List all tabs" button is now movable as expected. However, I was unable to verify part 2 with the specific extension provided in the bug description. Instead, I tested it using Panic Tabs, and the functionality worked as intended - the button was added back to the toolbar and the hidden tabs were accessible.

Is it OK to proceed with closing the bug as verified fix for 133 considering this?

Comment 55

[Dão Gottwald [:dao]]

(In reply to Giorgia Nichita, Release Desktop QA from comment #54)

I have verified the fix for part 1 successfully on the latest Nightly 133.0a1 ( 20241010223845) using Win 10 and macOS 11.
The "List all tabs" button is now movable as expected. However, I was unable to verify part 2 with the specific extension provided in the bug description. Instead, I tested it using Panic Tabs, and the functionality worked as intended - the button was added back to the toolbar and the hidden tabs were accessible.

Is it OK to proceed with closing the bug as verified fix for 133 considering this?

Yep, thanks! I've updated the steps to use that add-on instead.

Comment 56

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9430187 [details] [diff] [review]
Bug 1918681 - part 1: Allow moving the list-all-tabs button again (patch for uplift)

Approved for 132.0b7.

Comment 57

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f34a06712e35
https://hg.mozilla.org/releases/mozilla-beta/rev/2426c5d6ee82

Comment 58

[Dianna Smith [:diannaS]]

Comment on attachment 9429110 [details]
Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab

Approved for 131.0.3 dot release

Comment 59

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/c4e92b116a3e
https://hg.mozilla.org/releases/mozilla-release/rev/e69783530d6d

Comment 63

[Giorgia Nichita, Release Desktop QA]

Verified as fixed for both part 1 and part 2 on Firefox Beta 132.0b7 (treeherder build 20241011172705) and Firefox 131.0.3 (20241011205646) using Win 10 and macOS 11.