1916658 - need protocol logging for ews

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

We should add protocol logging for EWS.
For other protocols, see https://wiki.mozilla.org/MailNews:Logging (this should be updated once we have ews as well).

For the conversation, please use C: something for what the client said, and S: something for what the server responded, and no prefix for other things of interest.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1916658 - protocol logs for ews. r=babolivier,leftmostcat

This adds some basic protocol logging for ews.
It uses the common convetion of "C: " for data the Client sends, and "S: " for received data from the Server. Other parts do not have prefixes.

Enable console output by setting setting MOZ_LOG=ews_xpcom::*:5

There are some caveats:

• using MOZ_LOG_FILE will not work (bug in core presumably)
• trace! and debug! level logging are compile-time disabled on non-debug builds due to toolkit setting release_max_level_info.
  • it may or may not be easy to enable it for us but enabling could have global performance implications so I'm not doing that for now
  • I'm instead logging the protocol interations using info! so that end users will be able to provide logs. It's not fully ideal, but not super bad either, IMHO.

I'm sure this can be improved but at least it's a start which people can fix it when it doesn't provide them what they need.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/39b45c8b3035
protocol logs for ews. r=babolivier