1936296 - [EWS] Log response status code, and don't log payloads by default

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Brendan Abolivier [:babolivier]]

This bug tracks two follow-up improvements to the protocol logging work that was done in bug 227034 (and will be implemented simultaneously):

• Including the response's status code when logging an operation response
• Gate the logging of raw request/response bodies behind an environment variable (e.g. THUNDERBIRD_LOG_NETWORK_PAYLOADS) so they're not lumped into the more generic logging (since they might include sensitive data)

Comment 1

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1936296 - Log EWS response status code. r=leftmostcat

Comment 2

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1936296 - Only log EWS request/response bodies when requested. r=#thunderbird-back-end-reviewers

This was initially included in https://phabricator.services.mozilla.com/D231690,
where it got a passing functional review, but was then split out because there
was a disagreement over whether this was a good idea. See that revision for the
previous discussion.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f90ab8530d20
Log EWS response status code. r=leftmostcat,mkmelin,tobyp

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/86a81654e9e7
Only log EWS request/response bodies when requested. r=leftmostcat