1918168 - Create in-app-notification custom element

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alex Schmitz]

Create an in-app-notification custom element.

Requirements:

• Take in a notification object and translate the data to attributes on the custom element container.
• Emit events for cta click and close to be consumed by manager
• Add tests for showing notification container and emitting events
• add page to story book

Comment 1

[Alex Schmitz]

Attachment: Bug 1918168 - Create in-app-notification component. r=freaktechnik

Comment 2

[Magnus Melin [:mkmelin]]

Bitrotted, please rebase

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7864e58bc831
Create in-app-notification component. r=freaktechnik

Comment 4

[Geoff Lankow (:darktrojan)]

browser_inAppNotificationCloseButton.js has an intermittent failure on opt builds and a permanent failure on debug builds. I suspect they're related, given the nature of that assertion failure in the debug logs.

I'm going to leave this patch in the tree for now, but if you think it'll take longer than a day to fix, please get a sheriff to back it out.

(Setting the needinfo flag for visibility, I don't actually need any info.)

Comment 5

[Alex Schmitz]

Attachment: Bug 1918168 - Updated connection of l10n root and fix timeout in test. r=#thunderbird-reviewers

Comment 6

[Geoff Lankow (:darktrojan)]

Let's get this landed to clear up the tree a little.

Comment 7

[Martin Giger [:freaktechnik]]

Might also have to reopen for sheriffs to notice.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1848f5dfc369
Updated connection of l10n root and fix timeout in test. r=darktrojan

Comment 9

[Martin Giger [:freaktechnik]]

Uplifted to ESR in bug 1936307