Closed Bug 1918168 Opened 6 months ago Closed 6 months ago

Create in-app-notification custom element

Categories

(Thunderbird :: General, task)

Thunderbird 132

Tracking

(Not tracked)

RESOLVED FIXED
132 Branch

People

(Reporter: arschmitz, Assigned: arschmitz)

References

Details

Attachments

(2 files)

Create an in-app-notification custom element.

Requirements:

  • Take in a notification object and translate the data to attributes on the custom element container.
  • Emit events for cta click and close to be consumed by manager
  • Add tests for showing notification container and emitting events
  • add page to story book
Summary: Create in app notification → Create in-app-notification custom element

Bitrotted, please rebase

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/7864e58bc831
Create in-app-notification component. r=freaktechnik

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

browser_inAppNotificationCloseButton.js has an intermittent failure on opt builds and a permanent failure on debug builds. I suspect they're related, given the nature of that assertion failure in the debug logs.

I'm going to leave this patch in the tree for now, but if you think it'll take longer than a day to fix, please get a sheriff to back it out.

(Setting the needinfo flag for visibility, I don't actually need any info.)

Flags: needinfo?(arschmitz)

Let's get this landed to clear up the tree a little.

Target Milestone: --- → 132 Branch

Might also have to reopen for sheriffs to notice.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/1848f5dfc369
Updated connection of l10n root and fix timeout in test. r=darktrojan

Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Flags: needinfo?(arschmitz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: