1921184 - The changes made to the new toolbar affect the order and correct positioning of the old toolbar

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P3)

Description

[eclaudiu64]

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:132.0) Gecko/132.0 Firefox/132.0

Steps to reproduce:

I noticed that changes are always made to the existing toolbar on the official version of Firefox. A few versions ago, a few months ago we saw modifications to the address bar. For example now in the last version of Firefox Nightly the toolbar has been modified again, compare with version 130 and Nightly 132. And I also add that the square for the tab tray and the 3 points for the menu are spaced apart, this is in addition to the fact that the address bar has always been shorter and after it got wider and now in Nightly it is again short in size.

Actual results:

Changes are always made to the existing toolbar that affect the displayed order.

Expected results:

All options in the toolbar should be correctly aligned in a row.

Comment 1

[eclaudiu64]

Attachment: 20240926_112946.jpg

This is fine Nightly 132.0a1 (Build #2016046578), hg-c8a25946ad59+
GV: 132.0a1-20240925152840
AS: 132.20240924050319

Comment 2

[eclaudiu64]

Attachment: 20240926_112933.jpg

This is Firefox relanse 130

Comment 3

[eclaudiu64]

Can a more thorough check be done?

Comment 4

[eclaudiu64]

Attachment: Screenshot_20241014-131952_Firefox Nightly.jpg

And now the current toolbar has been modified again. Until the new toolbar is put into operation in the official version, you should stop changing the current toolbar every time, because every time it also ends up in the relanse vetsiunea.

Comment 5

[Roger Yang [:royang]]

Confirmed that this is the case. Unfortunately there were some padding changes that we decided to make the same change on the current (original) toolbar. I do agree that the most recent change does make the non-toolbar redesign toolbar looks bad. I'll investigate to see if there is a easy fix for it. Thanks

Comment 6

[Roger Yang [:royang]]

confirmed that there were changes to the padding of the address bar to ensure accessibility touch targets. There were also some changes to the padding as well. Here are the changes: Bug 1923115, Bug 1909751 and Bug 1919161.

Unfortunately to ensure large enough touch targets, we had to move some of the icons towards the middle of the address bar. Hopefully the fix for Bug 1923115 made it a little bit better but other than that I don't think there's more we can do without affecting accessibility.

Closing as won't fix. Thanks,

Comment 7

[Roger Yang [:royang]]

One thing I do notice is display mode vs edit mode have a different padding. I'll reopen and investigate what's the expected behaviour here.

Comment 8

[Roger Yang [:royang]]

Attachment: Screen_recording_20241029_115344.webm

Comment 9

[Roger Yang [:royang]]

Attachment: Bug 1921184 - Align HomeFragment display toolbar with BrowserFragment display toolbar.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fe6502757b6
Align HomeFragment display toolbar with BrowserFragment display toolbar. r=android-reviewers,skhan

Comment 11

[Roger Yang [:royang]]

Comment on attachment 9434586 [details]
Bug 1921184 - Align HomeFragment display toolbar with BrowserFragment display toolbar.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Toolbar padding in Fenix doesn't match when in home page vs opened tab.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Padding change in Fenix only.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7fe6502757b6

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9434586 [details]
Bug 1921184 - Align HomeFragment display toolbar with BrowserFragment display toolbar.

Approved for 133.0b4

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3dab65c8323f