1921857 - "Close tabs to the left/right" should save and close groups, including collpased groups

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Stephen Thompson [:sthompson]]

Current behavior with 3 tabs (standalone 1, grouped 1, grouped 2):

• With tab group not collapsed: Standalone 1 active, Close Tabs to the Right, only standalone 1 is left and the group is gone
• With tab group collapsed: Standalone 1 active, the context menu has “Close Tabs to the Right” greyed out as an option. A similar thing happens when a tab group is the first item in the tab bar and you have a standalone tab with the “Close Tabs to the Left” option.

Desired behavior:

• "Close tabs to the left/right" context menu option should be available even if the only item(s) to the left/right are collapsed tab groups
• "Close tabs to the left/right" should close any tab groups to the left/right
• The closed tab groups' state should still be saved and available to restore

"Close tabs to the left/right" is currently available as an option based on "visible" tabs to the left/right, which currently excludes tabs in collapsed tab groups.

Currently, I don't know what behavior gBrowser.removeTab and gBrowser.removeTabs have with respect to saving the context that they were in a group.

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,dwalker,jswinarton

1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecc4ec402175
"close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ecc4ec402175