1922134 - Reload the bookmarks panel after signing in to sync

Status: VERIFIED FIXED

(Firefox for Android :: Bookmarks, defect, P3)

Description

[Matt Tighe [:matt-tighe]]

Steps to reproduce

Sign into sync from the bookmarks panel empty state

Expected behavior

Synced bookmarks should appear after exiting the sign in flow

Actual behavior

Synced bookmarks don't appear

Comment 1

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922134 - Reload bookmarks after signing in to sync

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fffb92c75fa
Reload bookmarks after signing in to sync r=android-reviewers,boek

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out 4 changesets (Bug 1922134, Bug 1922140, Bug 1922137, Bug 1922701) for causing fenix failures on BookmarksReducerTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=130d2b29f39832023526989eaeae0ed7e12200a1&selectedTaskRun=FLIZj0LLRUmDqlz7Sp1r0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477458132&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2a5988f2ba0cb142052882d153f55559d32d436

Comment 4

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922134 - Reload bookmarks after signing in to sync

Original Revision: https://phabricator.services.mozilla.com/D224564

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bookmarks MVP + 1 does not ship in 132
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: - feature is behind a nimbus flag and can be rolled back if bugs found
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaf7a8cd9b9c
Reload bookmarks after signing in to sync r=android-reviewers,boek

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aaf7a8cd9b9c

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6837c284fc35

Comment 9

[Mira Lobontiu (Android QA)]

Attachment: 1922134.png

Verified as implemented on the Fenix Nightly 133.0a1 from 10/13 with Realme GT Master Edition (Android 13), and a Samsung Galaxy Tab S9 Ultra (Android 14).

I am unable to also verify on Beta, because the "Enable compose bookmarks" is not available yet in Beta 132.0b6.

Comment 10

[Matt Tighe [:matt-tighe]]

Oh thanks for pointing that out! I had forgotten the visibility in secret settings was being handled differently. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1924557 to change that

Comment 11

[Mira Lobontiu (Android QA)]

Verified as implemented also on the Fenix Beta 132.0b8 with:

• Oppo Find X3 Lite (Android 11), and
• Google Pixel 6 (Android 15).