1922140 - Snackbar crash from using `first`

Status: VERIFIED FIXED

(Firefox for Android :: Bookmarks, defect)

Description

[Matt Tighe [:matt-tighe]]

java.util.NoSuchElementException: Collection contains no element matching the predicate.
at org.mozilla.fenix.library.bookmarks.ui.BookmarksStateKt.undoSnackbarText(BookmarksState.kt:183)

offending line:
val title = this.bookmarkItems.first { it.guid == state.guidsToDelete.first() }.title

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Is the severity for this bug correct?
https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity

S1 (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available

Comment 2

[Matt Tighe [:matt-tighe]]

Nope! I assumed any crasher would be S1 but this won't be live code (behind Nimbus) until after it's fixed. Lowering the severity

Comment 3

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922140 - Handle edge case for snackbar crash

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa03afa30f1e
Handle edge case for snackbar crash r=android-reviewers,boek

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out 4 changesets (Bug 1922134, Bug 1922140, Bug 1922137, Bug 1922701) for causing fenix failures on BookmarksReducerTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=130d2b29f39832023526989eaeae0ed7e12200a1&selectedTaskRun=FLIZj0LLRUmDqlz7Sp1r0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477458132&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2a5988f2ba0cb142052882d153f55559d32d436

Comment 6

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922140 - Handle edge case for snackbar crash

Original Revision: https://phabricator.services.mozilla.com/D224563

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bookmarks MVP + 1 does not ship in 132
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: - feature is behind a nimbus flag and can be rolled back if bugs found
• String changes made/needed: None
• Is Android affected?: yes

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6e80971700
Handle edge case for snackbar crash r=android-reviewers,boek

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cc6e80971700

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f6c4795eb3f

Comment 11

[Mira Lobontiu (Android QA)]

Verified that Fenix Nightly 133.0a1 from 10/13 does not crash

• while saving a page as a bookmark, and tapping on "Edit", or
• when deleting a bookmark, and tapping on "Undo".

Tested with Realme GT Master Edition (Android 13), and a Samsung Galaxy Tab S9 Ultra (Android 14).

I am unable to also verify on Beta, because the "Enable compose bookmarks" is not available yet in Beta 132.0b6.

Comment 12

[Mira Lobontiu (Android QA)]

Verified also on Fenix Beta 132.0b8 with Google Pixel 6 (Android 15), and Oppo Find X3 Lite (Android 11).