1922278 - VR180 and 360 YouTube videos not working in Firefox 131

Status: VERIFIED FIXED

(Core :: Graphics, defect, P1)

Description

[mdawg957]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

Went to a VR180 and a 360 video on YouTube
Attempted to play videos
Videos did not properly play.

Actual results:

Visited two different videos

First video - VR180: https://www.youtube.com/watch?v=hp0EaEDhAog

The playback is continually blinking black. If you pause the video leave the tab for around 5 or 10 seconds and then return and start the video, it plays correctly.

Second video - 360: https://www.youtube.com/watch?v=l_EIE5f2t6M

The playback is completely black, if you pause the video leave the tab and come back again, the video is the correct size, but is now pulsing

Expected results:

Both videos should play smoothly with their controls working and had worked as such in previous versions of Firefox. I did confirm they worked in Firefox ESR 128.3.0 on Windows.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mayank Bansal]

I can repro.
Bisection:

Bug 1912368 - Use GpuProcessTextureId in D3D11TextureData if compositor device is used r=gfx-reviewers,lsalzman

With NVIDIA GPU, original ID3D11Texture2D created by compositor device and ID3D11Texture2D opened from shared handle compositor device seemed to work differently. The original ID3D11Texture2D seemed to work well with STR of Bug 1911237 with NVIDIA GPU.

Then if ID3D11Texture2D is created by compositor device, it seems better to use GpuProcessTextureId instead of shared handle.

Differential Revision: https://phabricator.services.mozilla.com/D218903

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[Mayank Bansal]

can you type "about:support" into your Firefox browser, and copy-paste its contents here?

Comment 5

[mdawg957]

Attachment: about:support

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1912368

Comment 7

[Sotaro Ikeda [:sotaro]]

I confirmed the problem with my PC. I take the bug.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1922278 - Remove unexpected redundant D3D texture copy

Comment 9

[Sotaro Ikeda [:sotaro]]

I found that I did silly mistake in D218903.

Comment 10

[Mayank Bansal]

Win11x64 try builds fixed both this bug, and bug 1922291 for me.

Comment 11

[Sotaro Ikeda [:sotaro]]

Great! Thank you for checking.

Comment 12

[Dianna Smith [:diannaS]]

:sotaro do you think you can set a severity on this? We have a planned dot release on October 15th if you want to request the uplift once this lands.

Comment 14

[Sotaro Ikeda [:sotaro]]

(In reply to Dianna Smith [:diannaS] from comment #12)

:sotaro do you think you can set a severity on this? We have a planned dot release on October 15th if you want to request the uplift once this lands.

Yes. It is nice to include the fix to dot release. Thank you.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b750ae3f1c1
Remove unexpected redundant D3D texture copy r=gfx-reviewers,aosmond

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1b750ae3f1c1

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 19

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9428740 [details]
Bug 1922278 - Remove unexpected redundant D3D texture copy

Beta/Release Uplift Approval Request

• User impact if declined: Hardware decoded video frames rendering like VR180 and 360 YouTube videos caused rendering problem.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change removed the redundant copy and the shared handle is treated as it was before the D218903 change.
• String changes made/needed: none
• Is Android affected?: No

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9428740 [details]
Bug 1922278 - Remove unexpected redundant D3D texture copy

Approved for 132.0b5.

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/14ee7f664bca

Comment 23

[Dianna Smith [:diannaS]]

Comment on attachment 9428740 [details]
Bug 1922278 - Remove unexpected redundant D3D texture copy

Approved for 131.0.3 planned dot release.

Comment 24

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/1d95a07f9b01

Comment 25

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 133.0a1 (2024-10-02) on Windows 10x64 using the youtube videos from comment 0 and the links from bug 1922291 and bug 1922809. The videos are blank or have rubber banding.
The issue is verified fixed with Firefox 133.0a1 (2024-10-10), 132.0b5, and 131.0.3 (20241010155515) from comment 19 on Windows 10x64, macOS 12, and Ubuntu 24.04. The videos from comment 0 and bug 1922291 play as expected. However, the video from bug 1922809 (https://threejs.org/examples/?q=video#webgl_materials_video) plays only on Windows 10x64 and does not play on Ubuntu 24.04 and macOS 12. I have filled bug 1924070 for that but it seems that the issue is reproducible with 130.a01 (2024-07-8) as well. I will reverify this on the 131.0.3 official build once released.

Comment 26

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 131.0.3 on Windows 10x64, macOS 12, and Ubuntu 24.04. The videos from comment 0, bug 1922291, and bug 1922809 play as expected with the mention that the video from bug 1922809 works only on Windows (see bug 1924070 ).