Update SeaMonkey installer to register as handler for media types
Categories
(SeaMonkey :: Installer, enhancement)
Tracking
(seamonkey2.53? affected)
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
3.71 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Register as default svg and webp handler. Register other media types if no handler exists.
For some basic understanding see:
- Bug 1197191 "Add .pdf and media file types to OpenWithProgid".
- Bug 1340568 "Not possible to select Firefox as default browser".
- Bug 1570477 "Register as a webp handler".
We are not using a hash id because there are no different SeaMonkey installation types (Nightly, dev, plonk and so on). Unlike Firefox we have no embedded pdf extension yet so this should not be set.
Assignee | ||
Comment 1•3 months ago
|
||
The installer could use some more changes but this is the minimum needed for it.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Windows is not trying to open SeaMonkey for webp and svg images-
Testing completed (on m-c, etc.): 2.53.20b1pre
Risk to taking this patch (and alternatives if risky): Low impact. Starting with Windows 10 the user needs to set them additonally too in the settings if he wants them to be the default.
String changes made by this patch: --
Comment on attachment 9431253 [details] [diff] [review]
1925023-handler-25320.patch
[Triage Comment]
Seems correct to me r/a=me
Do you need the gap between .xhtml and .svg lines?
Assignee | ||
Comment 3•3 months ago
|
||
The gap isn't strickty needed but the other file types are more "core" types and not media so I thought I add it as a logical separator.
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/636fbc65d820
Register as handler for media types. r=IanN
Description
•