1925656 - Add support for remaining in-app notification types (message + security)

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Toby Pilling [:tobyp]]

Add support for the following types which map to the Figma file as below:
"message" -> the 'yellow' type with title "Security Update"
"security" -> the 'red' type with title "Critical Security Update"

Comment 2

[Alex Schmitz]

Attachment: Bug 1925656 - Add message type for in app notifications. r=freaktechnik

Comment 3

[Phabricator Automation]

Comment on attachment 9438950 [details]
Bug 1925656 - Add message type for in app notifications. r=freaktechnik

Revision D229705 was moved to bug 1928452. Setting attachment 9438950 [details] to obsolete.

Comment 4

[Alex Schmitz]

Attachment: Bug 1925656 - Add message type for in app notifications. r=freaktechnik

Comment 5

[Alex Schmitz]

Attachment: Bug 1925656 - Add security type for in app notifications. r=freaktechnik

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b28604150109
Add message type for in app notifications. r=micahilbery
https://hg.mozilla.org/comm-central/rev/112d26c3c4c5
Add security type for in app notifications. r=micahilbery

Comment 7

[Alex Schmitz]

Comment on attachment 9439371 [details]
Bug 1925656 - Add message type for in app notifications. r=freaktechnik

[Approval Request Comment]
User impact if declined: In app notifications with the message type will not show
Testing completed (on c-c, etc.): automated testing
Risk to taking this patch (and alternatives if risky): low css only change

Comment 8

[Alex Schmitz]

Comment on attachment 9439380 [details]
Bug 1925656 - Add security type for in app notifications. r=freaktechnik

[Approval Request Comment]
User impact if declined: security warning will not show in in app notifications
Testing completed (on c-c, etc.): automated testing
Risk to taking this patch (and alternatives if risky): low is a css only change

Comment 9

[Corey Bryant]

Comment on attachment 9439371 [details]
Bug 1925656 - Add message type for in app notifications. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 10

[Corey Bryant]

Comment on attachment 9439380 [details]
Bug 1925656 - Add security type for in app notifications. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 11

[Corey Bryant]

Thunderbird 134.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/94ff85c44857
https://hg.mozilla.org/releases/comm-beta/rev/0c4dd49fc994

Comment 12

[Martin Giger [:freaktechnik]]

Uplifted to ESR in bug 1936307