1927871 - display themes randomly change

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Moe]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

TB 128.3.3esr (64-bit)
opensuse tumbleweed

Allowed the OS to update TB. Not a problem in v128.3.0.

Actual results:

With this version, the theme keeps changing, spontaneously. If the program is idle for a while, it gets bored and changes the theme.

There does not seem to be any way to stop it from doing so. I have manually selected a number of different themes; none of them are permanently enabled.

Expected results:

I expect the theme to change only when I change the enabled theme.

There a total of six themes available. Yet, when I open TB, a theme not listed is used. Later one of the existing themes randomly becomes enabled.

The "enabled" state of the listed themes does not change when the theme is changed. To return to my preferred theme (which is shown as enabled), I must select another theme, then re-select the preferred one.

Comment 2

[Rob Wu [:robwu]]

@dao How could this be a duplicate of bug 1928082 when the reported issue here is about 128.x (ESR), while the "duplicate" is a regression in 132?

Jim - could you provide the exact steps to reproduce? A video could be helpful, as well as the browser console with log messages.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Rob Wu [:robwu] from comment #2)

@dao How could this be a duplicate of bug 1928082 when the reported issue here is about 128.x (ESR), while the "duplicate" is a regression in 132?

Oops, I didn't catch that.

Comment 4

[Jim Moe]

Jim - could you provide the exact steps to reproduce?

I do nothing out of the ordinary. It simply happens:

1. theme is changed at startup
2. theme is changed randomly while TB is idle and not focused

Comment 5

[Jim Moe]

Further experience shows that TB 128.4.0esr (64-bit) seems to change with the time of day: light for day, dark for night.

Comment 6

[Rob Wu [:robwu]]

Could you provide the exact reproduction steps? Starting from a completely new Thunderbird profile, what themes should we install and what should we do to try and reproduce this bug?

Did you also see any special messages in the global browser console (Ctrl-Shift-J)?

Comment 7

[Jim Moe]

Could you provide the exact reproduction steps?

There are no particular steps. Just using TB.

Did you also see any special messages in the global browser console (Ctrl-Shift-J)?

At startup there are these log entries:

1730744298829	addons.xpi	WARN	Checking /usr/lib64/thunderbird/distribution/extensions for addons
1730744299129	addons.xpi	WARN	Addon with ID [e-mail] already installed, older version will be disabled
1730744299129	addons.xpi	WARN	Addon with ID [e-mail] already installed, older version will be disabled
ImportExportTools NG v14.1.2 background.js:51:10
1730744300438	addons.xpi-utils	WARN	Add-on [e-mail] is not compatible with application version.
1730744300438	addons.xpi-utils	WARN	Add-on [e-mail] is not compatible with application version.
IETNG: importMboxModule.js -v5 importMboxModule-5.js:32:9
IETNG: mboximportExport.js -v7 mboxImportExport-7.js:39:9

At startup there are these errors:

SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
    ensureDataReady resource://gre/modules/JSONFile.sys.mjs:313
    getSubscriptionsDS resource:///modules/FeedUtils.sys.mjs:1419
    getFeedUrlsInFolder resource:///modules/FeedUtils.sys.mjs:695
    setFolderPropertiesFromFolder chrome://messenger/content/folder-tree-row.mjs:403
    setFolder chrome://messenger/content/folder-tree-row.mjs:275
    _createFolderRow chrome://messenger/content/about3Pane.js:2173
    _addSubFolders chrome://messenger/content/about3Pane.js:2367
    initServer chrome://messenger/content/about3Pane.js:978
    _initMode chrome://messenger/content/about3Pane.js:2144
    _toggleMode chrome://messenger/content/about3Pane.js:2092
    set activeModes chrome://messenger/content/about3Pane.js:1995
    init chrome://messenger/content/about3Pane.js:1630
JSONFile.sys.mjs:334:17

SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
    ensureDataReady resource://gre/modules/JSONFile.sys.mjs:381
    getSubscriptionsDS resource:///modules/FeedUtils.sys.mjs:1419
    getFeedUrlsInFolder resource:///modules/FeedUtils.sys.mjs:695
    setFolderPropertiesFromFolder chrome://messenger/content/folder-tree-row.mjs:403
    setFolder chrome://messenger/content/folder-tree-row.mjs:275
    _createFolderRow chrome://messenger/content/about3Pane.js:2173
    _addSubFolders chrome://messenger/content/about3Pane.js:2367
    initServer chrome://messenger/content/about3Pane.js:978
    _initMode chrome://messenger/content/about3Pane.js:2144
    _toggleMode chrome://messenger/content/about3Pane.js:2092
    set activeModes chrome://messenger/content/about3Pane.js:1995
    init chrome://messenger/content/about3Pane.js:1630
JSONFile.sys.mjs:387:21

There are a large number of these errors. There are over 1600 in the two hours TB has been started.

feeds: getFeedUrlsInFolder: feeds db error for account - mailbox://nobody@Feeds : RSS Feeds FeedUtils.sys.mjs:703:16
    getFeedUrlsInFolder resource:///modules/FeedUtils.sys.mjs:703
    feeder resource:///modules/FeedUtils.sys.mjs:288
    downloadFeed resource:///modules/FeedUtils.sys.mjs:408

feeds: getFeedUrlsInFolder: feeds db error - TypeError: ds.data is not iterable FeedUtils.sys.mjs:702:16
    getFeedUrlsInFolder resource:///modules/FeedUtils.sys.mjs:702
    feeder resource:///modules/FeedUtils.sys.mjs:288
    downloadFeed resource:///modules/FeedUtils.sys.mjs:408

Comment 8

[Rob Wu [:robwu]]

Bug 1844244 caused this regression, because it bumped the version from 1.2 to 1.3, without changing the versions at https://searchfox.org/comm-central/rev/feeb98c48d09ee6163c9c402c7903fbb5a19c414/mail/components/MailGlue.sys.mjs#567,572

That triggers the same issue as the one that I encountered and fixed in bug 1928082. Because there are two built-in themes involved, the themes may change seemingly randomly at every startup.

To reduce the maintenance burden, instead of calling it there, it may make sense to call the function that does the same at https://searchfox.org/comm-central/rev/feeb98c48d09ee6163c9c402c7903fbb5a19c414/mail/themes/BuiltInThemes.sys.mjs#93

Comment 9

[John Bieling]

Thanks Rob, for identifying Bug 1844244 as the regressor. I will have a look.

Comment 10

[John Bieling]

Attachment: Bug 1927871 - Use BuiltInThemes.ensureBuiltInThemes() instead of manually specifying theme IDs and versions in MailGlue.sys.mjs. r=#thunderbird-reviewers.

When the built-in themes are updated, their version numbers change and
all checks in the code to verify if the correct versions are installed
have to be adjusted as well. The location in MailGlue.sys.mjs was
forgotten when we last changed the themes in Bug 1844244. It was also
overlooked when we tried to fix this regression for the first time in
Bug 1859271.

Instead of calling AddonManager.maybeInstallBuiltinAddon() manually
with hard coded version strings, we now use a dedicated function from
the BuiltInThemes module. Thanks Rob Wu for pointing me to it. This
removes the need to update this location after future theme changes.

We still have to remember to update the BuiltInThemes module after a
theme change. This patch is therefore adding a test to make sure the
correct version strings are used.

Depends on D228312

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8af21dec3436
Use BuiltInThemes.ensureBuiltInThemes() instead of manually specifying theme IDs and versions in MailGlue.sys.mjs. r=mkmelin

Comment 12

[Jim Moe]

TB 140.1.0esr (64-bit)

I had the impression this was fixed for later that 128esr.
It is not been fixed.

Comment 13

[Rob Wu [:robwu]]

Please create a new bug report with the relevant details (reproduction steps and log files) and share the bug number here.

Comment 14

[Jim Moe]

The new report is 1979951.