1928138 - Make Firefox Refresh work for Selectable Profiles

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement, P3)

Description

[Niklas Baumgardner [:niklas]]

We are disabling Firefox Refresh for MVP in bug 1927824.
We want to get Firefox Refresh working for selectable profiles and related profiles for post 134 work.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1928138 - Make Firefox Refresh work for SelectableProfiles. r=#profiles-reviewers

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1928138 - Make Firefox Refresh work for SelectableProfiles. r=gijs!,mconley!,mossop!,#profiles-reviewers

Comment 4

[Kelimutu [:kiki]]

Hi folks,

Do we have an estimated timeline for when the fix is expected to land in the release version? The SUMO team is currently evaluating whether we’ll need to update articles that reference the refresh functionality more thoroughly, so any clarity on timing would be helpful for planning. Thank you!

Comment 5

[Alice Wyman]

See bug 2000860 comment 10 about the Refresh Firefox option in the Firefox uninstaller described in this article. When I click the Refresh Firefox button in the Firefox 148 Beta uninstaller on Windows 11 (en-US) the refresh works, even though selectable profiles are used.

Comment 6

[Niklas Baumgardner [:niklas]]

(In reply to Kelimutu [:kiki] from comment #4)

Hi folks,

Do we have an estimated timeline for when the fix is expected to land in the release version? The SUMO team is currently evaluating whether we’ll need to update articles that reference the refresh functionality more thoroughly, so any clarity on timing would be helpful for planning. Thank you!

This is likely to land in 150.
This doesn't change how refresh works so I don't think an update to SUMO is needed because of this patch.
The profiles in the new profile groups are currently disabled from using refresh and this enables the profiles to use refresh.

Comment 7

[Kelimutu [:kiki]]

(In reply to Niklas Baumgardner [:niklas] from comment #6)

This is likely to land in 150.
This doesn't change how refresh works so I don't think an update to SUMO is needed because of this patch.
The profiles in the new profile groups are currently disabled from using refresh and this enables the profiles to use refresh.

Great! Thank you so much for clarifying.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8dd27b1c190b
https://hg.mozilla.org/integration/autoland/rev/7f66b402606a
Make Firefox Refresh work for SelectableProfiles. r=mconley,mossop,profiles-reviewers,migration-reviewers,jhirsch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6d3b3e921f9
https://hg.mozilla.org/integration/autoland/rev/35681f3062b1
Revert "Bug 1928138 - Make Firefox Refresh work for SelectableProfiles. r=mconley,mossop,profiles-reviewers,migration-reviewers,jhirsch" for causing multiple failures.

Comment 10

[Serban Stanca [:SerbanS]]

Reverted this because it was causing multiple failures.

• Revert link
• Push with failures
• Failure Log - mochitests failures
• Failure Log - another mochitests failure
• Failure Log - xpcshell failure
• Failure Log - another mochitests failure

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07901cdaee07
https://hg.mozilla.org/integration/autoland/rev/28b432590caa
Make Firefox Refresh work for SelectableProfiles. r=mconley,mossop,profiles-reviewers,migration-reviewers,jhirsch,mkaply,omc-reviewers,urlbar-reviewers,jteow,emcminn

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ browser/components/migration/tests/unit/test_IE_history.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f9246873c95c593583c2011c0c6386c301f8dfc0

Push with failures

Failure log -> TEST-UNEXPECTED-CRASH | browser/components/migration/tests/unit/test_IE_history.js | Test crashed

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c91926ef94ba
https://hg.mozilla.org/integration/autoland/rev/f9246873c95c
Revert "Bug 1928138 - Make Firefox Refresh work for SelectableProfiles. r=mconley,mossop,profiles-reviewers,migration-reviewers,jhirsch,mkaply,omc-reviewers,urlbar-reviewers,jteow,emcminn" for causing xpc failures @ browser/components/migration/tests/unit/test_IE_history.js

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c9945fbe0bcb
https://hg.mozilla.org/integration/autoland/rev/bb5bfe3d84d2
Make Firefox Refresh work for SelectableProfiles. r=mconley,mossop,profiles-reviewers,migration-reviewers,jhirsch,mkaply,omc-reviewers,urlbar-reviewers,jteow,emcminn

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bb5bfe3d84d2