1930292 - Stop using non-zero chromemargin values.

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Emilio Cobos Álvarez (:emilio)]

These were done in windows 7 to shrink the glass margin, but nowadays it should never be needed since windows 10 and 11 don't have such thing.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1930292 - Stop setting non-zero chromemargin values. r=#win-reviewers

These only do something on Windows, and after windows 7 they are not
useful at all.

If this has no fallout I plan to simplify the code further in a
follow-up (we can basically make this a boolean attribute again or so).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1893713e1d17
Stop setting non-zero chromemargin values. r=win-reviewers,handyman

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_findbar_marks.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8cdd018168b025a36b6188eb9afed96e550c8cb0

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_findbar_marks.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d9fe1cd50ec
Stop setting non-zero chromemargin values. r=win-reviewers,handyman

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9d9fe1cd50ec