Open Bug 652123 Opened 13 years ago Updated 1 year ago

Re-enable TestChromeMargin.cpp

Categories

(Core :: Widget: Win32, defect, P3)

defect

Tracking

()

ASSIGNED

People

(Reporter: justin.lebar+bug, Assigned: rkraesig)

References

Details

Attachments

(4 files)

I'm going to disable this test as part of bug 647273.  But we should fix the test and re-enable it.

Convert TestChromeMargin.cpp to use gtest, resolving its old linking
issues. (This also means that it can be moved into a directory nearer
the code it's actually testing.)

One test, which did not compile under a modern warning-flagset, has been
split into two due to unclear semantics -- revealing that this may have
concealed a bug. For now, the questionable test remains active, with
only a warning comment.

Modulo the test-splitting above, this is a minimal patch to get the
tests up and running; modernization and cleanup will follow.

Assignee: nobody → rkraesig
Status: NEW → ASSIGNED

Transform existing code to meet modern style guidelines and use a more
modern dialect of C++.

No functional changes, except possibly for some minor differences in
output formatting.

Depends on D142489

The existing test structure conflated two kinds of failure:

  • the test data doesn't parse
  • the test data parses, and the values are different

These could be separated, but testing the latter is of marginal
(cough) utility -- the PASS tests are probably sufficient for that.
Remove them, and stop providing unused data to the FAIL tests.

Doing so shows that another test was incorrectly(?) succeeding: "4.6"
was being parsed as "4". This test has also been marked, but remains
active.

Depends on D142490

Since should-fail tests no longer take values, replace the C-style
initializer lists with constexpr factory functions that enforce their
absence.

No functional changes.

Depends on D142491

Severity: normal → S4
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: