1934760 - PiP window not fully snapping the corner with widget.windows.pip-decorations.enabled=true

Status: ASSIGNED

(Toolkit :: Picture-in-Picture, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: screenshot

I'm on Windows 10 with dual 4K monitors and 200% DPI scaling. mozregression narrowed the range down to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=500caaac66157c1e050742dd8ac2c959e8c6d4d0&tochange=91e11316d48cf2231d097057e123a01bd78aa7cb

The attached screenshot shows a PiP window which should be snapped to the bottom-right corner of the left monitor, but you can see the padding around it instead of being tight against the boundary like it previously was. If I try to Ctrl+Drag it to the corner, it snaps correctly to the taskbar along the bottom, but the right side of the window ends up on the right screen by the same margin as was previously showing.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: after ctrl+drag to the corner

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1932600

:emilio, since you are the author of the regressor, bug 1932600, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1934760 - Fix PiP snapping code to deal with window decorations. r=#pip-reviewers

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Right... So this is because the code isn't accounting for the now-present window decorations. I have a fix, but I need to fix a bunch of tests, and there's also the issue of the decoration size not being known ahead of time when opening the default window position (though that's fixable I believe).

Comment 6

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=5ff17a30af0c882fb768a14b35c830cb55ddc905 is the try run with this patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

https://treeherder.mozilla.org/jobs?repo=try&revision=5ff17a30af0c882fb768a14b35c830cb55ddc905 is the try run with this patch.

I'm still seeing the incorrect behavior with this build.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Do you see incorrect initial position, or incorrect snapping with Ctrl + drag? My patch fixes the later, the former is a bit trickier (looking into it as well).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Ctrl+drag snapping is better than before, but I do see a slight (like 1-2px) bleed into the other screen still.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Hi Emilio, what's the status of this bug with Fx135 going to RC in about a week and a half?

Comment 11

[Emilio Cobos Álvarez [:emilio]]

So this patch works on windows, but on Linux it does not because the window sizes are all busted there (bug 581863). I need to investigate some minor failures with that patch tho, and I haven't had the time.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Any thoughts on the remaining bit of pixel bleed with the current patch?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930292

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Bug 1934375 effectively disabled the change which caused this problem. Leaving the bug open for follow-up work to address the underlying problem still, however.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68a4d9b25b9e
Fix PiP snapping code to deal with window decorations. r=pip-reviewers,mconley

Comment 16

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_conflictingPips.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/724f323658f2b1008ee2284dd25aa76de95a0f32

Push with failures

Failure log

Comment 17

[Gautam Panakkal]

Attachment: Bug 1934760 - fix PiP snapping code for window decorations r=emilio

Comment 18

[Gautam Panakkal]

Attachment: WIP: Bug 1934760 - Fix PiP snapping code for window decorations r=emilio