1932600 - Some clean-ups after bug 1930292

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao!

This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1932600 - Simplify chrome attribute handling. r=smaug!,dao!

Make them work like html boolean attributes consistently.

Nothing sets these to false afaict, we just remove them when needed
already.

Comment 3

[Phabricator Automation]

Comment on attachment 9439067 [details]
Bug 1932600 - Simplify chrome attribute handling. r=smaug!,dao!

Revision D229768 was moved to bug 1930292. Setting attachment 9439067 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3297e990715a
Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
https://hg.mozilla.org/integration/autoland/rev/2418bfee53f1
Simplify chrome attribute handling. r=smaug,dao

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing chrome failures

Backout: https://hg.mozilla.org/integration/autoland/rev/361ea2ba675fd8d7154bcb42a019d972e1abd216

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Cor%2Cfission%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-chrome-1proc%2Cc2&revision=2418bfee53f18169c403faabdc7a0712ae702d25

Failure log: https://treeherder.mozilla.org/logviewer?job_id=484504974&repo=autoland&lineNumber=6068

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0741b3b770d4
Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
https://hg.mozilla.org/integration/autoland/rev/91e11316d48c
Simplify chrome attribute handling. r=smaug,dao

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0741b3b770d4
https://hg.mozilla.org/mozilla-central/rev/91e11316d48c