1931556 - Implement userScripts permission prompt (mobile)

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, task, P1)

Description

[Rob Wu [:robwu]]

The "userScripts" permission requires double confirmation as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1917000#c1

Bug 1917000 will add the permission string, and bug 1931554 will add the extra notice in the Extensions Manager. In this bug we should implement the permission prompt with checkbox as specified in bug 1917000 and visualized at the right of https://bugzilla.mozilla.org/show_bug.cgi?id=1917000#c3.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1931556 - Part 1: Require double confirmation for userScripts permission

This patch renders the userScripts permission with a checkbox instead of
a visual non-interactive checkmark.

The "Allow" button cannot be clicked until the checkbox is checked.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1931556 - Part 2: Use primary button color in extension prompts

In preparation for adding a "disabled" button style, I noticed that the
current button colors follow an old design system. This patch updates
the colors to the latest version, and defines the aliases for the
"disabled" style, which will be used in the next patch.

The current button in extension permission prompts background has the
"accent" color because it was the design at the time of introduction, in
https://github.com/mozilla-mobile/fenix/issues/8593

The "action primary" style was introduced in
https://github.com/mozilla-mobile/fenix/issues/24055
... but not applied to the existing button.

Comparison of colors (for regular and private browsing):

Before: R.attr.accent
- @color/accent_normal_theme  = @color/photonViolet50
- @color/accent_private_theme = @color/photonViolet50
After: R.attr.actionPrimary
- @color/fx_mobile_action_color_primary         = @color/photonInk20
- @color/fx_mobile_private_action_color_primary = @color/photonViolet60
New: R.attr.actionPrimaryDisabled
- @color/fx_mobile_action_color_primary_disabled         = @color/photonInk20A20
- @color/fx_mobile_private_action_color_primary_disabled = @color/photonViolet60A50 (from fx_mobile_action_color_primary_disabled in values-night/colors.xml)

Before: R.attr.textOnColorPrimary
- @color/fx_mobile_text_color_oncolor_primary         = @color/photonLightGrey05
- @color/fx_mobile_private_text_color_oncolor_primary = @color/photonLightGrey05
After: R.attr.textActionPrimary
- @color/fx_mobile_text_color_action_primary         = @color/photonLightGrey05
- @color/fx_mobile_private_text_color_action_primary = @color/photonLightGrey05
New: R.attr.textActionPrimaryDisabled
- @color/fx_mobile_text_color_action_primary_disabled = @color/photonDarkGrey90A50
- @color/fx_mobile_private_text_color_action_primary_disabled = @color/photonLightGrey05A40 (from fx_mobile_text_color_action_primary_disabled in values-night/colors.xml)

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1931556 - Part 3: Apply disabled style to button when disabled

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1931556 - Part 4: Add extra warning bar for userScripts permission

This is based on the design from https://bugzilla.mozilla.org/show_bug.cgi?id=1917000#c3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6be867ad527f
Part 1: Require double confirmation for userScripts permission r=android-reviewers,willdurand,Roger
https://hg.mozilla.org/integration/autoland/rev/3425347a8e40
Part 2: Use primary button color in extension prompts r=android-reviewers,willdurand,Roger
https://hg.mozilla.org/integration/autoland/rev/3cd62841322c
Part 3: Apply disabled style to button when disabled r=android-reviewers,willdurand,Roger
https://hg.mozilla.org/integration/autoland/rev/b30a8e2d8c4a
Part 4: Add extra warning bar for userScripts permission r=android-reviewers,willdurand,Roger

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6be867ad527f
https://hg.mozilla.org/mozilla-central/rev/3425347a8e40
https://hg.mozilla.org/mozilla-central/rev/3cd62841322c
https://hg.mozilla.org/mozilla-central/rev/b30a8e2d8c4a

Comment 7

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly for Android (138.0a1 – GV: 20250315022318, AS: 138.20250311050358) on an Oppo Reno 6 5G running Android 13, using the extension linked in https://bugzilla.mozilla.org/show_bug.cgi?id=1931554#c2.

The extension requesting the userScripts optional permission will show a prompt requiring a double confirmation and a warning message stating Unverified scripts can pose security and privacy risks. Only run scripts from extensions or sources you trust..
The double confirmation consists of a checkbox stating Allow unverified third-party scripts to access your data which when not checked will disable the Allow button on the prompt and when checked will enable the Allow button on the prompt.

When the userScripts permission is not granted on the dialog, the optional permission Allow unverified third-party scripts to access your data from the “Permissions” page of the extension will remain disabled. When the permission is allowed on the dialog, the optional permission on the “Permissions” page also gets enabled.

User scripts added in the extension will correctly run if the permission is granted on the dialog and will not run when the permission is not granted, as expected.

For more details, see the attached screenshot.

Comment 8

[Alex Cornestean]

Attachment: 5ecbe0ae-f019-412b-bb48-874d6d9e06f3.JPEG

Comment 9

[Alex Cornestean]

Attachment: f59f9dd9-6dfd-480c-903b-235be0512b73.JPEG