1935250 - Moz-message-bar text is not readable on dark HCM themes

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Only "Show me how" is visible form the message bar offering to restore tabs in Nightly

With HCM enabled, the message bar's text is not readable because the browser-toolbox-background is relying on --toolbox-textcolor-inactive variable that resolves in black text on black background on Win11 Night Sky theme (attached screenshot of the startup-restore-session-suggestion infobar), dark gray text against gray background on other default dark High Contrast themes and it is not readable on them all.

It is expected that the foreground color would be using CanvasText system color to be used against the (current) background Canvas color to ensure all HCM themes would provide color pair expected by a user.

Figma reference for a HCM infobar component (WIP) - SSO required to access

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1928151

:emilio, since you are the author of the regressor, bug 1928151, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'm confused, did you confirm that was the regressing bug with mozregression? The toolbox text / background pair is fine, otherwise the tabs would have no contrast. it just seems that the message bar overrides the background but not the color?

I can look at it regardless I suppose

Comment 3

[Anna Yeddi [:ayeddi]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

I'm confused, did you confirm that was the regressing bug with mozregression? The toolbox text / background pair is fine, otherwise the tabs would have no contrast. it just seems that the message bar overrides the background but not the color?

I can look at it regardless I suppose

Not at the moment, wasn't sure how to trigger the infobar again thus poked around styles... Sorry for the ping - moving this to the (more) appropriate regressor (MozRegression three times in a row tried to point to the bug 1920080 that has even less to do with the bug 1928151, but one of the patches' parents shed some light on the root cause).

Testing note:
In ASRouter Admin, search for "infobar" and press its "Show" button to get the message bar

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I guess this is not terribly hard to special-case, but I think the root cause of the issue is that some of these tokens don't have a suitable foreground color, they just kind of assume that the color is fine which it might not? Or I guess they assume they go against var(--text-color) in which case the code was right before bug 1906207

Comment 5

[Tim Giles [:tgiles]]

Hey Mark, can you take a look at this? It appears to be a regression from Bug 1906207. This is something we should fix sooner rather than later. It might be as straightforward as restoring the --message-bar-text-color: var(--text-color); and color: var(--message-bar-text-color); lines, but I haven't looked any further into it.

Comment 6

[Mark Kennedy [:mark]]

Yeah the text color change seems to be out of scope of Bug 1906207 and the reason it was asked for initially isn't entirely clear. So I'm going to revert it and open a patch. Thank you!

Comment 7

[Mark Kennedy [:mark]]

Attachment: Bug 1935250 - Revert removal of message-bar-text-color r?#recomp-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e522bfa98023
Revert removal of message-bar-text-color r=reusable-components-reviewers,desktop-theme-reviewers,hjones

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e522bfa98023

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkennedy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Mark Kennedy [:mark]]

Comment on attachment 9442574 [details]
Bug 1935250 - Revert removal of message-bar-text-color r?#recomp-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency:
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Mark Kennedy [:mark]]

Comment on attachment 9442574 [details]
Bug 1935250 - Revert removal of message-bar-text-color r?#recomp-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: There was a regression in Windows HCM where the text of Firefox infobar messages cannot be read; Simple revert of CSS regressor
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple revert of code that already existed
• String changes made/needed:
• Is Android affected?: Unknown

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/615791f9752c