19373 - [DOGFOOD]option elements don't update their label correctly

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[rods (gone)]

Attachment: demonstrates the problem for select

Comment 1

[rods (gone)]

This actually show two problems:
1) The option element gets its "label" attr set but is never asked to reflow to
display the new value. The following lines get executed in
nsGenericHTMLElement.cpp:

  if (aNotify && (nsnull != mDocument)) {
    mDocument->AttributeChanged(mContent, aNameSpaceID, aAttribute,
NS_STYLE_HINT_UNKNOWN);
  }
I think the unknown hint makes it not reflow.

Problem #2:
The combobox frame needs to be notified that the selected option's label or
content was changed so it can update itself properly and reflow.

It could be an optimized notification (only happens when the selected object is
changed) or a more general notification.

Comment 2

[rods (gone)]

after the label is set select the second item. The "hello" shows up in the combo
display area but the option frame doesn't display the new value.

Comment 3

[rickg]

putting on PDT radar

Comment 4

[Eric Pollmann]

I've tried returning a style hint of reflow for changes of the label attribute
on an option.  Unfortunately, this isn't quite enough.  It updates the label
displayed in the text field of a combobox when the option is selected, but does
not update the label displayed in the listbox.  Returning a style hint of
'framechange' has the exact same effect.  It seems the only hint guaranteed to
update all of the display as needed is 'reconstruct all' which is a bit extreme
for this situation.  I'll continue working on this until I have a reasonable
solution.

Comment 5

[Eric Pollmann]

This seems like a relatively minor UI issue - is this bug blocking development?

Comment 6

[rods (gone)]

The problem is when when RDF loads all the items and the options get different
labels the select actually displays the wrong value until you click on it.

So it isn't blocking development, but it is a critical (blocking) issue for the
UI)

Comment 7

[rods (gone)]

*** Bug 18642 has been marked as a duplicate of this bug. ***

Comment 8

[daver]

Can we get a status update on this bug?  Thanks.

Comment 9

[Eric Pollmann]

I have a patch for problem 1) but not problem 2).  Attaching the patch.

Comment 10

[Eric Pollmann]

Attachment: Patch for problem 1)

Comment 11

[rods (gone)]

Taking the bug

Comment 12

[rods (gone)]

passes back reflow hint and notifies the combox it should update its
display - fixed

Comment 13

[Chris Petersen]

Fixed in the Dec 9th build (1999120908)

Comment 14

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.