Closed Bug 193923 Opened 21 years ago Closed 18 years ago

[win32] use system beep on Windows for notification

Categories

(SeaMonkey :: Find In Page, defect)

1.8 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8.1alpha2

People

(Reporter: bugzilla, Assigned: philor)

References

Details

(Keywords: fixed-seamonkey1.1a, fixed1.8.1)

Attachments

(1 file)

spun off from bug 185905.

find as you type should use the win32 OS beep for notifications. mail
notification and popup blocking does this by default. since win32 offers a
control panel where the user can change the sound, the configuration should go
there --rather than adding complexity / bloat to mozilla.
*** Bug 207402 has been marked as a duplicate of this bug. ***
You can just set

user_pref("accessibility.typeaheadfind.soundURL", "beep");

to get this behaviour.
Attached patch fixSplinter Review
Rationale: on Mac or Linux, if you are deaf, the checkbox in your system prefs that you checked when you first got your computer causes the window/titlebar to flash for typeaheadfind, on Windows you have to either keep looking down to the statusbar, or discover that changing a hidden pref will make it work; on Mac or Linux, if you are working at the library or somewhere else quiet, telling your OS to shut up will shut up typeaheadfind, on Windows you have to either know about and remember an unobvious pref for SeaMonkey, or a hidden pref for Firefox.
Assignee: aaronleventhal → philringnalda
Status: NEW → ASSIGNED
Attachment #216613 - Flags: superreview?(jag)
Attachment #216613 - Flags: review?(aaronleventhal)
*** Bug 331990 has been marked as a duplicate of this bug. ***
*** Bug 315354 has been marked as a duplicate of this bug. ***
Attachment #216613 - Flags: superreview?(jag) → superreview+
Attachment #216613 - Flags: review?(aaronleventhal) → review?(mconnor)
Comment on attachment 216613 [details] [diff] [review]
fix

Ok, worth a shot, especially in alpha.
Attachment #216613 - Flags: review?(mconnor) → review+
Keywords: helpwanted
Whiteboard: [checkin needed]
Comment on attachment 216613 [details] [diff] [review]
fix

Maybe I can make it aaronlev's fault this way instead ;)
Attachment #216613 - Flags: approval-branch-1.8.1?(aaronleventhal)
Comment on attachment 216613 [details] [diff] [review]
fix

Sorry Phil, I don't own this code anymore. Don't want anything to do with it.
Attachment #216613 - Flags: approval-branch-1.8.1?(aaronleventhal)
Comment on attachment 216613 [details] [diff] [review]
fix

Let's get this on branch too, get the real feedback!
Attachment #216613 - Flags: approval-branch-1.8.1+
mozilla/modules/libpref/src/init/all.js 	3.585.2.28
mozilla/modules/libpref/src/init/all.js 	3.628
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.8.1alpha2
Version: Trunk → 1.8 Branch
Status: RESOLVED → REOPENED
Hardware: All → PC
Resolution: FIXED → ---
Target Milestone: mozilla1.8.1alpha2 → ---
Version: 1.8 Branch → Trunk
oops
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8.1alpha2
Version: Trunk → 1.8 Branch
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.