1944011 - Generate boilerplate for more LIR instructions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 1: Modernise GenerateLIRFiles.py. r=jandem!

Changes:

• Replace import for "six" with "io".
• Use format strings.
• Properly handle the case when BoxedValue and Int64 operands are used.
• Support Int64 temps.
• Fix assertion expressions.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 2: Generate boilerplate for more LIR nodes. r=jandem!

Some of these use Int64 temps which are supported through part 1.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 3: Generate LIR boilerplate for atomics operations. r=jandem!

The number of temp-registers used by these atomics operations is arch-specific.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 4: Use ToTempRegisterOrInvalid where applicable. r=jandem!

Part 3 unconvered code which doesn't use ToTempRegisterOrInvalid. Handle also
the remaining code which can be updated to ToTempRegisterOrInvalid.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 5: Remove unused default arguments. r=jandem!

Remove unused default arguments, so it's easier to generate the boilerplate for
these instructions.

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 6: Generate boilerplate for DOM LIR nodes. r=jandem!

This involved reordering the JSContext temp-register.

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 7: Generate boilerplate for assert-range LIR nodes. r=jandem!

After removing the const Range* range() {...} getters, we can also generate
the boilerplate code for these instructions.

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 8: Generate boilerplate for control instruction LIR nodes. r=jandem!

Add a new "successors" attribute that, if present, will generate control
instruction LIR nodes.

Then update a few simple cases to use the new attribute.

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 9: Generate boilerplate for LBitAndAndBranch and LBitAnd64AndBranch. r=jandem!

Moving the assertion from the Assembler::Condition cond() {...} getter allows
to generate the LIR boilerplate for these two instructions, too.

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 10: Remove unused LUnaryMath. r=jandem!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239ccdcdf890
Part 1: Modernise GenerateLIRFiles.py. r=jandem
https://hg.mozilla.org/integration/autoland/rev/8fce999b3fb3
Part 2: Generate boilerplate for more LIR nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/03fa134d25af
Part 3: Generate LIR boilerplate for atomics operations. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6137bbc143b4
Part 4: Use ToTempRegisterOrInvalid where applicable. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f91049616a51
Part 5: Remove unused default arguments. r=jandem

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dab74f36ecea
Part 6: Generate boilerplate for DOM LIR nodes. r=jandem

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84d654fa0df1
Part 7: Generate boilerplate for assert-range LIR nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/00d2f2325196
Part 8: Generate boilerplate for control instruction LIR nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/110ced30d11e
Part 9: Generate boilerplate for LBitAndAndBranch and LBitAnd64AndBranch. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c97b3983de6f
Part 10: Remove unused LUnaryMath. r=jandem

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 11: Generate LIR boilerplate when extraName method is present. r=jandem!

Some LIR instructions were almost eligible for automatic boilerplate generation,
except they had an additional extraName method. The extraName() method is
called in LNode::getExtraName(), which requires JS_JITSPEW to be defined.

Adding extra_name to request adding the declaration of extraName() and then
moving the method definition out of line enables to generate the LIR boilerplate
for more cases.

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 12: Generate boilerplate for MinMax LIR nodes. r=jandem!

• If we accept replacing LMinMaxBase with LInstructionHelper<1, 2, 0> in
  one place, we can generate the boilerplate for the non-array version.
• After removing isMax() from LMinMaxArray{I,D}, we can generate the LIR
  boilerplate for the array version.

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 13: Generate boilerplate for three remaining simple cases. r=jandem!

Some additional simple cases where the boilerplate can be generated.

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 14: Remove unused CodeGeneratorXXX::splitTagForTest. r=jandem!

There are comments which mentions this is used for LTestVAndBranch, but that's
actually not true anymore.

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 15: Make generated LIR operands getters const. r=jandem!

The generated LInt64Allocation getters are already marked as const. Also
mark the LAllocation getters as const for consistency.

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 16: Prefer named getters instead of getInt64Operand calls. r=jandem!

In preparation for later patches, update LIR nodes from "LIR-shared.h" to use
named getters instead of getInt64Operand.

Drive-by change: Remove unnecessary const for value variables.

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 17: Prefer named getters instead of getInt64Operand calls (arch-specific). r=jandem!

Add named Int64 operand getters to arch-specific LIR nodes.

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 18: Fix "const LInt64Allocation" occurences. r=jandem!

Replace const LInt64Allocation by:

1. When a parameter, use instead const LInt64Allocation&.
2. When a return-by-value, drop the const.

Returning values as const should be avoid in general, because it interferes
with move semantics.

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 19: Add named getters to CopySign LIR nodes. r=jandem!

In preparation for later patches, alreay update the CopySign nodes to use
named getters.

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 20: Use named temp definition getters if possible. r=jandem!

Replace getTemp(n) calls with the named temp getter in "CodeGenerator.cpp".

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 21: Generate LIR boilerplate for LDivI. r=jandem!

LDivI was defined separately for each architecture and on x86-shared, it
additionally defined extraName(). Use a single definition for all
architecture, so extraName() is available everywhere.

Comment 25

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 22: Generate LIR boilerplate for TableSwitch nodes. r=jandem!

Similar to LDivI, LTableSwitch and LTableSwitchV were also defined for each
architecture, even though we can actually use a shared definition.

Also changes the newLTableSwitch and newLTableSwitchV method to only
perform the allocation. The pointer to MTableSwitch is then later assigned
through the add call.

Comment 26

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 23: Prefer named accessor instead of getOperand or getDef. r=jandem!

More updates to used named getters, which avoids referring to the operands using
constants.

• Let LBitOpI inherit from LBinaryMath to be able to use lhs and rhs getters.
• Remove unnecessary output() method definitions and instead let it use the
  definition from LInstructionFixedDefsTempsHelper::output.

Comment 27

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 24: Prefer shared MacroAssembler methods for LWrapInt64ToInt32 codegen. r=jandem!

Use the shared MacroAssembler methods to address the comment in the ARM64 code.

Comment 28

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 25: Generate boilerplate for LModPowTwoI. r=jandem!

Another case like LDivI where we can use a shared definition.

Comment 29

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 26: Generate boilerplate for Int64ToFloatingPoint. r=jandem!

Comment 30

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 27: Generate boilerplate for WasmUint32To{Double,Float32}. r=jandem!

These need a temp register only on x86 and x64.

Comment 31

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 28: Generate boilerplate for WasmTruncateToInt64. r=jandem!

Comment 32

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 29: Generate boilerplate for LWasmAtomicBinopI64. r=jandem!

Also updates lowering on 32-bit platforms to directly allocate an LInt64Allocation
instead of two LAllocations. (This matches the JS code for atomics, too.)

Comment 33

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 30: Generate boilerplate for LWasmAtomicExchangeI64. r=jandem!

Comment 34

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 31: Generate boilerplate for LWasmCompareExchangeI64. r=jandem!

These are almost the same everywhere, except that the operands are sometimes in
a different order...

Comment 35

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 32: Generate boilerplate for LWasmAtomicLoadI64. r=jandem!

Comment 36

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 33: Generate boilerplate for LWasmAtomicStoreI64. r=jandem!

Comment 37

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/239ccdcdf890
https://hg.mozilla.org/mozilla-central/rev/8fce999b3fb3
https://hg.mozilla.org/mozilla-central/rev/03fa134d25af
https://hg.mozilla.org/mozilla-central/rev/6137bbc143b4
https://hg.mozilla.org/mozilla-central/rev/f91049616a51
https://hg.mozilla.org/mozilla-central/rev/dab74f36ecea
https://hg.mozilla.org/mozilla-central/rev/84d654fa0df1
https://hg.mozilla.org/mozilla-central/rev/00d2f2325196
https://hg.mozilla.org/mozilla-central/rev/110ced30d11e
https://hg.mozilla.org/mozilla-central/rev/c97b3983de6f

Comment 38

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 34: Generate boilerplate for LModMaskI. r=iain!

Drive-by change:

• Replace temp(LDefinition::GENERAL) with just temp(), because it's not
  necessary to explicitly pass the default argument.

Comment 39

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 35: Generate boilerplate for some ARM64 Div and Mod instructions. r=iain!

Comment 40

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 36: Generate boilerplate for LSoftDivI and LSoftModI. r=iain!

Comment 41

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 37: Remove unused CodeGeneratorXXX::ToTempValue. r=iain!

Comment 42

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 38: Add LBoxAllocation getters. r=iain!

Generate getters for boxed operands which return LBoxAllocation, similar to
how LInt64Allocation is returned for int64 allocations.

Part 39 will then update all current ToValue callers to use newly generated
getters.

Comment 43

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 39: Use boxed operands getters. r=iain!

Update all ToValue callers at once to avoid running in name resolution
errors: The various CodeGenerator classes all define ToValue as an method,
which hides the newly added ToValue function in the js::jit namespace.

Comment 44

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 40: Replace another caller with named getters. r=iain!

Comment 45

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 41: Generate boilerplate for LUnboxFloatingPoint. r=iain!

Comment 46

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 42: Combine LUnboxBase and LUnbox. r=iain!

Both classes can be merged after part 41.

Comment 47

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 43: Generate boilerplate for LBoxFloatingPoint. r=iain!

Comment 48

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 44: Generate boilerplate for LModI. r=iain!

Needs a temp register on non-ARM targets, except for that difference the
definition can be shared.

Comment 49

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 45: Remove CodeGeneratorARM64::emitSimpleBinaryI64. r=iain!

Remove CodeGeneratorARM64::emitSimpleBinaryI64 by aligning codegen for
AddI64 to match AddI more closely. (Same for subtraction and bit-ops.)

That way we also avoid calling getInt64Operand and can instead use the
named getters.

Comment 50

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 46: Share implementation for CodeGenerator::visitRotateI64. r=iain!

Comment 51

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 47: Add option to defer initialisation of operands and temps. r=iain!

Many ALU and FPU instructions don't initialise their operands in the
constructor. To support this pattern add a new attribute "defer_init", which
allows initialising operands and temps through setter methods.

The next parts will use this new attribute.

Comment 52

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 48: Generate boilerplate for LIR nodes with deferred initialisation. r=iain!

lowerForShiftInt64 needed some larger changes because the LIR instruction
generator currently places all word-sized operands first, whereas LShiftI64
and LRotateI64 have an Int64 operand first, followed by a word-sized operand.

And in addition to that, if we want to use newly generated setters, we also
need separate code paths, because the operands are differently named for
LRotateI64 when compared to LShiftI64.

Comment 53

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 49: Generate boilerplate for LMulI. r=iain!

LMulI has the same definition for all targets except for x86 and x64. On
those two targets the operands are directly initialised and a third
operand is used.

Comment 54

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 50: Generate boilerplate for LSoftUDivOrMod. r=iain!

Also allows to remove LBinaryCallInstructionHelper.

Comment 56

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 51: Generate LIR boilerplate for simple Wasm cases. r=jandem!

Comment 57

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 52: Add index for word operands. r=jandem!

Multiple Wasm instructions refer to word-sized operands using index constants.
Supporting this use case enables generating the boilerplate for Wasm instructions.

Comment 58

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 53: Generate LIR instructions for WasmSelect nodes. r=jandem!

Generate the boilerplate for the three WasmSelect instructions.

Comment 59

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 54: Generate LIR instructions for WasmLoad nodes. r=jandem!

• Changed lowering to allocate temp register first to avoid setTemp calls.
• Reordered code for MIPS lowering to match changes in part 55.

Comment 60

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 55: Generate LIR instructions for WasmStore nodes. r=jandem!

Drive-by change:

• Clean-up lowering to avoid duplicate lines to allocate registers.

Comment 61

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 56: Generate boilerplate for LWasmCompareExchangeHeap. r=jandem!

Comment 62

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 57: Generate boilerplate for LWasmAtomicExchangeHeap. r=jandem!

Comment 63

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 58: Generate boilerplate for LWasmAtomicBinopHeap. r=jandem!

Comment 64

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 59: Generate boilerplate for LWasmAtomicBinopHeapForEffect. r=jandem!

Comment 65

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 60: Generate boilerplate for LWasmLoadLaneSimd128. r=jandem!

Comment 66

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 61: Generate boilerplate for WasmStoreLaneSimd128. r=jandem!

Comment 67

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 62: Generate boilerplate for LWasmReduceSimd128ToInt64. r=jandem!

Comment 68

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 63: Generate boilerplate for LWasmReduceSimd128. r=jandem!

Comment 69

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 64: Generate boilerplate for LWasmUnarySimd128. r=jandem!

Comment 70

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 65: Generate boilerplate for LWasmInt64ToSimd128. r=jandem!

Comment 71

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 66: Generate boilerplate for LWasmScalarToSimd128. r=jandem!

Comment 72

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 67: Generate boilerplate for LWasmReplaceInt64LaneSimd128. r=jandem!

Comment 73

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 68: Generate boilerplate for LWasmReplaceLaneSimd128. r=jandem!

Comment 74

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 69: Generate boilerplate for LWasmPermuteSimd128. r=jandem!

Comment 75

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 70: Generate boilerplate for LWasmShuffleSimd128. r=jandem!

Comment 76

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 71: Generate boilerplate for LWasmSignReplicationSimd128. r=jandem!

Comment 77

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 72: Generate boilerplate for LWasmConstantShiftSimd128. r=jandem!

Comment 78

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 73: Generate boilerplate for LWasmVariableShiftSimd128. r=jandem!

Comment 79

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 74: Generate boilerplate for LWasmBinarySimd128WithConstant. r=jandem!

Slight change in behaviour:
The generated LWasmBinarySimd128WithConstant::rhs() getter returns SimdConstant
per value instead of as const SimdConstant&.

Comment 80

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 75: Generate boilerplate for LWasmBinarySimd128. r=jandem!

Comment 81

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 76: Generate boilerplate for LWasmTernarySimd128. r=jandem!

Comment 82

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 77: Replace MemoryBarrierBits with a typed MemoryBarrier class. r=jandem!

That way we don't have to worry about incorrect memory barriers in LMemoryBarrier
and can remove the assertion in the constructor. That in turn allows to generate
the boilerplate for LMemoryBarrier. (See part 78.)

Using a separate type also seems to lead to better code generation.

For example Synchronization::isDone() was compiled to this on Clang:

mov     eax, edi
movzx   ecx, ah
movzx   eax, al
or      ax, cx
sete    al
ret

With this patch it's now compiled to:

test    di, di
sete    al
ret

There is no change for GCC, it's still compiled to:

mov     eax, edi
mov     edx, edi
or      dl, ah
test    dl, dl
sete    al
ret

Comment 83

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 78: Generate boilerplate for LMemoryBarrier. r=jandem!

Comment 84

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 79: Generate boilerplate for LDivPowTwoI. r=jandem!

Comment 85

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 80: Generate boilerplate for LUnreachableResultV. r=jandem!

Comment 86

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 81: Generate boilerplate for LUnreachable. r=jandem!

Comment 87

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 82: Use named getter for LOsrReturnValue. r=jandem!

Comment 88

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 83: Fix register allocation for LAtomicTypedArrayElementBinop64 on RISCV. r=jandem!

Comment 89

[André Bargull [:anba]]

Attachment: Bug 1944011 - Part 84: Remove LInstructionFixedDefsTempsHelper::input. r=jandem!

Named getters make this helper obsolete.

Comment 90

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad919afeb2c
Part 11: Generate LIR boilerplate when extraName method is present. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b20c82e5fe2b
Part 12: Generate boilerplate for MinMax LIR nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0cf3f2725535
Part 13: Generate boilerplate for three remaining simple cases. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b5256903d442
Part 14: Remove unused CodeGeneratorXXX::splitTagForTest. r=jandem
https://hg.mozilla.org/integration/autoland/rev/06c418e3cd60
Part 15: Make generated LIR operands getters const. r=jandem
https://hg.mozilla.org/integration/autoland/rev/68439cf27285
Part 16: Prefer named getters instead of getInt64Operand calls. r=jandem
https://hg.mozilla.org/integration/autoland/rev/96ed85f15893
Part 17: Prefer named getters instead of getInt64Operand calls (arch-specific). r=jandem
https://hg.mozilla.org/integration/autoland/rev/0ba88191ffea
Part 18: Fix "const LInt64Allocation" occurences. r=jandem
https://hg.mozilla.org/integration/autoland/rev/af5f70a69ea2
Part 19: Add named getters to CopySign LIR nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b03202f06983
Part 20: Use named temp definition getters if possible. r=jandem

Comment 91

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ff7dd0d2cdd
Part 21: Generate LIR boilerplate for LDivI. r=jandem
https://hg.mozilla.org/integration/autoland/rev/cc823a17aeb5
Part 22: Generate LIR boilerplate for TableSwitch nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/748a4ed1960b
Part 23: Prefer named accessor instead of getOperand or getDef. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5c9329a4876c
Part 24: Prefer shared MacroAssembler methods for LWrapInt64ToInt32 codegen. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b6c9cc580edc
Part 25: Generate boilerplate for LModPowTwoI. r=jandem
https://hg.mozilla.org/integration/autoland/rev/801fb98445de
Part 26: Generate boilerplate for Int64ToFloatingPoint. r=jandem
https://hg.mozilla.org/integration/autoland/rev/01e9c9b5fc1d
Part 27: Generate boilerplate for WasmUint32To{Double,Float32}. r=jandem
https://hg.mozilla.org/integration/autoland/rev/9506e0d74a2e
Part 28: Generate boilerplate for WasmTruncateToInt64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0eb471ea1b97
Part 29: Generate boilerplate for LWasmAtomicBinopI64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/28f5cebc6891
Part 30: Generate boilerplate for LWasmAtomicExchangeI64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/281acb90c6dc
Part 31: Generate boilerplate for LWasmCompareExchangeI64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ba2725f72696
Part 32: Generate boilerplate for LWasmAtomicLoadI64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d16ef8bb4b25
Part 33: Generate boilerplate for LWasmAtomicStoreI64. r=jandem

Comment 92

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c73e8261be76
Part 34: Generate boilerplate for LModMaskI. r=iain
https://hg.mozilla.org/integration/autoland/rev/253359762534
Part 35: Generate boilerplate for some ARM64 Div and Mod instructions. r=iain
https://hg.mozilla.org/integration/autoland/rev/131e3ec05331
Part 36: Generate boilerplate for LSoftDivI and LSoftModI. r=iain

Comment 93

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9182bd881254
Part 37: Remove unused CodeGeneratorXXX::ToTempValue. r=iain
https://hg.mozilla.org/integration/autoland/rev/fb6202ba8cdb
Part 38: Add LBoxAllocation getters. r=iain
https://hg.mozilla.org/integration/autoland/rev/6ec8a25c67c1
Part 39: Use boxed operands getters. r=iain
https://hg.mozilla.org/integration/autoland/rev/8eb6d0534850
Part 40: Replace another caller with named getters. r=iain

Comment 94

[agoloman]

Backed out comment 93 for causing build bustages @CodeGenerator.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 95

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fad919afeb2c
https://hg.mozilla.org/mozilla-central/rev/b20c82e5fe2b
https://hg.mozilla.org/mozilla-central/rev/0cf3f2725535
https://hg.mozilla.org/mozilla-central/rev/b5256903d442
https://hg.mozilla.org/mozilla-central/rev/06c418e3cd60
https://hg.mozilla.org/mozilla-central/rev/68439cf27285
https://hg.mozilla.org/mozilla-central/rev/96ed85f15893
https://hg.mozilla.org/mozilla-central/rev/0ba88191ffea
https://hg.mozilla.org/mozilla-central/rev/af5f70a69ea2
https://hg.mozilla.org/mozilla-central/rev/b03202f06983
https://hg.mozilla.org/mozilla-central/rev/5ff7dd0d2cdd
https://hg.mozilla.org/mozilla-central/rev/cc823a17aeb5
https://hg.mozilla.org/mozilla-central/rev/748a4ed1960b
https://hg.mozilla.org/mozilla-central/rev/5c9329a4876c
https://hg.mozilla.org/mozilla-central/rev/b6c9cc580edc
https://hg.mozilla.org/mozilla-central/rev/801fb98445de
https://hg.mozilla.org/mozilla-central/rev/01e9c9b5fc1d
https://hg.mozilla.org/mozilla-central/rev/9506e0d74a2e
https://hg.mozilla.org/mozilla-central/rev/0eb471ea1b97
https://hg.mozilla.org/mozilla-central/rev/28f5cebc6891
https://hg.mozilla.org/mozilla-central/rev/281acb90c6dc
https://hg.mozilla.org/mozilla-central/rev/ba2725f72696
https://hg.mozilla.org/mozilla-central/rev/d16ef8bb4b25

Comment 96

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/508edd0d6930
Part 37: Remove unused CodeGeneratorXXX::ToTempValue. r=iain
https://hg.mozilla.org/integration/autoland/rev/dafedbc91be0
Part 38: Add LBoxAllocation getters. r=iain
https://hg.mozilla.org/integration/autoland/rev/bbdd4444411e
Part 39: Use boxed operands getters. r=iain
https://hg.mozilla.org/integration/autoland/rev/f0b49aefdeed
Part 40: Replace another caller with named getters. r=iain
https://hg.mozilla.org/integration/autoland/rev/b80311e428f4
Part 41: Generate boilerplate for LUnboxFloatingPoint. r=iain
https://hg.mozilla.org/integration/autoland/rev/997a9233ebce
Part 42: Combine LUnboxBase and LUnbox. r=iain
https://hg.mozilla.org/integration/autoland/rev/6e8d5e2f69a2
Part 43: Generate boilerplate for LBoxFloatingPoint. r=iain
https://hg.mozilla.org/integration/autoland/rev/341ab7cf9661
Part 44: Generate boilerplate for LModI. r=iain

Comment 97

[André Bargull [:anba]]

(In reply to agoloman from comment #94)

Backed out comment 93 for causing build bustages @CodeGenerator.cpp.

Part 39 was missing some stubs for a class which got removed in part 41. This issue only applied to the "wasm32" and "none" JIT backends.

---

For context why I have to land the patches in smaller stacks:

1. Landing large patch stacks leads to Lando timeouts: bug 1747104, bug 1925039
2. Some patches in the patch stack are also affected by this Lando bug: bug 1878430, bug 1925062

Comment 98

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef40425942c5
Part 45: Remove CodeGeneratorARM64::emitSimpleBinaryI64. r=iain
https://hg.mozilla.org/integration/autoland/rev/47c406a8b015
Part 46: Share implementation for CodeGenerator::visitRotateI64. r=iain

Comment 99

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dedd8972bd7d
Part 47: Add option to defer initialisation of operands and temps. r=iain
https://hg.mozilla.org/integration/autoland/rev/6f7a055f0105
Part 48: Generate boilerplate for LIR nodes with deferred initialisation. r=iain
https://hg.mozilla.org/integration/autoland/rev/f7628d6022e9
Part 49: Generate boilerplate for LMulI. r=iain
https://hg.mozilla.org/integration/autoland/rev/f2c987176c86
Part 50: Generate boilerplate for LSoftUDivOrMod. r=iain

Comment 100

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c73e8261be76
https://hg.mozilla.org/mozilla-central/rev/253359762534
https://hg.mozilla.org/mozilla-central/rev/131e3ec05331

Comment 101

[Mayank Bansal]

Would these patches have any (positive or negative, but mainly negative) impact on the build time?

Comment 102

[André Bargull [:anba]]

The patches shouldn't affect build time much. It's mostly replacing hand-written C++ classes with generated classes.

Comment 103

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96bc865569c7
Part 51: Generate LIR boilerplate for simple Wasm cases. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0b41ec74df7c
Part 52: Add index for word operands. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c2225c6cc9bc
Part 53: Generate LIR instructions for WasmSelect nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d174a46baf7c
Part 54: Generate LIR instructions for WasmLoad nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/245eb6d86319
Part 55: Generate LIR instructions for WasmStore nodes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/8e868f706d75
Part 56: Generate boilerplate for LWasmCompareExchangeHeap. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fbd6883e975f
Part 57: Generate boilerplate for LWasmAtomicExchangeHeap. r=jandem
https://hg.mozilla.org/integration/autoland/rev/18a3424e603e
Part 58: Generate boilerplate for LWasmAtomicBinopHeap. r=jandem
https://hg.mozilla.org/integration/autoland/rev/042dd9b04967
Part 59: Generate boilerplate for LWasmAtomicBinopHeapForEffect. r=jandem
https://hg.mozilla.org/integration/autoland/rev/abeb9668ebac
Part 60: Generate boilerplate for LWasmLoadLaneSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c36071c75ee3
Part 61: Generate boilerplate for WasmStoreLaneSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/1717b088cc38
Part 62: Generate boilerplate for LWasmReduceSimd128ToInt64. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b693c987df08
Part 63: Generate boilerplate for LWasmReduceSimd128. r=jandem

Comment 104

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fbdd1f54343
Part 64: Generate boilerplate for LWasmUnarySimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a9a2d234e2fe
Part 65: Generate boilerplate for LWasmInt64ToSimd128. r=jandem

Comment 105

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/508edd0d6930
https://hg.mozilla.org/mozilla-central/rev/dafedbc91be0
https://hg.mozilla.org/mozilla-central/rev/bbdd4444411e
https://hg.mozilla.org/mozilla-central/rev/f0b49aefdeed
https://hg.mozilla.org/mozilla-central/rev/b80311e428f4
https://hg.mozilla.org/mozilla-central/rev/997a9233ebce
https://hg.mozilla.org/mozilla-central/rev/6e8d5e2f69a2
https://hg.mozilla.org/mozilla-central/rev/341ab7cf9661
https://hg.mozilla.org/mozilla-central/rev/ef40425942c5
https://hg.mozilla.org/mozilla-central/rev/47c406a8b015
https://hg.mozilla.org/mozilla-central/rev/dedd8972bd7d
https://hg.mozilla.org/mozilla-central/rev/6f7a055f0105
https://hg.mozilla.org/mozilla-central/rev/f7628d6022e9
https://hg.mozilla.org/mozilla-central/rev/f2c987176c86

Comment 106

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faf015a1d824
Part 66: Generate boilerplate for LWasmScalarToSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d43f91fe327d
Part 67: Generate boilerplate for LWasmReplaceInt64LaneSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fbab15217bd5
Part 68: Generate boilerplate for LWasmReplaceLaneSimd128. r=jandem

Comment 107

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67398dad4dcb
Part 69: Generate boilerplate for LWasmPermuteSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/39043d1461f4
Part 70: Generate boilerplate for LWasmShuffleSimd128. r=jandem

Comment 108

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5838eb5dd844
Part 71: Generate boilerplate for LWasmSignReplicationSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/12e97e4915db
Part 72: Generate boilerplate for LWasmConstantShiftSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/191436781efa
Part 73: Generate boilerplate for LWasmVariableShiftSimd128. r=jandem
https://hg.mozilla.org/integration/autoland/rev/9be821a42253
Part 74: Generate boilerplate for LWasmBinarySimd128WithConstant. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a2074d2f74d7
Part 75: Generate boilerplate for LWasmBinarySimd128. r=jandem

Comment 109

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50a3c4a732f5
Part 76: Generate boilerplate for LWasmTernarySimd128. r=jandem

Comment 110

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5f6d26e73a0
Part 77: Replace MemoryBarrierBits with a typed MemoryBarrier class. r=jandem

Comment 111

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c69c2ac43479
Part 78: Generate boilerplate for LMemoryBarrier. r=jandem
https://hg.mozilla.org/integration/autoland/rev/070157eb340c
Part 79: Generate boilerplate for LDivPowTwoI. r=jandem
https://hg.mozilla.org/integration/autoland/rev/97b9c76902ea
Part 80: Generate boilerplate for LUnreachableResultV. r=jandem

Comment 112

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d641642640d
Part 81: Generate boilerplate for LUnreachable. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f3e582488926
Part 82: Use named getter for LOsrReturnValue. r=jandem
https://hg.mozilla.org/integration/autoland/rev/dd6602ee8a8f
Part 83: Fix register allocation for LAtomicTypedArrayElementBinop64 on RISCV. r=jandem
https://hg.mozilla.org/integration/autoland/rev/990438131ba7
Part 84: Remove LInstructionFixedDefsTempsHelper::input. r=jandem

Comment 113

[amarc]

https://hg.mozilla.org/mozilla-central/rev/96bc865569c7
https://hg.mozilla.org/mozilla-central/rev/0b41ec74df7c
https://hg.mozilla.org/mozilla-central/rev/c2225c6cc9bc
https://hg.mozilla.org/mozilla-central/rev/d174a46baf7c
https://hg.mozilla.org/mozilla-central/rev/245eb6d86319
https://hg.mozilla.org/mozilla-central/rev/8e868f706d75
https://hg.mozilla.org/mozilla-central/rev/fbd6883e975f
https://hg.mozilla.org/mozilla-central/rev/18a3424e603e
https://hg.mozilla.org/mozilla-central/rev/042dd9b04967
https://hg.mozilla.org/mozilla-central/rev/abeb9668ebac
https://hg.mozilla.org/mozilla-central/rev/c36071c75ee3
https://hg.mozilla.org/mozilla-central/rev/1717b088cc38
https://hg.mozilla.org/mozilla-central/rev/b693c987df08
https://hg.mozilla.org/mozilla-central/rev/2fbdd1f54343
https://hg.mozilla.org/mozilla-central/rev/a9a2d234e2fe
https://hg.mozilla.org/mozilla-central/rev/faf015a1d824
https://hg.mozilla.org/mozilla-central/rev/d43f91fe327d
https://hg.mozilla.org/mozilla-central/rev/fbab15217bd5
https://hg.mozilla.org/mozilla-central/rev/67398dad4dcb
https://hg.mozilla.org/mozilla-central/rev/39043d1461f4

Comment 114

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5838eb5dd844
https://hg.mozilla.org/mozilla-central/rev/12e97e4915db
https://hg.mozilla.org/mozilla-central/rev/191436781efa
https://hg.mozilla.org/mozilla-central/rev/9be821a42253
https://hg.mozilla.org/mozilla-central/rev/a2074d2f74d7
https://hg.mozilla.org/mozilla-central/rev/50a3c4a732f5
https://hg.mozilla.org/mozilla-central/rev/e5f6d26e73a0
https://hg.mozilla.org/mozilla-central/rev/c69c2ac43479
https://hg.mozilla.org/mozilla-central/rev/070157eb340c
https://hg.mozilla.org/mozilla-central/rev/97b9c76902ea
https://hg.mozilla.org/mozilla-central/rev/1d641642640d
https://hg.mozilla.org/mozilla-central/rev/f3e582488926
https://hg.mozilla.org/mozilla-central/rev/dd6602ee8a8f
https://hg.mozilla.org/mozilla-central/rev/990438131ba7