1945499 - The color of Tab Groups disappears when an ungrouped tab is placed between two grouped tabs at a certain point

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: tab_group2.gif

Found in

• 136.0a1 (2025-02-03)

Affected versions
136.0a1 (2025-02-03)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 24
• Unaffected platforms: none

Steps to reproduce

1. Group two tabs.
2. Drag another ungrouped tab between the tabs from step 1 and observe the tab group color.

Expected result

• The tab group color persists since the tab is added to the group if the tab is dropped.

Actual result

• At a certain point the tab group color disappears and the tab is added to the group as expected if the tab is dropped.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b7278af32c77e822c8cc5dad005e033c08bfd3b&tochange=f8fda1ba5cd3ee4d27e6e337803cdf53eaad9011
  Potential regressor: bug 1932489

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1932489, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1932489

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1945499 - Fix dragging multiple tabs in RTL. r=dwalker

Comment 4

[Phabricator Automation]

Comment on attachment 9466640 [details]
Bug 1945499 - Fix dragging multiple tabs in RTL. r=dwalker

Revision D238486 was moved to bug 1945788. Setting attachment 9466640 [details] to obsolete.

Comment 5

[Dão Gottwald [:dao]]

Bug 1933280 may have fixed this. Alexandru or Rares, could you please confirm?

Comment 7

[Rares Doghi, Desktop QA]

Attachment: underline.mp4

Hi @Dao, Yes this issue is Verified as fixed in our latest Nightly build as well as Bug 1933280 however testing this I did see an issue for when we take tabs outside of the group.. if we go all the way to the end there is no problem but the underline disappears a lot sooner and the tab jumps right back inside the group. Please take a look at my screen recording.

Comment 8

[Rares Doghi, Desktop QA]

This works great now, Verified as fixed in our latest Nightly build 137.0a1 (2025-02-24)