1948342 - Update context menus for the toolbar, toolbar tools, and sidebar button

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P1)

Description

[Ania]

Attachment: any tooolbar tool context menu - nightly.png

Background
The addition of the sidebar-specific actions to the toolbar context menu has "leaked" into the context menus of the individual toolbar buttons in Nightly.
We would like to revert this change, and keep the context menu of the individual toolbar buttons as they currently are in release (please see screenshots for user story 1 that compare nightly and release context menus for any toolbar tool attached), and also tidy up other context menus.
Figma

---

1. Any toolbar tools/button - user story

1. As a user of a specific toolbar tool, I only want to see tool-specific and toolbar-specific menu items when I right-click them.

Acceptance criteria

1. All toolbar buttons context menus, except the sidebar button, should not display the "Turn on vertical tabs" and "Customize sidebar" actions.

---

2. Sidebar button - user story

1. As a sidebar user, I want quick access to the most useful sidebar-specific actions when I click the sidebar button.

Acceptance criteria

1. As a horizontal tabs user, I can access the following actions from the sidebar toolbar button context menu:

• customize sidebar (String: Customize sidebar)
• turn vertical tabs on (String: Turn on Vertical Tabs)
  in addition to the standard toolbar button actions (Pin to overflow menu, Remove from Toolbar, Bookmarks Toolbar, Customize Toolbar).

2. As a vertical tabs user, I can access the following actions from the sidebar toolbar button context menu:

• customize sidebar (String: Customize sidebar)
• turn vertical tabs off (String: Turn off Vertical Tabs)
  in addition to the standard toolbar button actions.
  See the sidebar button - user story 3 screenshot.

---

3. Toolbar - user story
As a product manager, I want to add a discoverability entry point for vertical tabs to the general right-click menu on the toolbar so users can discover them in a menu that is not overloaded with list items and deals with general UI customizations.

Acceptance criteria

1. As a horizontal tabs user, I can turn vertical tabs on from the toolbar right-click menu
   String: Turn on Vertical Tabs
   See the toolbar button - user story 3 screenshot.

2. As a vertical tabs user, I can turn vertical tabs off from the toolbar right-click menu:
   String: Turn off Vertical Tabs

I've also attached the breakdown of all the context menu items for horizontal and vertical tabs for a full picture of changes across these three tickets.

Comment 1

[Ania]

Attachment: any tooolbar tool context menu - user story 1 - release.png

Comment 2

[Ania]

Attachment: all context menus horizontal tabs.png

Comment 3

[Ania]

Attachment: all context menus vertical tabs.png

Comment 4

[Ania]

Attachment: sidebar button context menu - user story 2 (vertical).png

Comment 5

[Ania]

Attachment: toolbar context menu - user story 3 (horizontal).png

Comment 7

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1948342 - Update toolbar and tabstrip context menus to include vertical tabs and sidebar r=#sidebar-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a4f0700184
Update toolbar and tabstrip context menus to include vertical tabs and sidebar r=sidebar-reviewers,jsudiaman

Comment 9

[Atila Butkovits]

Backed out for causing failures at browser_customization_context_menus.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3cbebe2c19286d69fa1ac8c99a8f0f0b0c007680

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b1a4f070018479cb5243a130c15ac72ee45871f2&selectedTaskRun=IbbAW_30TiSLOB_Y8VS_6w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=497081841&repo=autoland&lineNumber=5483

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb62ed35bd0
Update toolbar and tabstrip context menus to include vertical tabs and sidebar r=sidebar-reviewers,jsudiaman

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0bb62ed35bd0