195830 - OS X: unable to type / or ' in XUL or html textfields after invoking FAYT

Status: RESOLVED WORKSFORME

(SeaMonkey :: Find In Page, defect)

Description

[sairuh (rarely reading bugmail)]

unable to type / in URLbar after invoking FAYT. likely due to the checkin for
bug 187511.

found using 2003.03.03 on Mac OS X 10.2.4. so far i cannot repro this on linux
rh8.0 or win2k.

1. load a page, http://mozilla.org
2. from the main menu, select Edit - Find Links As You Type.
3. enter some text that'll be found on the page (this step might be optional).
4. bring focus to URLbar --i used cmd+L.
5. type in a URL (this will overwrite what's there, as expected) which contains
a forward slash, eg, "hopey.mcom.com/docs/" 9no quotes).

results: as soon as i hit the / key (after hopey.mcom.com above), the Edit menu
is focused, and no slash can be entered.

Comment 1

[sairuh (rarely reading bugmail)]

oh, and this also affects the quicksearch field in the mailnews 3pane.

Comment 2

[sairuh (rarely reading bugmail)]

this is very weird --i can also reproduce this in the following areas:

* html form fields, eg, the field in http://bugzilla.mozilla.org/

* textfield in prefs, eg, home page field in the Navigator panel. although,
oddly, / and ' are entered there, but the Edit menu label flashes each time i
hit those char.

Comment 3

[sairuh (rarely reading bugmail)]

perhaps this should be backed out?

Comment 4

[Aaron Leventhal]

Hmm, the problem before was that you couldn't type / or ' in textfields at all
on os x.

Are you saying that the problem now only occurs when find as you type has been
started at least once, or is active?

Comment 5

[sairuh (rarely reading bugmail)]

it seems that i all i need to do is dropdown the Edit menu. it doesn't matter
whether or not FAYT is "on" (tested with "find automatically" pref on and off).

basically, the test steps are similar to kathy's in bug 189093 comment 4.

Comment 6

[Aaron Leventhal]

As Simon helped me figure out, it turns out that bug 195979 is the cause of this.

So, as long as you click on the edit menu to update the menu items, the correct
thing will happen.

Until we fix bug 195830, we will either have to 
1) deal with this regression
2) back out bug 187511 
or 
3) check in a temporary workaround like changing the accelerators to Cmd+/ and
Cmd+' on Mac

Comment 7

[Aaron Leventhal]

Attachment: Temporary fix until mac menu bug 195979 is fixed. Remove the / and ' keybindings from the find as you type menu items on Mac only.

Comment 8

[Aaron Leventhal]

Comment on attachment 116833 [details] [diff] [review]
Temporary fix until mac menu bug 195979 is fixed. Remove the / and ' keybindings from the find as you type menu items on Mac only. 

Hope a temporary fix is alright with people until we get that mac menu updating
bug fixed.

Comment 9

[Kathleen :Brade]

Comment on attachment 116833 [details] [diff] [review]
Temporary fix until mac menu bug 195979 is fixed. Remove the / and ' keybindings from the find as you type menu items on Mac only. 

r=brade (note: I have not tested this on any platforms)

Comment 10

[sairuh (rarely reading bugmail)]

speaking of testing :), before this is checked in, could you pls do these quick
checks on OS X? ie, make sure this bug doesn't occur for the following cases:

a. the Edit menu test (comment 5).
b. manually start FAYT in a page, then focus a textfield or urlbar and hit ' and
/ to make sure you can enter them.

just sanity checks --thanks a lot!

Comment 11

[sairuh (rarely reading bugmail)]

this isn't limited to FAYT --mailnews also suffers from something similar, see
bug 194147.

Comment 12

[Aaron Leventhal]

Tested on mac, workaround patch fixes problem

Comment 13

[Simon Fraser [no longer active]]

Comment on attachment 116833 [details] [diff] [review]
Temporary fix until mac menu bug 195979 is fixed. Remove the / and ' keybindings from the find as you type menu items on Mac only. 

Thanks for testing

Comment 14

[Aaron Leventhal]

Checked in workaround. For now, find as you type menu items on mac os x won't
list the shortcuts.

Should we leave this bug open until bug 195979 gets fixed? When that gets
properly fixed we should back this fix out.

Comment 15

[sairuh (rarely reading bugmail)]

yeah, i'd keep this open until bug 195979 is resolved.

thanks for checking in the workaround.

Comment 16

[sairuh (rarely reading bugmail)]

tested with 2003.03.20.03 on mac 10.2.4. the menu items are now

Edit - Find Links As You Type
Edit - Find Text As You Type

both of these work fine, as do the manual commands (/ and '). no longer see the
issue where you cannot enter / or ' in textfields.

removing regression kw, since the root of the problem is bug 195979, which i
don't think is a regression anyhow...

Comment 17

[Samir Gehani]

adt: nsbeta1-

Comment 18

[Kathleen :Brade]

is this really still a bug?  Or should the summary instead say something like
"MacOSX lacks keyboard shortcuts for invoking FAYT"?

Comment 19

[Aaron Leventhal]

(In reply to comment #18)
> is this really still a bug?  Or should the summary instead say something like
> "MacOSX lacks keyboard shortcuts for invoking FAYT"?

Someone can file that if they really care. You can use the keyboard shortcuts '
and / on Mac, they just aren't listed in the menu. Big deal.