249468 - Add all bookmark keywords to location bar autocomplete drop-down list

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Petey]

I propose that all bookmark keywords, whether they have yet been used in the
location bar or not, be included in the location bar's autocomplete list.  They
could also have a bookmark icon next to them to indicate they are a bookmark and
not a URL.

The purpose of keywords is to make finding your favorite sites fast and easy. 
As such, my keywords are usually just the first letter of the bookmarks name
(such as "b" for "bugzilla") so that it is, in effect, a hotkey.  However,
complications arise when I have two bookmarks with the same first letter
("bugzilla" and "Blogger" for example) and I risk losing efficiency or
forgetting the keywords because they don't follow the first-letter system.

If bookmark keywords where included in the autocomplete box, I could ditch my
one-letter rhetoric all together and loose negligible efficiency.  I could still
enter "b" and then simply select, with a single keystroke, either "bugzilla" or
"blogger".  Now, wouldn't that be great!?

Comment 1

[Richard Klein]

Adding self to CC and requesting blocking-aviary1.0

It looks like we need a component called something like
@mozilla.org/autocomplete/search;1?name=bookmark-keyword that implements the
nsiautocomplete* interfaces.  We could then add bookmark-keyword to the
autocompletesearch attribute to the url textbox in browser.xul.

Comment 2

[chris hofmann]

good idea but it is late in the 1.0 development cycle for adding new features,
especially feature without well tested patches.

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 282390 has been marked as a duplicate of this bug. ***

Comment 4

[Richard Klein]

since we didn't get 1.0 how about 1.1?

Comment 5

[Mike Connor [:mconnor]]

Not something we're going to block for, if a patch comes in soonish we may take it.

Comment 6

[ibormuth]

It would be nice to not just have the bookmark keywords in autocompletion but
also every single query that was used with smart keywords.
So we do not just have "g" in autocompletion but also "g foo" and "g bar" etc...

Comment 7

[Adam Guthrie]

*** Bug 298339 has been marked as a duplicate of this bug. ***

Comment 8

[Ed Lee :Mardak]

*** Bug 278747 has been marked as a duplicate of this bug. ***

Comment 9

[Ed Lee :Mardak]

Suite bug 101642. 

Won't be able to do "g foo" or "g bar" while there's bug 196297.

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 11

[Ed Lee :Mardak]

Bug 392143 would fix this by showing all keywords as part of the autocomplete list letting the user select which one to use.

Comment 12

[Ed Lee :Mardak]

Attachment: testcase v1

Tests the functionality added by bug 392143 to make sure multiple keywords show up in the autocomplete.

Comment 13

[Ed Lee :Mardak]

Attachment: testcase v1.1

Unbitrot from bug 392143.

Comment 14

[Ed Lee :Mardak]

Attachment: testcase v1.2

Unbitrot testcase now that it's using the super cool places autocomplete test framework.

Comment 15

[Ed Lee :Mardak]

Fixed by bug 392143: http://hg.mozilla.org/mozilla-central/index.cgi/rev/a15164388bf1

http://hg.mozilla.org/mozilla-central/index.cgi/rev/307503c8b6fb