1967664 - Junk commands are disabled for virtual folders with more than one searched folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

I was tried to write a test to run some untested code in the junk commands, but I've figured out that for virtual folders the junk commands (run junk mail controls, delete mail marked as junk) are enabled only if the virtual folder searches a single folder. The code itself is in bad condition, so it was probably easier just to disable it, but that's not great. We use virtual folders for unified folders, and the commands should work there.

Comment 1

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1967664 - Fix and test deleting messages marked as junk in a virtual folder. r=#thunderbird-reviewers

This code is in terrible condition. I spent more time fixing it than testing it.

Comment 2

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: Bug 1967664 - Enable and test running junk controls in a virtual folder. r=#thunderbird-reviewers

Comment 3

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

I'm a little hesitant to land this change during the freeze for ESR, but it's low risk and I don't think we'd get significantly more testing by landing it at any other time.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4da709136583
Fix and test deleting messages marked as junk in a virtual folder. r=aleca
https://hg.mozilla.org/comm-central/rev/9ab238cf6ad5
Enable and test running junk controls in a virtual folder. r=aleca

Comment 5

[Wayne Mery (:wsmwk)]

Thanks for fixing another dang Unified folder issue!

Tristan, are there any duplicates/related in https://mzl.la/4kSLas5 ?

Comment 6

[Tristan Miller]

(In reply to Wayne Mery (:wsmwk) from comment #5)

Tristan, are there any duplicates/related in https://mzl.la/4kSLas5 ?

Sorry, I'm overcommitted at the moment and so don't have time to look for duplicates.