1968963 - After upgrade to 139 the Message list Table View changed to Cards View

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Sam]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 Edg/136.0.0.0

Steps to reproduce:

I upgraded to 139.0.

Actual results:

My mailboxes looked entirely different. I prefer the Classic view. It is still listed under Layout, but it appears that the classic view is no longer active. My inbox changed so that each message took up two lines plus a blank line between each message. I can see only three messages at a time! I went back to 138.0.2 and had to restore my profile from a backup.

Expected results:

The mailbox should not have been totally changed!

Comment 1

[Sam]

Having gone back to 138.0.2, I cannot reproduce the 139 view by changing the layout option and the density, so my conclusion that Classic view disappeared may be wrong.

Comment 2

[Wayne Mery (:wsmwk)]

Correct, Classic Layout definitely did not disappear, but perhaps it only happens on first startup of 139.

Comment 3

[Sam]

I will upgrade to 139 again as a test, if necessary, but I would rather not and then have to retrograde back to 138.0.2 again.

Comment 4

[Wayne Mery (:wsmwk)]

It will help if you are more precise with the language in your description. Or, provide a screen shot.

There are Layouts (Classic, Vertical, etc) that do not change the number of lines) and there are Views (Card and Table) which can change the number of lines. For details please see https://support.mozilla.org/en-US/kb/getting-started-thunderbird-main-window-supernova#w_classic-view-layout-with-table-view

Comment 5

[Sam]

Attachment: Screenshot with 139.0.jpg

Comment 6

[Sam]

Attachment: Screenshot with 138.0.2.jpg

Comment 7

[Magnus Melin [:mkmelin] (away until Aug 10)]

Seems you now get Cards View instead of Table View. (You can change which one you want on top with the gadget next to Quick Filter.)

Comment 8

[Sam]

Yes, you are quite correct that 139 was in Cards view that I have never used before. Perhaps the problem is that 139 changed the option to Cards view. Changing the option back to Table view fixed the problem. Many thanks for your help.

Comment 9

[Wayne Mery (:wsmwk)]

Thanks for the update

Comment 10

[Alessandro Castellani [:aleca]]

I just tested an upgrade from 138 to 139 with Table View and confirmed that it switches to cards view.
It seems that the migration implemented in bug 1865057 is not working correctly, not sure why, maybe the XUL store is not always available at that stage, or something is flaky with our defaults.
I'll try to fix this, apologies for annoyance and the issue.

Comment 11

[Sam]

Version 139 also changed the Sort By option to Threaded.

Comment 12

[Alessandro Castellani [:aleca]]

(In reply to Sam from comment #11)

Version 139 also changed the Sort By option to Threaded.

This is strange, we haven't touched the mailnews.default_view_flags preference and that shouldn't have been changed.

Comment 13

[Alessandro Castellani [:aleca]]

Urgh, this is tricky as I can't seem to reproduce it on trunk when trying to find where things went wrong.
This is what I did:

• Added a XUL Store value for table view.
• Updated the migration to 48.
• Added a bunch of console.log() to print the data.
• Updated the mail.threadpane.listview pref to another random number.

The XUL Store value is correctly available during the migrations.
The migration properly sets the pref to the correct table view.
The UI is respected on relaunch.

Any help or suggestions?

Comment 14

[Martin Giger [:freaktechnik]]

Hm, the migration shouldn't have to emit mail.threadpane.listview since it runs before the first window is opened afaik. So when the 3pane loads it should get consistent state. (Edit: wait, that's a pref observer so yeah...)

I also don't think anything would trigger safe mode for an upgrade, since that would also make the xulstore use the default values.

You manually set the xulstore value? While I think we're trying to read the correct thing, is that maybe not the case for existing profiles? Maybe the value looks slightly different or something? (I can't imagine how it could while still showing the table view, but who knows) - Especially since the baseline from the migration to ui version 40 essentially sets exactly the expected value?

Comment 15

[Alessandro Castellani [:aleca]]

(In reply to Martin Giger [:freaktechnik] from comment #14)

Hm, the migration shouldn't have to emit mail.threadpane.listview since it runs before the first window is opened afaik. So when the 3pane loads it should get consistent state. (Edit: wait, that's a pref observer so yeah...)

Indeed, I tested it and confirmed that changing that pref during migration doesn't emit anything and it won't trigger the listeners.

You manually set the xulstore value?

I added back the code that was settings the xul store value in the about3Pane.

While I think we're trying to read the correct thing, is that maybe not the case for existing profiles? Maybe the value looks slightly different or something? (I can't imagine how it could while still showing the table view, but who knows) - Especially since the baseline from the migration to ui version 40 essentially sets exactly the expected value?

Yeah, that's what baffles me because even if the xulstore value in existing profiles is wrong or missing, the UI should have been cards view already since that has been the default for a while.

Comment 16

[Wayne Mery (:wsmwk)]

https://www.reddit.com/r/Thunderbird/comments/1kwh2il/message_preview_in_the_cards_view/ might not be a match.

Comment 17

[Alessandro Castellani [:aleca]]

(In reply to Wayne Mery (:wsmwk) from comment #16)

https://www.reddit.com/r/Thunderbird/comments/1kwh2il/message_preview_in_the_cards_view/ might not be a match.

Indeed, this is unrelated.
We don't currently have a message preview feature in cards view.

Comment 18

[Wayne Mery (:wsmwk)]

TCW hit this when updating from 138.0.2.

Comment 19

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

I was also able to reproduce this issue when going from 138.0.2(20250519142253) to 139.0(20250522211142) using Windows 11, macOS 15 and Ubuntu 25.

Upon launching the 138, I set the following things:

• From Cards to Table view
• Layout to Classic
• Sort by to Unthreaded

After update to 139, I see the following results:

• Switched back to Table from Cards
• Layout is still set to classic
• Sort by remains set to Unthreaded.

Comment 20

[Liam Proven]

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Comment 21

[Arthur K. (he/him)]

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Where are you seeing this option to switch between Table and Cards view on Quick Filter? I don't see that button.

Comment 22

[Arthur K. (he/him)]

Just a run-down of my enabled options under the View menu in case it helps to repro:

Toolbars: Menu Bar, Status Bar
Layout: Classic, Folders, Message Pane
Folder: Folder Pane Header, All Folders
Density: Default
Today Pane: Show Today Pane, Show Mini Month
Sort By: Date, Descending, Unthreaded
Threads: All
Headers: All
Message Body: As HTML

Comment 23

[Wayne Mery (:wsmwk)]

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Please use https://connect.mozilla.org/t5/ideas/idb-p/ideas/label-name/thunderbird for suggesting changes. Discussion of changes is off-topic to this bug report.

Comment 24

[Anje]

(In reply to Arthur K. (he/him) from comment #21)

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Where are you seeing this option to switch between Table and Cards view on Quick Filter? I don't see that button.

On the 'Message List Header' there is a 'Quick Filter' button and the icon shown immediately to the right (tooltip - 'Message List display options' ) has the drop down menu to switch between 'Table' and Cards' view.

Comment 25

[Arthur K. (he/him)]

(In reply to Anje from comment #24)

(In reply to Arthur K. (he/him) from comment #21)

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Where are you seeing this option to switch between Table and Cards view on Quick Filter? I don't see that button.

On the 'Message List Header' there is a 'Quick Filter' button and the icon shown immediately to the right (tooltip - 'Message List display options' ) has the drop down menu to switch between 'Table' and Cards' view.

Hmm, I must be blind. Can you post a pic of where you see that or exactly under which menu it is? Is it under the Message menu?

Comment 26

[Wayne Mery (:wsmwk)]

(In reply to Anje from comment #24)

...
On the 'Message List Header' there is a 'Quick Filter' button and the icon shown immediately to the right (tooltip - 'Message List display options' ) has the drop down menu to switch between 'Table' and Cards' view.

Message List Header is above column headers. The options icon is clearly shown inthe screen shot at https://support.mozilla.org/en-US/kb/getting-started-thunderbird-main-window-supernova

Comment 27

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #26)

(In reply to Anje from comment #24)

...
On the 'Message List Header' there is a 'Quick Filter' button and the icon shown immediately to the right (tooltip - 'Message List display options' ) has the drop down menu to switch between 'Table' and Cards' view.

Message List Header is above column headers. The options icon is clearly shown inthe screen shot at https://support.mozilla.org/en-US/kb/getting-started-thunderbird-main-window-supernova

It took me a minute but since I did not have View > Layout > Message List Header enabled, I did not see what was shown on that image. Now I see the Message List Display Options icon.

Comment 28

[Arthur K. (he/him)]

That did the trick. For those users who don't have the "Message List Display Options" icon present (to flip back to Table View) or who, like me, have turned off View > Layout > Message List Header, it's a fairly easy fix.

Comment 29

[Alessandro Castellani [:aleca]]

Created issue for upcoming KB article to highlight the issue and guide the users affected by it: https://github.com/thunderbird/knowledgebase-issues/issues/78

Comment 30

[Liam Proven]

(In reply to Arthur K. (he/him) from comment #21)

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Where are you seeing this option to switch between Table and Cards view on Quick Filter? I don't see that button.

It is not on the Quick Filter button. It is next to it, immediately to its right.

You can also switch between Table and Cards view using the very top option under Appearance in Settings. It is the first option.

Comment 31

[Liam Proven]

(In reply to Wayne Mery (:wsmwk) from comment #23)

(In reply to Liam Proven from comment #20)

Suggestions:

• As well as the button next to Quick Filter and the option in the Settings screen, I think Cards versus Table view should be in the View menu.
• Either as a top-level option, or failing that, under Layout.

Please use https://connect.mozilla.org/t5/ideas/idb-p/ideas/label-name/thunderbird for suggesting changes. Discussion of changes is off-topic to this bug report.

Fair enough. I have done that. I had already done it before I saw your reply, in fact.

Comment 32

[Alessandro Castellani [:aleca]]

Attachment: Bug 1968963 - Temporary failsafe for unpredictable XULStore migration of list view option in the release channel. r=#thunderbird-front-end-reviewers

How to test

• Set your list layout to Cards
• Open the dev tools and type Services.xulStore.setValue("chrome://messenger/content/messenger.xhtml", "threadPane", "view", "table"); to register the old xulstore value of table view.
• Restart Thunderbird.

The message list should me in cards view as the code will first respect the old XULStore value if it doesn't match the registered preference.

Comment 33

[Geoff Lankow (:darktrojan)]

Okay, found the problem. 138.0.1 shipped with migration number 50, but not 48 or 49, so when they were added in a later release, the code thought we were already up to 50 and they didn't run.

I think this could be fixed just by renumbering migrations 48 and 49. They look like running a second time wouldn't be harmful, for users on channels where they already ran in the original order.

Comment 34

[Alessandro Castellani [:aleca]]

Attachment: Bug 1968963 - Re-run migration 48 and 49 accidentally skipped during release uplift. r=#thunderbird-reviewers

Comment 35

[Corey Bryant]

Comment on attachment 9491773 [details]
Bug 1968963 - Re-run migration 48 and 49 accidentally skipped during release uplift. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: This is needed because table view users are regressed
• User impact if declined: Table view uers are regressed
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: No
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: Repeat the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1968963#c19 for:

1. 138.0.2 -> 139.0 -> 139.0.1
2. 138.0.2 -> 139.0.1

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The solution is just re-running the missing migrations. Risk will be alleviated also by QA testing.
• String changes made/needed: None

Comment 36

[Corey Bryant]

Vlad/Ramona, can you test this one it is available in 139.0.1?

Comment 37

[Corey Bryant]

Comment on attachment 9491773 [details]
Bug 1968963 - Re-run migration 48 and 49 accidentally skipped during release uplift. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for release

Comment 38

[Corey Bryant]

Thunderbird 140.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/5474def2d377

Comment 39

[Corey Bryant]

Thunderbird 139.0.1:
https://hg.mozilla.org/releases/comm-release/rev/5ac6889075f7

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b72c4e21b59a
Re-run migration 48 and 49 accidentally skipped during release uplift. r=vineet

Comment 41

[Ramona Gavrilescu]

Confirm this as verified fixed on TB 139.0.1 (20250531130320) and also 140.0b1 (20250530162102) available on treeherder