1983555 - Faulty migration from table view to cards view if the profile had never seen cards view

Status: RESOLVED INVALID

(Thunderbird :: Folder and Message Lists, defect)

Description

[Francesco (no longer active, use PM for contact)]

Create a profile in TB 115. Upgrade to TB 140 (or to TB 128 and then TB 140).

This profile will never have set cards view, but it gets upgraded to cards view.

The migration code doesn't get executed since there in no entry in the XUL store:
https://searchfox.org/comm-central/rev/6308d1c5c2ac49dee57d0eef11128aea0d8529fc/mail/modules/MailMigrator.sys.mjs#273,298

Comment 1

[Martin Giger [:freaktechnik]]

If the profile never had cards view, it should get the xul store value set in an earlier migration from https://phabricator.services.mozilla.com/D186386 - that changed the code to default to cards view for new profiles.

Comment 2

[Alessandro Castellani [:aleca]]

I think the STR is invalid since 115 is unsupported and we can't guarantee proper functionality if a new profile is created in that version. At last 128 should be the starting point.
Throughout 115 > 140 lifespan the default value for the message list was switched to cards view, and all existing users were migrated to maintain the table view for their profiles, but we show cards view for newly created profiles.

If no existing XUL value was ever present, we assume this is a clean new profile that never went through any previous migration and we show cards view since that's the new default.

We haven't gotten any similar report to this if I'm not wrong.
I would potentially mark it as WONTFIX.

Comment 3

[Francesco (no longer active, use PM for contact)]

Sorry, there might have been something wrong with the initial profile.