1971648 - Add contain: strict to pane elements to reduce layout complexity, and avoid performance impact from animation in status bar

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[Geoff Lankow (:darktrojan)]

The layout inside each of the three panes should not affect anything outside the panes. I'm going to add contain: strict to the panes and the rows of the trees inside them to simplify the layout calculation and hopefully improve performance.

Thanks to mstange in bug 854093 comment 28 for the idea.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1971648 - Add contain: strict to pane elements to reduce layout complexity. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1050abe565a8
Add contain: strict to pane elements to reduce layout complexity. r=aleca

Comment 4

[Wayne Mery (:wsmwk)]

there's a chance it helps with that weird problem some people see where the progress bar animation causes relayout to happen on every frame.

This is great, given that there are many situations where animation doesn't stop.

IIRC, Corey discussed taking this in a point release of esr. Also, it might help to take this without any other performance fixes.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9494210 [details]
Bug 1971648 - Add contain: strict to pane elements to reduce layout complexity. r=#thunderbird-front-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Small fix that could improve performance.
• User impact if declined:
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple change to some CSS.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 9

[Corey Bryant]

Comment on attachment 9494210 [details]
Bug 1971648 - Add contain: strict to pane elements to reduce layout complexity. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr140

Comment 10

[Stephen King (:sking)]

Thunderbird 140.3.1:
https://hg.mozilla.org/releases/comm-esr140/rev/b7c3177e0caaf1cd97f6137f5e2f2cebaa794ff6