1974983 - Screenshots not being saved to user-specified location

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Cletus Van Damme]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

Take a screenshot of a web page using Firefox's screenshot feature.

Actual results:

After upgrade from 140 to 141, the screenshot save directory changed to a different location (in my case, the Windows 10 default Downloads folder C:\Users\Username\Downloads).

Expected results:

Screenshots should be saving to the location previously set under Downloads in the Settings panel (e.g. in my case D:\Downloads).

I noted while troubleshooting that there are new settings introduced in 141 (browser.screenshots.folderList and browser.screenshots.dir) which specify the save location for screenshots specifically. These new options seem useful but the way it's introduced presented the following user experience issues:

a) The unexpected change to save location. I think it would be more expected that the user's existing preference would be transparently migrated.

b) Was unable to find new Settings panel UI items for specifying screenshot save location, which added to the confusion.

Comment 1

[Connor Pearson]

Attachment: Bug 1974983 Screenshot location should fallback to browser.download.folderList by default. r=niklas

Comment 2

[Connor Pearson]

I can take a look at this one. Regarding the unexpected change, this was not intentional. The behavior should've remained the same as in previous versions unless you explicitly changed the config.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4ec645cd199b
https://hg.mozilla.org/integration/autoland/rev/5b86ae2c81f9
Screenshot location should fallback to browser.download.folderList by default. r=niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1dd232a860f4
https://hg.mozilla.org/integration/autoland/rev/1700c287983d
Revert "Bug 1974983 Screenshot location should fallback to browser.download.folderList by default. r=niklas" for causing bc failures on browser_screenshots_test_downloads.js.

Comment 5

[Iulian Moraru]

Revert for causing bc failures on browser_screenshots_test_downloads.js.

• Push with failures

• Failure log

• Backout link

[task 2025-07-11T06:15:32.300+00:00] 06:15:32     INFO - TEST-PASS | browser/components/screenshots/tests/browser/browser_screenshots_test_downloads.js | The current state is selected, expected selected - 
[task 2025-07-11T06:15:32.300+00:00] 06:15:32     INFO - clicking download button at 431.1999969482422, 534.5999984741211
[task 2025-07-11T06:15:32.301+00:00] 06:15:32     INFO - Download changed!
[task 2025-07-11T06:15:32.301+00:00] 06:15:32     INFO - Download changed!
[task 2025-07-11T06:15:32.302+00:00] 06:15:32     INFO - Download changed!
[task 2025-07-11T06:15:32.302+00:00] 06:15:32     INFO - Download changed!
[task 2025-07-11T06:15:32.303+00:00] 06:15:32     INFO - Download changed!
[task 2025-07-11T06:15:32.303+00:00] 06:15:32     INFO - Download succeeded or errored
[task 2025-07-11T06:15:32.303+00:00] 06:15:32     INFO - Buffered messages finished
[task 2025-07-11T06:15:32.304+00:00] 06:15:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_test_downloads.js | Test timed out - 
[task 2025-07-11T06:15:32.304+00:00] 06:15:32     INFO - GECKO(3219) | Completed ShutdownLeaks collections in process 3219
[task 2025-07-11T06:15:32.305+00:00] 06:15:32     INFO - TEST-START | Shutdown
[task 2025-07-11T06:15:32.305+00:00] 06:15:32     INFO - Browser Chrome Test Summary
[task 2025-07-11T06:15:32.305+00:00] 06:15:32     INFO - Passed:  1067
[task 2025-07-11T06:15:32.306+00:00] 06:15:32     INFO - Failed:  1
[task 2025-07-11T06:15:32.306+00:00] 06:15:32     INFO - Todo:    0
[task 2025-07-11T06:15:32.307+00:00] 06:15:32     INFO - Mode:    e10s
[task 2025-07-11T06:15:32.307+00:00] 06:15:32     INFO - *** End BrowserChrome Test Results ***
[task 2025-07-11T06:15:32.308+00:00] 06:15:32     INFO - GECKO(3219) | 1752214532051	Marionette	TRACE	Received observer notification quit-application
[task 2025-07-11T06:15:32.308+00:00] 06:15:32     INFO - GECKO(3219) | 1752214532052	Marionette	INFO	Stopped listening on port 2828

Comment 6

[Cletus Van Damme]

Just noting I've now encountered this behaviour with the release channel upgrade from 140 to 141 (in my case, D:\Downloads being changed to C:\Users\Username\Downloads). As before, the new browser.screenshots.folderList and browser.screenshots.dir settings did work for changing it back.

Comment 9

[Cletus Van Damme]

If I can offer some input from a user perspective on seeing complaints popping up in the wild about the unexpected folder change, right now there will be some affected users relieved at managing to find the solution, and others left frustrated and unable to figure out what to do. I guess there might be a judgement call over whether to revert settings if that could have further undesirable impacts, but I would like to suggest prioritising the implementation of Settings panel UI items as previously suggested by sfoster in bug 1838053. This would at least make the solution more discoverable, and having it just below the Downloads folder setting would seem to make the most sense given that's the well established part of the UI for setting screenshot save location.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89f615bd623a
https://hg.mozilla.org/integration/autoland/rev/70d78b563623
Screenshot location should fallback to browser.download.folderList by default. r=niklas

Comment 11

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/70d78b563623

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-07-01 Firefox Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 144.0a1 and Firefox 143.0b2 on Windows 10, Ubuntu 22, macOS 15.

Comment 15

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1838053