1993788 - Restart with add-ons disabled is broken in SeaMonkey 2.53.22b1

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

The code still uses smile and the changes to suite/smile/src/smileApplication.js in bug 1614671 broke the restart. The ChromeUtils api has some different behaviour here and we need to put XPCOMUtils in again for now. We should still pick parts of Bug 1388561 for 2.53 too to remove the general smile usage from our code. This is only kept for old extensions.

Timestamp: 11.10.2025, 13:30:08
Error: TypeError: Application.restart is not a function
Source File: chrome://communicator/content/utilityOverlay.js
Line: 686

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1993788-25322.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1614671
User impact if declined: restart does not work.
Testing completed (on m-c, etc.): 2.53.23b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Do we need some spin off bugs to remove the dependency of "restart with add-ons disable" on smile?
and/or fixing ChromeUtils behaviour?

Comment 3

[Ian Neal]

Comment on attachment 9519578 [details] [diff] [review]
1993788-25322.patch

[Triage Comment]
As a workaround LGTM r/a=me

Comment 4

[Frank-Rainer Grahl (:frg)]

Bug 1388561 removed all Smile usage in SeaMonkey and is now in to 2.53 also. What is left is add-on usage but the Smile code should probably removed and any classic add-ons still maintained fixed. I doubt there are any usable left anyway. Places code in Smile eg. probably needs a full replacement and imho not worth it. I would add bug 1435621 and maybe bug 1354205 to 2.53 and get over it the hard way.
I don't think we will remove XPCOMUtils from 2.53 so can use this one as a workaround. So far I have not seen other broken stuff but the add-ons sdk might be affected too.

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/969f8f6c9af2a3c9fe4f53c890db6351f710a231
Revert use of ChromeUtils.GenerateQI for smile. r=IanN a=IanN