201697 - "Remove from List" does nothing - cannot delete items from download manager.

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect, P3)

Description

[phil]

User-Agent:       Mozilla/4.7 (X11; Linux)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030327 Debian/1.3-4

On seemingly random occasions, entries in the download manager cannot be removed
once they have finished downloading.  I cannot consistently reproduce the
problem, but it seems to only occur with non-image files saved to disk (e.g., a
.pdf file).

IMHO, this is "major" because now the DM has an ever-accumulating list of
documents that I can't clear for easy management.  (At the moment, it serves as
a handy reference to every field manual I've downloaded in the last week, but I
really didn't want that, thanks...)


Reproducible: Sometimes

Steps to Reproduce:
1. Download some things, preferably a non-image file.  Save them to disk rather
   than open them in an application.
2. Click the DM.  Use Ctrl-A to select all of them.
3. Click "Remove from List".

Actual Results:  
Sometimes, nothing at all.


Expected Results:  
Removed all of them.  (Which works sometimes.)

Comment 1

[andreas]

Can be reproduced with Mozilla 1.4a/MacOSX.

Comment 2

[Frederic Bezies]

WFM - current CVS based trunk build - linux

Reporter : can you try with a younger build, even a nightly one (for 1.4b) ?

Thanks.

Comment 3

[Vedran Miletic]

Happens on Windows2003 as well with recent builds.

OS -> all perhaps?

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

-> jag.

Error: ds.beginUpdateBatch is not a function
Source File: chrome://communicator/content/downloadmanager/downloadmanager.js
Line: 269

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

really over to jag.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Sorry Jag, I jumped the gun. 

Jan this is your regression (or at least someone needs to change the Download
Manager callers, or something).

1.25 <[e-mail]> 23 May 2003 05:03
Landing bookmarks changes.
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa

The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.

In that revision of downloadManager.js, you did:

-      var observer =
gDownloadView.builder.QueryInterface(Components.interfaces.nsIRDFObserver);
-      var ds = gDownloadView.database;
-      observer.beginUpdateBatch(ds);
-      
+      var ds = window.arguments[0];
+      ds.beginUpdateBatch();
       for (i = 0; i <= selectedItems.length - 1; ++i) {
         gDownloadManager.removeDownload(selectedItems[i].id);
       }
+      ds.endUpdateBatch();
 
       gDownloadManager.endBatchUpdate();
-      observer.endUpdateBatch(ds);
-      var remote =
window.arguments[0].QueryInterface(Components.interfaces.nsIRDFRemoteDataSource);
-      remote.Flush();
-      gDownloadView.builder.rebuild();

Comment 7

[Dimitrios]

*** Bug 207101 has been marked as a duplicate of this bug. ***

Comment 8

[Jason Bassford]

Tweaking bug summary for better b.m.o. queries.

Comment 9

[Mitchell Keith Bloch]

I have encountered this as well in 1.3.1 and 1.4b but it has never been a real
problem for me, as it allows me to delete the entries eventually.

Comment 10

[Nick Bebout]

This is currently happening to me.

I am running a CVS build (not nightly) from yesterday (5-26-03).

It will not allow me to remove any entries from the list.

Nominating for blocking1.4

Comment 11

[Jan Varga [:janv]]

silly regression

Comment 12

[Jan Varga [:janv]]

Attachment: patch

Comment 13

[Samir Gehani]

adt: nsbeta1+/adt1

Comment 14

[Jan Varga [:janv]]

*** Bug 207380 has been marked as a duplicate of this bug. ***

Comment 15

[Jan Varga [:janv]]

*** Bug 200663 has been marked as a duplicate of this bug. ***

Comment 16

[Josh Birnbaum]

*** Bug 207405 has been marked as a duplicate of this bug. ***

Comment 17

[jag (Peter Annema)]

Comment on attachment 124297 [details] [diff] [review]
patch

sr=jag

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 124297 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 19

[Jan Varga [:janv]]

fixed on the trunk and 1.4 branch

Comment 20

[Patrick]

*** Bug 208112 has been marked as a duplicate of this bug. ***

Comment 21

[Chris Petersen]

Verified on 2003-06-03-05 Macho and Win32 branch builds.

Comment 22

[Chris Petersen]

Verified on Macho and Win32 trunk (2003-06-03-08) builds

Comment 23

[Alfonso Martinez]

*** Bug 209444 has been marked as a duplicate of this bug. ***

Comment 24

[phil]

Just speaking as the reporter -- thanks, works for me under 1.4!