2019983 - Introduce a new policy that maps directly to the AI controls

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

In order to make things more clear, I'm going to introduce a new policy that maps directly to the AI Controls.

It will take precedence over any existing policy (translation, GenerativeAI).

It will also control the switch (The GenerativeAI policy doesn't do that)

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 2019983 - Add a new enterprise policy for AI Controls. r?mstriemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed16025b05c6
https://hg.mozilla.org/integration/autoland/rev/bdf5e2e4bf7e
Add a new enterprise policy for AI Controls. r=fluent-reviewers,flod,nordzilla,translations-reviewers,ai-frontend-reviewers,Gijs,geckoview-reviewers,ohall,Mardak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/27f29f0df451
https://hg.mozilla.org/integration/autoland/rev/7ebe65920e5e
Revert "Bug 2019983 - Add a new enterprise policy for AI Controls. r=fluent-reviewers,flod,nordzilla,translations-reviewers,ai-frontend-reviewers,Gijs,geckoview-reviewers,ohall,Mardak" for causing multiple BC and XPC failures

Comment 4

[pstanciu]

Backed out for causing multiple BC and XPC failures

• https://hg.mozilla.org/integration/autoland/rev/7ebe65920e5e2bb946283c54b09a3ab72070f3b2
• Push with failures
• Failure Log - bc - browser_quickactions_translate.js
• Failure Log - bc - browser_aiFeatures.js
• Failure Log - bc - browser_pdfjs_aifeature_settings.js
• Failure Log - xpc
• Failure Log - mochitest

Comment 5

[Mike Kaply [:mkaply]]

Sorry, couldn't get try to work. I've tested everything now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aed139d26acb
https://hg.mozilla.org/integration/autoland/rev/b8207d7c3b0b
Add a new enterprise policy for AI Controls. r=fluent-reviewers,flod,nordzilla,translations-reviewers,ai-frontend-reviewers,Gijs,geckoview-reviewers,ohall,Mardak

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b8207d7c3b0b

Comment 8

[:Gijs (he/him)]

Did you intend for this to make 150 and/or how would you feel about uplifting this? I'm aware there's a single string for the policy description...

Comment 9

[Mike Kaply [:mkaply]]

Yes. String is not a huge deal. We allow policies to be English only. (Plus we're going to have to do it in a dot release for the new IPProtection policy)

Comment 10

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]:

I'm getting pushback from enterprise folks that this didn't make 149. Since we're going to need the IPProtection policy as well, we should take this.,
I need to rebase though.

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Enterprises really need this and it missed 149 unfortunately.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: medium
• Explanation of risk level: Changes some internal naming of some functions in AI controls, but has been thoroughly tested
• String changes made/needed?: Yes, but policy only.
• Is Android affected?: no

Comment 12

[Mike Kaply [:mkaply]]

Attachment: Bug 2019983 - Add a new enterprise policy for AI Controls.

Original Revision: https://phabricator.services.mozilla.com/D286342

Comment 13

[Mike Kaply [:mkaply]]

Attachment: Bug 2019983 - Add a new enterprise policy for AI Controls.

Original Revision: https://phabricator.services.mozilla.com/D286342

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Enterprises really need this and it missed 149 unfortunately.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: medium
• Explanation of risk level: Changes some internal naming of some functions in AI controls, but has been thoroughly tested
• String changes made/needed?: Yes, but policy only.
• Is Android affected?: no

Comment 15

[Dianna Smith [:diannaS]]

I see the string changes are policy only, but wanted to get a thumbs up from l10n team.

Comment 16

[Bryan Olsson [:bolsson]]

Hi, considering the importance and the fact that these are policy only I'm okay with this uplift.

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e9ccd3d80421
https://hg.mozilla.org/releases/mozilla-beta/rev/48f15ed4d1c6

Comment 18

[Francesco Lodolo [:flod]]

Note: we need someone to uplift l10n-changesets.json as close as possible to the next dot release.

P.S. it would be nice to get bug 2022452 to a resolution, which would mitigate this need.

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5e8f2ed5a959
https://hg.mozilla.org/releases/mozilla-release/rev/3c2e6641f4f3