2064729 - Some profile icons are missing after the 154 update and in Nightly

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Ania]

Attachment: Screenshot 2026-08-19 at 10.30.07 AM.png

STRs:

1. Run current Nightly or Firefox 154 stable channel
2. Open Account menu or Application menu > Profiles
3. Some profile icons are missing.

The issue does not impact all profiles, and may not be reproducible on a particular account, however, we're beginning to see similar reports on Reddit.

My suspicion is that profile age may matter, as for me, the icon is missing on a very old profile only, while the icons for more recently created profiles are intact.

Comment 1

[Dave Townsend [:mossop]]

What icon do you expect to see there, is it a custom avatar or one of the predefined ones?

Do you see the icon on the dock?

Comment 2

[Ania]

I do see the icon in the dock, and it's one of the predefined ones.
It looks like Ross is experiencing the same issue.

Comment 3

[Dave Townsend [:mossop]]

Are any errors appearing in the browser console?

Comment 4

[Sarah Clements [:sclements] | PTO until Sept 8th]

Bogdan or Simona, can either of you help us establish STR and whether this is regressed by bug 2046787 or related work from our team?

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

I suspect the issue is here: https://searchfox.org/firefox-main/source/browser/base/content/browser-profiles.js#208

With the Nova designs, we are now requesting an icon size that may not be listed here: https://searchfox.org/firefox-main/source/browser/components/profiles/SelectableProfile.sys.mjs#50

Some icons do actually come in size 24 and some do not, which is why this isn't a bug for every profile. We have two options - use the size 20 icons instead, or for every possible icon, old or new, ensure there is a size 24 asset as well.

Ania, what do you think?

Edit to add:
scratch that, I can use the 20px asset and enforce the size to be 24px in CSS instead. Will share a build so you can check your avatar is visible. Thanks!

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 2064729 - Replace using size 24 icons with size 16 for profiles

Comment 7

[Nikki Sharpley (:nikkis) (she/her)]

Talked to Ania, this fixes it, but noting here that we are going to take this opportunity to reduce the size further to align profile icons in the menu with those lower down in the menu. See also Bug 2059548

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/964738a9ee7f
https://hg.mozilla.org/integration/autoland/rev/a590c6814c7f
Replace using size 24 icons with size 16 for profiles r=desktop-theme-reviewers,kcochrane

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a590c6814c7f

Comment 11

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: There have been reddit complaints about missing profile avatars.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Create a new profile. Edit that new profile to have a "plane" icon. Go into the account menu of the original profile browser, the avatar should be visible for the profile in the list of profiles.
• Risk associated with taking this patch: low
• Explanation of risk level: Simple image size switch.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 12

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 2064729 - Replace using size 24 icons with size 16 for profiles

Original Revision: https://phabricator.services.mozilla.com/D321238

Comment 14

[Simona Badau, Desktop Test Engineering]

Reproduced the initial issue on Firefox 155 on Windows 11, Ubuntu 24.04 and macOS 26.

Verified as fixed using Firefox 156.0b2 on Windows 11, Ubuntu 24.04 and macOS 26 - the profile icons are now properly displayed in the Profiles section of the Account menu.

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d76f0346a658
https://hg.mozilla.org/releases/mozilla-release/rev/66c85f013bd4

Comment 16

[Ryan VanderMeulen [:RyanVM]]

(In reply to Pulsebot from comment #15)

Added to the 155.0.1 relnotes.

Comment 17

[Simona Badau, Desktop Test Engineering]

Verified as fixed using Firefox 155.0.1 on Ubuntu 24.04, macOS 26 and Windows 11 - the profile icons are now properly displayed in the Profiles section of the Account menu.