Closed Bug 2074906 Opened 1 month ago Closed 1 month ago

[HCM] Disabled toolbar buttons should use GrayText and be opaque

Categories

(Toolkit :: Themes, defect, P3)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: mstriemer, Assigned: kramerjaron)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

In bug 2023649 the disabled toolbarbuttons are being updated to match the enabled ones, but they're still at opacity: 0.3 since they aren't using GrayText

Update the disabled styles so they use the disabled button tokens rather than relying on opacity in HCM

Summary: [HCM] Toolbar buttons should use GrayText and be opaque → [HCM] Disabled toolbar buttons should use GrayText and be opaque

The severity field is not set for this bug.
:tgiles, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(tgiles)

Use the disabled button opacity, text, and border tokens for disabled primary toolbar buttons in forced colors, including the overflow and menu buttons during customization. Preserve the reload button appearance while it is temporarily disabled.

Assignee: nobody → kramerjaron
Status: NEW → ASSIGNED
Attachment #9651226 - Attachment description: Bug 2074906 - Use disabled button tokens for toolbar buttons in high contrast mode. r?#desktop-theme-reviewers → Bug 2074906 - Use disabled toolbar button tokens in forced colors. r?dao
Severity: -- → S3
Flags: needinfo?(tgiles)
Priority: -- → P3
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5637f739eb9d https://hg.mozilla.org/integration/autoland/rev/b0d6d2bc5c8a Use disabled toolbar button tokens in forced colors. r=desktop-theme-reviewers,dao,places-reviewers,reusable-components-reviewers,mstriemer,mak
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Regressions: 2084519
Regressions: 2084538
See Also: → 2084614
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: