Closed Bug 2084538 Opened 1 month ago Closed 1 month ago

[HCM] The profiler toolbar button looks the same while capturing a profile as when idle

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect

Tracking

(firefox-esr153 unaffected, firefox158 unaffected, firefox159 unaffected, firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox158 --- unaffected
firefox159 --- unaffected
firefox160 --- fixed

People

(Reporter: dao, Assigned: dao, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: access, regression)

Attachments

(1 external file)

While a profile is being captured, the profiler toolbar button gets the profiler-paused class and ignores clicks (onCommand in menu-button.sys.mjs returns early when Services.profiler.IsPaused()). The only visual cue is --profiler-button-image-opacity-paused, which maps to --toolbarbutton-opacity-disabled. Under forced colors, bug 2074906 made that token resolve to 1, so the capturing state now looks like the idle one.

The button is non-interactive while capturing, so it should get the real disabled attribute. Then the disabled toolbar button styling applies, GrayText under forced colors included, and assistive technology sees the state.

Set release status flags based on info from the regressing bug 2074906

:kramerjaron, since you are the author of the regressor, bug 2074906, could you take a look?

For more information, please visit BugBot documentation.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0a69b6caebb3 https://hg.mozilla.org/integration/autoland/rev/e0c0e9230958 Disable the profiler toolbar button while capturing a profile. r=profiler-reviewers,canova
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: