Closed Bug 2078235 Opened 1 month ago Closed 3 days ago

[Fitts's law] When the mouse pointer is at the left edge of the screen, the Bookmark/History Sidebar can no longer be scrolled using the mouse wheel.

Categories

(Firefox :: Sidebar, defect, P2)

Firefox 157
Desktop
Windows 11
defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr153 --- unaffected
firefox157 --- wontfix
firefox158 --- wontfix
firefox159 --- wontfix
firefox160 --- wontfix
firefox161 --- wontfix
firefox162 --- fixed

People

(Reporter: alice0775, Assigned: kcochrane)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: nightly-community, regression, ux-efficiency, Whiteboard: [fidefe-sidebar])

Attachments

(1 external file)

Steps to reproduce:

  1. sidebar.revamp = true
  2. sidebar.visibility = hide-launcher
  3. Maximize browser
  4. Open bookmarks or history sidebar and expand folders so that the contents of sidebar will be scrollable
  5. Move the mouse pointer until it reaches the left edge of the screen.
  6. Try to scroll the bookmarks sidebar with mouse wheel

Actual results:
Nothing happens.
This problem occurs regardless of the setting for sidebar.updatedBookmarks.enabled.

Expected results:
The contents of sidebar should be scrolled

Summary: [Fit Rule] When the mouse pointer is at the left edge of the screen, the Bookmark/History Sidebar can no longer be scrolled using the mouse wheel. → [Fitts's law] When the mouse pointer is at the left edge of the screen, the Bookmark/History Sidebar can no longer be scrolled using the mouse wheel.

:sfoster, since you are the author of the regressor, bug 1978102, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(sfoster)

When a panel is open without the launcher, set launcherVisible in SidebarState.sys.mjs sets paddingInlineStart: var(--space-small) on #sidebar-box. In hide-launcher mode, that padding is what sits at x=0, so wheel events land on chrome instead of the #sidebar browser that scrolls. With Nova on, the box paints the panel background, so this gutter looks like part of the panel, and sidebar.css already drops the box's start border because that edge meets the window.

Fix: Don't apply this padding when the box touches the window edge (at minimum under Nova), so #sidebar reaches x=0, and extend test_launcher_hidden_and_panel_shown in browser_hide_sidebar.js with a synthesizeWheel at the leading-edge pixel, following browser_vertical_tabs_fitts.js. The backed-out refactor in bug 2066086 moves this same expression into #updatePanelPadding(), so whichever lands second needs a rebase.

Suggested severity: S3. Wheel scrolling of the sidebar panel fails only in the leftmost pixels of a maximized window, in the non-default hide-launcher mode, and moving the pointer slightly right restores it.


If you'd like to provide feedback on this comment, please use the 👍 or 👎 reaction.
If you want to categorize your feedback you can add one of the following tags: ai-triage-{wrong-file, wrong-cause, hallucination, out-of-scope, not-a-bug, wrong-fix, shallow-fix, wrong-severity}.

Needinfo hackbot@mozilla.tld to have a patch generated for this bug, include any questions or directions as needed in your comment.

There's padding-inline-start on the #sidebar-box and the .sidebar-panel rule has inline padding which means the scrollable content child element wont get the scroll events when the pointer is at the window edge. This is indeed a regression from the sidebar.revamp=false old history and bookmarks panels - which had all that spacing internal to the scrollable element.

Severity: -- → S3
Flags: needinfo?(sfoster)
Priority: -- → P2
Whiteboard: [fidefe-sidebar]
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a80876a1a028 https://hg.mozilla.org/integration/autoland/rev/eba29c70e33b Ensure sidebar panels are scrollable at the window edge in hide-launcher mode r=desktop-theme-reviewers,sidebar-reviewers,mstriemer,jsudiaman
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

The patch landed in nightly and beta is affected.

:kcochrane, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox161 to wontfix if the fix can wait for the next release.

Uplift requests can be submitted from Lando: D339696.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: