Closed Bug 2079158 Opened 1 month ago Closed 1 month ago

Update the search messages dialog to work the same way as about:3pane's thread pane

Categories

(Thunderbird :: Search, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
160 Branch

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 2 open bugs, Regressed 1 open bug)

Details

Attachments

(4 external files)

The search dialog is still stuck in the pre-115 days, using a XUL tree to list messages. If we update it to work the same way as the thread pane in about:3pane, we can remove a lot of code that only remains to keep the dialog alive, and it will be easier to convert the UI to use the new database.

There's no reason for this dialog to have an upper-case 'S'. It's time to change.

The new code in this patch will be familiar to those who've worked on about:3pane. It's not
exactly the same (e.g. persistence is done using the XUL store instead of folder databases) and a
lot of the old code is still hanging around, but the main change is done.

Target Milestone: --- → 160 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e06b27e8b5f8
Rename SearchDialog.xhtml to searchDialog.xhtml. r=klamping
https://hg.mozilla.org/comm-central/rev/2508f7c93c1b
Convert the search dialog to use a TreeView instead of a XUL tree. r=mkmelin
https://hg.mozilla.org/comm-central/rev/dc6fd65c9170
Remove dead code that only existed for the search dialog. r=vineet
https://hg.mozilla.org/comm-central/rev/89991c77a8b2
Migrate XUL store values for search dialog. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/09cab76405df follow-up - Remove reference to an old file. rs=bustage-fix
Regressions: 2083474
Regressions: 2093282
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: