214519 - add "Mozilla", "Firefox", and "Thunderbird" to the dictionary by default

Status: RESOLVED DUPLICATE of bug 339123

(Core :: Spelling checker, enhancement, P1)

Description

[Dave Evans]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Thunderbird 0.1 Milestone

Please add "Mozilla" and "Thunderbird" to the dictionary by default.

"Netscape" is in there by default ... "Mozilla" and "Thunderbird" should be in
there as well

Reproducible: Always

Steps to Reproduce:
1.Write an email praising how good "Mozilla Thunderbird" is
2.hit send
3.

Actual Results:  
spell check catches "Mozilla" and "Thunderbird" as being spelling mistakes

Expected Results:  
Netscape is in the dictionary ... so "Mozilla" and "Thunderbird" should be in
there as well

Comment 1

[Bronson C. Elliott]

It looks like "Mozilla" has been added but it still suggests "Thunder bird" for
"Thunderbird".

Comment 2

[Dave Miller [:justdave]]

Changing OS/Hardware to All/All, I just reproduced this on Mac OS X. :)

"Mozilla" is still not in the dictionary on OS X.  "Thunderbird" isn't either,
nor is "Firefox" for that matter.

I just got an email on the bugzilla admin address from someone complaining about
it who thought the query form was too difficult to look for this (but that's
another bug ;)

Comment 3

[Dave Miller [:justdave]]

I'm told that the spell checker is actually part of the core Browser code, and
is borrowed for MailNews and Thunderbird, so moving to Browser.  (Can't find an
existing bug there on this).

Comment 4

[Dave Miller [:justdave]]

This is something I'm sure product reviewers will razz us about if they discover
it.  Can it block a release?

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

The patch would be simple enough.
The question is: do we want to maintain our own dictionary? Or do we want to
work with openoffice.org on this?

Comment 6

[Asa Dotzler [:asa]]

Not going to block the release on this but we'd certainly consider a reviewed
patch. 

Comment 7

[Tom Graham]

The spell checker is something that needs to seriously re-evalutated for future
thunderbird releases. Simple words are not picked up, and not having your own
organisation in the lists is really just embarassing.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

mscott, do you have ideas on how we want to maintain the word list? see comment 5

Comment 9

[Jo Hermans]

*** Bug 251990 has been marked as a duplicate of this bug. ***

Comment 10

[Tom Graham]

(Re #6) I'd love to attempt to make a patch; as a Windows user and a relativly
inexperienced coder however i'm finding it hard to get to grips with Mozilla's
patch making program and procedures. Anyway, i've attempted to identify what
needs to be done :

This file : mozilla/ extensions/ spellcheck/ myspell/ dictionaries/ en-US.dic
(http://lxr.mozilla.org/seamonkey/source/extensions/spellcheck/myspell/dictionaries/en-US.dic)
 i believe needs to be updated. The words it doesn't contain (and would thus
benefit from) are :
-Thunderbird
-Firefox
-Mozilla

In the same context, developers really need to look at this in terms of doing a
over-hall of the whole spelling situation (other big company names - e.g.
google, nvidia, in by default); it is in dire need of some attention.

Comment 11

[Bernd]

hmm I don't see a thunderbird flag, but it would be cool to get this fixed for 1.0

Comment 12

[Scott MacGregor]

too late for this now. This bug doesn't even have an owner yet. 

Comment 13

[Tom Graham]

(In reply to comment #12)
> too late for this now. This bug doesn't even have an owner yet. 

This is a much wider issue, that needs addressing. Interestingly, there is a
great extension for Firefox that does spell checking. It has a far more
extensive wordlist (includes the foundations names) and works very well (does
red underlining ala MS Office and as requested in another bug). I'm wondering
how hard it would be to encorporate it into Thunderbird?

Link here : http://spellbound.sourceforge.net/

Comment 14

[Neil Deakin]

*** Bug 280562 has been marked as a duplicate of this bug. ***

Comment 15

[Doug Turner (:dougt)]

anyone have a openoffice bug for this?

Comment 16

[Karsten Düsterloh]

*** Bug 298926 has been marked as a duplicate of this bug. ***

Comment 17

[Jo Hermans]

*** Bug 265495 has been marked as a duplicate of this bug. ***

Comment 18

[Jo Hermans]

*** Bug 312139 has been marked as a duplicate of this bug. ***

Comment 19

[Frankie]

Attachment: Patch in GNU diff format

This is such a small trivial change to implement, just a handful of lines added
to
http://lxr.mozilla.org/seamonkey/source/extensions/spellcheck/locales/en-US/myspell/en-US.dic


Sadly, my knowledge of CVS is lacking. Do I really need to download the entire
suite project source just to modify one file? Or is there a friendlier app that
can generate a CVS-style diff from a pair of files?

Comment 20

[Frankie]

Attachment: Patch v1

Thanks to db48x for the CVS lesson. Apologies to Simon for the request. I did
not find a module owner for extensions/spellcheck.

Comment 21

[Simon Fraser [no longer active]]

What does /M mean?

Comment 22

[Scott MacGregor]

these dictionaries come from open office and we don't want to be making local
changes to them. You'll just end up losing those changes the next time we copy a
new version of the dictionary into the tree. As I've said many times before, if
folks are interested in adding words to the dictionary please go through the
open office / msypell bug database and file it there. 

Comment 23

[Frankie]

Okay, I'm registering at development.OpenOffice.org now and will submit a patch
there.

Is there a keyword or special component listing for a bug that is dependent on
external files?

Comment 24

[Frankie]

Hmm... the "Accept bug" button didn't stick.

FWIW, the \M flag indicates a noun that can take the possessive suffix ('s).
http://lingucomponent.openoffice.org/english.aff

Comment 25

[Wayne Mery (:wsmwk)]

anyone know why http://www.openoffice.org/issues/show_bug.cgi?id=56389 hasn't been confirmed after almost 2 months 

Comment 26

[Dave Miller [:justdave]]

Why is it necessary to wait for OOo to add it to their dictionary?  Don't we have a "user dictionary"?  What's wrong with having that stuff added to the user dictionary by default on a new profile?  This seems a more-friendly way to do it without expecting OOo to cater to every application on the planet.

Comment 27

[Frankie]

Good news, folks. OOo has added my patch. To quote: "Verified in ooo202dict02 CWS and in builds, too. Both Linux and Windows."

Removing myself as Assignee. I've done what I can; the rest is up to Mozilla's higher authorities.

Comment 28

[zug_treno]

*** Bug 330636 has been marked as a duplicate of this bug. ***

Comment 29

[Frank Wein [:mcsmurf]]

Well, i think the SeaMonkey/Thunderbird/etc. dictionary gets updated every few month from upstream. So someone might need to do that again (i'm not sure who has done that in the past).

Comment 30

[Scott MacGregor]

Frankie, thanks a lot for working with the OOO guys to get this added to the dictionaries!

I'll keep an eye on:

http://lingucomponent.openoffice.org/spell_dic.html

and will update our en-us dictionary files when I see the new one show up. 

Comment 31

[Jo Hermans]

*** Bug 336390 has been marked as a duplicate of this bug. ***

Comment 32

[u88484]

Scott: just checked out the dic on OOO and still not in there. 

Guys, can we please just add them locally? If we download a newer version in the future to ship with and its not in there just add it again...not that hard. Eventually they will add it and them we won't. Its polish work for us and looks bad if our own products/company show up in the dictionary as wrong.

On another note: man there bug reports are hard to read...bugzilla is much easier on the eyes.

Comment 33

[Simon Bünzli]

*** Bug 337307 has been marked as a duplicate of this bug. ***

Comment 34

[Brett Wilson]

I also strongly recommend blog blogger blogging and blogged. It's likely bloggers will be some of the most heavy users of this feature.

Comment 35

[Damian Yerrick]

Why isn't "firefox" (lowercase) also in the patch?  It is another name for
either of two animals:
http://en.wikipedia.org/wiki/Red_Panda (Ailurus fulgens)
http://en.wikipedia.org/wiki/Red_Fox (Vulpes vulpes)

Comment 36

[Brett Wilson]

See also bug 308744 for "unsubscribe"

Comment 37

[Brett Wilson]

*** This bug has been marked as a duplicate of 339123 ***

Comment 38

[Simon Paquet [:sipaq]]

Comment on attachment 200114 [details] [diff] [review]
Patch v1

This bug was duplicated to bug 339123, which fix has incorporated the changes in this patch. Therefore I'm removing the review request.