214962 - IMAP folders (e.g. Trash) will not work without trailing "/" in prefs

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Joseph Simmons]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; Q312461; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: Thunderbird 0.1 (20030727)

When setting up an account, if you neglect to add the trailing "/", any 
function that requires movement of a message from one folder to another will 
fail.  The error will read "

Reproducible: Always

Steps to Reproduce:
1. Tools -> Account Settings -> Server Settings -> Advanced -> IMAP server 
directory
2. Enter IMAP directory without trailing "/"
3. Save settings and restart application
4. Attempt action which moves a message from one folder to another, ie. 
deleting it.
5. Program will generate error: The current command did not succeed.  The mail 
server responded: [TRYCREATE] UID COPY Failed: No such destination mailbox.

Actual Results:  
Program generates error.

Expected Results:  
Program should have intelligence added to assume that if a trailing "/" isn't 
present that it should implicitly place one.

Comment 1

[James Ross]

Just ran into this with the 0.1 release! Shockingly, it wasn't broken in the
previous release I was using, which I thought was the 0.1 cadidate. Oh well.

I's say it's not really 'minor' since I just switched builds only to find it
completely failed to access any of my IMAP folders! (--> normal)

Updating summary, since this affects all IMAP folders.

Comment 2

[Bronson C. Elliott]

Duplicate of 214284.

Comment 3

[Scott MacGregor]

*** Bug 214284 has been marked as a duplicate of this bug. ***

Comment 4

[David :Bienvenu]

I didn't realize this used to work, actually...

Comment 5

[David :Bienvenu]

Attachment: proposed fix

this adds back the hierarchy delimiter if not included in the online dir.

Comment 6

[David :Bienvenu]

Scott, you might want to try this patch for thunderbird.

Comment 7

[Scott MacGregor]

checked into the 0.2 branch. if we do another respin we'll pick this up.

will leave open since it isn't in the trunk yet

Comment 8

[David :Bienvenu]

*** Bug 216963 has been marked as a duplicate of this bug. ***

Comment 9

[David :Bienvenu]

Attachment: add special folder handling

This code fixes the case where we're trying to save to the sent folder or
drafts, and the online dir is the same as the personal namespace. We used to
create a folder called INBOX.INBOX.Sent which caused some strange problems.

Comment 10

[David :Bienvenu]

*** Bug 217569 has been marked as a duplicate of this bug. ***

Comment 11

[Scott MacGregor]

FYI, I put this 2nd patch into the 0.2 branch as well.

Comment 12

[David :Bienvenu]

*** Bug 217960 has been marked as a duplicate of this bug. ***

Comment 13

[David :Bienvenu]

*** Bug 218194 has been marked as a duplicate of this bug. ***

Comment 14

[David :Bienvenu]

changing product - this is a problem with the core code.

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 130683 [details] [diff] [review]
add special folder handling

r/sr/a=sspitzer

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 130664 [details] [diff] [review]
proposed fix

r/sr/a=sspitzer

shouldn't

(PL_strlen(ns->GetPrefix()) != 0)

just be

(strlen(ns->GetPrefix())

Comment 17

[David :Bienvenu]

fix checked in - I was getting a lot of dups filed on this, not to mention IM's :-)

Comment 18

[David :Bienvenu]

*** Bug 218334 has been marked as a duplicate of this bug. ***

Comment 19

[David :Bienvenu]

*** Bug 218657 has been marked as a duplicate of this bug. ***

Comment 20

[Vaclav Dvorak]

*** Bug 218060 has been marked as a duplicate of this bug. ***