Closed Bug 220214 Opened 21 years ago Closed 20 years ago

master password dialog keeps showing up after entering a character, clicking cancel, entering another character

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: darin.moz, Assigned: bryner)

References

(
URL
)

Details

Attachments

(1 file)

patch
6.19 KB, patch
Details | Diff | Splinter Review
SUMMARY master password dialog not canceled [prompted twice]. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030917 Firebird/0.6.1+ STEPS TO REPRO 1- startup the browser 2- go to some page that requires HTTP authentication. 3- a) if you have the required username+password stored in password manager, then you should see a dialog prompting you to enter your master password. at this prompt, press cancel. notice that the dialog appears again. b) if you do not have the required username+password stored in password manager, then enter the correct username+password, and press OK. you will be presented with a master password prompt. try pressing cancel, and you will notice that the master password dialog appears again. 4- press cancel a second time, and indeed the dialog goes away.
product=browser is probably wrong, but then there isn't any component under product=firebird that seems to have anything to do with password manager or satchel. *shrug*
bryner: i have a simple testcase at http://9.25.163.241/test/auth/ username=foo password=foo
Attached patch patch — — Splinter Review
Check return result from DecryptData so that we don't continue with any password manager activity if the user cancelled out.
i checked this patch in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 216534 has been marked as a duplicate of this bug. ***
*** Bug 216704 has been marked as a duplicate of this bug. ***
I don't mean to spam people about this, but is this fix being considered for the Firebird 0.7/Mozilla 1.5 branch too? I realize it's extremely late in the game, but it seems very low-risk and this bug was one of my top annoyances for several months.
Well, now it asks only once for the master password upon pageload. But it keeps asking after every single character you type in the username field if you click cancel/hit esc. If I say cancel, I mean cancel! -> reopening. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20030925 Firebird/0.7+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*** Bug 219175 has been marked as a duplicate of this bug. ***
*** Bug 215994 has been marked as a duplicate of this bug. ***
-> Firebird/General really need to figure out what other components we'll need under Firebird, General is overloaded
Component: Password Manager → General
Product: Browser → Firebird
QA Contact: tpreston → mpconnor
Version: Trunk → unspecified
Related to bug 134593 and dupes ?
Cancel how? Disable all password manager functionality for the rest of the session? Disable it forever?
It shouldn't disable forever, because I might want to skim a forum without logging in, but I definitely want to log in sometimes; I wouldn't have got credentials saved otherwise. It shouldn't disable for the whole session, because I might change my mind and login to the same site or a different one later on. Therefore it should disable on the current page only. But it should ask only once upon pageload (this was fixed by this bug), and of course it shouldn't ask after every single character typed in the username field (a regression which was introduced by this bug).
Until we get a Password Manager component, I'm moving all such active bugs to Autocomplete with [pwd-mngr] at head of the summary for querying. Sorry for the bugspam. As it happens, I've never been prompted for a master password in Linux...
Component: General → Autocomplete
Summary: firebird: master password dialog not canceled [prompted twice] → [pwd-mngr] firebird: master password dialog not canceled [prompted twice]
Component: Autocomplete → Password Manager
All/All and adjusting summary, see comment 8.
OS: Linux → All
Hardware: PC → All
Summary: [pwd-mngr] firebird: master password dialog not canceled [prompted twice] → master password dialog keeps showing up after entering a character, clicking cancel, entering another character
Neither the testcase in comment #2, nor the URL link for this bug seem to exist. There is a testcase at http://jigsaw.w3.org/HTTP/Basic/ however. Login is guest/guest.
> Neither the testcase in comment #2, nor the URL link for this bug seem to exist. That's true. > There is a testcase at http://jigsaw.w3.org/HTTP/Basic/ however. Login is > guest/guest. That uses basic auth (notice the popup asking for your credentials), which isn't affected. Try any form based login like bugzilla or forums.mozillazine.org. Delete your login cookies and restart the browser if you entered the master password before.
URL: https://w3.ibm.com/bluepages → http://bugzilla.mozilla.org/query.cgi...
My symptoms are slightly different: I have a proxy that requires authentication, and I have the username/password saved in Password manager. The dialog comes up on my first pageload with the credentials already entered, and the "save in password manager" box checked, so I click OK to go on. After that, is when I get the prompt for the "master security device", which I can click "cancel" and it all still works (and I don't get asked again). This did not happen in Firebird 0.7.
Correction: my symptoms do not happen in 0.6.1 on WinXP. Haven't tried 0.7.
(In reply to comment #18) > There is a testcase at http://jigsaw.w3.org/HTTP/Basic/ however. Login is > guest/guest. The problem that I notice is that password manager does not have an option to automatically bypass this dialog when you have a saved user/pass for a site. For instance: 1. go to this site 2. I get the dialog, enter user & pass and check to save the password. 3. If I return to the website without closing firefox I dont have to deal with the popup dialog. But if I close firefox and then open it again and try to access the site then the popup dialog is displayed and I must accept to access the site. This is not so much a problem with this specific test site, but when I use firefox to access web pages on my companies intranet & I am forced to accept through the password dialog for every couple of pages it becomes annoying. IE(insecurity?) handles this auth much better. With mozilla this was less of a problem because it would remain in memory(remembering auths) & I wouldnt reboot my computer for weeks. I would like to see an option in the password manager to automatically bypass the password dialog for certain sites where you have saved passwords.
OK, a bug must have been fixed, because in 0.8 (Firefox) I get the master security device prompt first; once I enter that, it pops up the Squid proxy authentication window, already filled out, and I just hit enter. I'm sure it's more secure, but do the saved passwords (which are filled in but not human visible) really need to be protected behind the master security device? I only put logins in there out of convenience... it's nothing I'm worried about someone stealing.
Todd, what is needed in your case is UI to change your master password. If you change your master password to the empty password, then Firefox will no longer require you to enter a master password to decrypt your password file. I'm sure there's a bug already on this somewhere.
It's bug 218694. See bug 216539 comment 4 for the current workaround.
I am having the same problem as originaly described (the remember password box appears twice).
I forgot to add some relevant information. Firefox 0.9.3 - Gentoo Linux Build
Bug is reproducable on Fedora Core2 with Firefox 1.0PR.
Bug is reproducible on WinXP Pro using Firefox 1.0. 1. Click "view saved passwords" in privacy options with master password set 2. Press cancel in security device prompt (with or without entering any data) 3. Prompt will appear again up to 4 times 4. Then empty saved passwords window appears.
Ok, this bug is drifting apart. I can definitely reproduce comment 28, and moved that to bug 269138. Comment 0 was fixed in 2003. Note that that was about http auth, not about web forms. I can no longer reproduce comment 8 with Firefox 1.0, which is what this bug is about since I morphed it. For the problems in comment 25 and comment 27, please open a new bug, with detailed steps to reproduce. This bug is not helpful anymore. -> WORKSFORME.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → WORKSFORME
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: